Vishnu Mohan
cbe60c952e
kubectl: fix expose --selector help text
...
The current help text wordings incorrectly suggests inference only works for RC/RS when it actually works for Pods and Deployments too
Update help text to accurately reflect that selector inference works
for any resource being exposed, as documented in main expose help.
Kubernetes-commit: 5c8f26f48032899031760e5b75ad259d23d312b2
2025-08-19 01:19:07 +05:30
Jordan Liggitt
722397942b
Drop null creationTimestamp from test fixtures
...
Kubernetes-commit: 6bb6c9934294d8265197c9dfc4c9dd3adaca147a
2025-03-24 09:37:26 -04:00
Amirsadra Abdollahi
41e94233a1
Fix: correct dryRunStratergy typo in kubectl expose cmd
...
Kubernetes-commit: 041337648938dee4229a4147a0239527b3689082
2024-03-25 18:58:35 +03:30
git-jxj
826006cdb9
cleanup: Update deprecated FromInt to FromInt32 ( #119858 )
...
* redo commit
* apply suggestions from liggitt
* update Parse function based on suggestions
Kubernetes-commit: a5b3a4b738e9576b68c3083de8b72002e0b45551
2023-08-16 21:07:06 +00:00
Stephen Kitt
4729836f7f
Use intstr.Parse instead of reimplementing it
...
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Kubernetes-commit: 7f53f7649e178622ad1a64988913f025399f152b
2023-07-13 12:02:26 +02:00
aimuz
2ec2847518
fix: kubectl expose fails for apps with same-port, different-protocol
...
Fixed: https://github.com/kubernetes/kubernetes/issues/114402
Signed-off-by: aimuz <mr.imuz@gmail.com>
Kubernetes-commit: e5116a39c96a78511fc8c0da4730d3262b2c121c
2023-06-19 09:58:54 +08:00
Varsha Prasad Narsing
a49f0e6d53
[refactor] refactoring flags and options in Expose cmd
...
This PR decouples the command options from the input flags.
The input flags from the command are then translated to
options which are further used while running the command.
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Kubernetes-commit: 8f229057484453bd1b820d00c940efbbc56addc5
2023-05-05 11:31:03 -04:00
Stephen Kitt
cfd2169f88
cli: replace intstr.FromInt with intstr.FromInt32
...
This touches cases where FromInt() is used on numeric constants, or
values which are already int32s, or int variables which are defined
close by and can be changed to int32s with little impact.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Kubernetes-commit: 45836971f27ca70cd7742e8ee66e99e3c648cf9f
2023-03-14 16:17:48 +01:00
Arda Güçlü
3f05cfcd78
Migrate genericclioptions.IOStreams usage to genericiooptions
...
Kubernetes-commit: 00c30941260a27e6929aef84c7fdbc8f1508518c
2023-04-05 14:07:46 +03:00
Sean Sullivan
6dde41fea6
Removes unnecessary dry run verifier
...
Kubernetes-commit: 530f65d6fd5af81c0691143fbf2c00d440476bb9
2022-12-05 16:25:12 -08:00
cndoit18
c688132ac9
style: remove redundant judgment
...
Signed-off-by: cndoit18 <cndoit18@outlook.com>
Kubernetes-commit: ec43037d0f57fdfc2fdc4960fdb8a7e31ac79fae
2022-07-29 18:25:05 +08:00
xiaopeng
bc02b7b600
add setErr
...
Signed-off-by: xiaopeng <hanxiaop8@outlook.com>
Kubernetes-commit: 8839609868d4b2b5887eefdbb216c1ed5b848edc
2022-06-21 17:57:48 +08:00
xiaopeng
a833054047
replace deprecated setoutput
...
Kubernetes-commit: 48629bcc0588773bc837d1cc69cab8b21a2057e0
2022-04-05 14:04:22 +08:00
Chok Yip Lau
de77e6a05b
Remove generator dependency of expose.go
...
Kubernetes-commit: d7ab8d442b7913e5eb69fc2ce93b2b704645b089
2021-12-04 16:38:01 -05:00
Marc Khouzam
cd5b039b42
Refactor completion code into its own package
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
Kubernetes-commit: c4f8c57b43843abd13bae677b73c622e1c30b46f
2022-03-24 09:06:05 -04:00
Kevin Delgado
7e681490ec
Generalize dry run verify to arbitrary query param
...
Kubernetes-commit: d6c83281bc696474a76365a879f2255b8b568786
2022-03-09 14:51:50 +00:00
brianpursley
07f77100fc
Add --override-type flag to kubectl run and kubectl expose to allow the choice of using a JSON Patch or Strategic Merge Patch to apply the override to the generated output.
...
Kubernetes-commit: 0e697e19ac9f73e2efa0e60157730ba8731e3847
2021-11-05 07:10:47 -04:00
Andrea Hoffer
09ed00ef49
Minor adjustments to descriptions and example text
...
Kubernetes-commit: 6b736f348483bb6b20d4633319305960f4d9e4c1
2021-07-06 15:05:26 -04:00
Marc Khouzam
724356168b
Revert "Add Go tests for custom completions"
...
This reverts commit 0e18f0380042b652996d795559bfb818698abec3.
Kubernetes-commit: 1babceac650cfe8ec7ac71b34ed1ecf118b50f9d
2021-05-22 20:47:14 -04:00
Marc Khouzam
5c679b006e
Join common functions for completion
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
Kubernetes-commit: 9625872d1e4fd0d4d397b3ab732c6969a3a376fe
2021-05-15 21:22:42 -04:00
Marc Khouzam
af40736fcc
Add Go tests for custom completions
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
Kubernetes-commit: c0b3a698fa15265eecdec0bd8776658c40d8d151
2021-03-05 15:44:30 -05:00
Marc Khouzam
1946af5761
Move all completion bash code to Go code
...
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
Kubernetes-commit: 879cdc5fa9e518ce76b9e1dc7e795132457966f3
2021-03-05 15:43:31 -05:00
Julian V. Modesto
04f62ffb0b
Cache the OpenAPI schema for server-side dry-run.
...
Currently, server-side dry-run fetches the OpenAPI schema for every
single object.
This change fetches the OpenAPI schema only once.
Kubernetes-commit: caa158610dfb53de3582ed6df0eb37359206fc66
2021-01-19 16:36:14 -05:00
Masashi Honma
3c3bc4f5e8
Namespace has no effect when exposing deployment with --dry-run=client
...
This is how to reproduce.
$ kubectl create ns testns
$ kubectl -n testns create deployment test-deploy --image=nginx
$ kubectl -n testns expose deployment.apps/test-deploy --port=80 --dry-run=client -o yaml
apiVersion: v1
kind: Service
metadata:
creationTimestamp: null
labels:
app: test-deploy
name: test-deploy
spec:
ports:
- port: 80
protocol: TCP
targetPort: 80
selector:
app: test-deploy
status:
loadBalancer: {}
If --dry-run=client is not specified, namespace element is contained in the yaml.
Kubernetes-commit: 8d83dfe2075be68344a633418de7ef81e1dd5957
2020-12-24 09:40:10 +09:00
Karl 'NaN' Wikström
38408eaa8c
cleanup: use i18n.T on all command descriptions
...
cleanup: use i18n.T only on string literals
cleanup: sort imports
Add i18n dependency for wait.go
Remove translation on envResource
cleanup: translate string instead of variable
cleanup: sort imports
cleanup: translate string literal only
Kubernetes-commit: cc8428566ea7160c5b20410a1bee53ca7ddb998e
2020-10-09 13:16:13 +02:00
Davanum Srinivas
445ad1366b
switch over k/k to use klog v2
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
Kubernetes-commit: 442a69c3bdf6fe8e525b05887e57d89db1e2f3a5
2020-04-17 15:25:06 -04:00
Julian V. Modesto
415a73888a
Set kubectl field manager names
...
Kubernetes-commit: 360c348d0eb5be8c7c9720d5bfda16dbe04e8d15
2020-03-04 22:04:01 -05:00
Julian V. Modesto
f9460c5333
Use --dry-run=client,server in kubectl.
...
- Support --dry-run=server for subcommands apply, run, create, annotate,
expose, patch, label, autoscale, apply set-last-applied, drain, rollout undo
- Support --dry-run=server for set subcommands
- image
- resources
- serviceaccount
- selector
- env
- subject
- Support --dry-run=server for create subcommands.
- clusterrole
- clusterrolebinding
- configmap
- cronjob
- job
- deployment
- namespace
- poddisruptionbudget
- priorityclass
- quota
- role
- rolebinding
- service
- secret
- serviceaccount
- Remove GetClientSideDryRun
Kubernetes-commit: 13b80b48cd02b8263d910f2423a1f5b92cdf7644
2020-01-30 20:23:33 -05:00
Julian V. Modesto
c0b11fa131
Extend --dry-run to support string values.
...
* Extend --dry-run to support string values for dry run strategies
'client', 'server', and 'none'
* Ensure --dry-run is set and accessed via cmdutil
* Deprecate --dry-run (unset), --dry-run=true, and --dry-run=false
Kubernetes-commit: af52beda260257e81cc9e19e9e5108b682ee93d6
2019-12-15 18:29:27 -05:00
Clayton Coleman
4ca8f5ecfe
test: kubectl unit tests should be using codecs without conversion
...
Tests are also refactored to use the simpler RESTClient code path.
Kubernetes-commit: 8a9b8c87c40ee65751828d9dd02f4f642588f0ce
2019-11-03 15:20:10 -05:00
Sean Sullivan
3ec9685c39
Rename test/data directory to testdata
...
Kubernetes-commit: 4ce97d6c48ae4735463f020430dd20539a03e8c5
2019-10-31 13:40:02 -07:00
Sean Sullivan
1cba7858ad
Update test data to reflect code move to staging
...
Kubernetes-commit: 58b59ae4e07f9d3718271a43740a4de9508d8688
2019-08-01 15:17:53 -07:00
Sean Sullivan
1483769081
Update gofmt
...
Kubernetes-commit: e2cae2344486af198f8ab38e4dd97d4f24dfd190
2019-08-01 13:14:06 -07:00
Sean Sullivan
5b48717f2d
Update import statements to reflect code move
...
Kubernetes-commit: acece3c2964115a4f29a43e368ad5de59dbbc258
2019-08-01 11:10:05 -07:00
Sean Sullivan
c6063dd846
Move pkg/kubectl/cmd/{command} to staging
...
Kubernetes-commit: 0e0ea523392f1121f61f99ac30a9bc2043eaed90
2019-08-01 11:01:40 -07:00