Commit Graph

3445 Commits

Author SHA1 Message Date
Anish Shah 3c43664ced Refactor `kubectl proxy` command to have similar design pattern as other kubectl commands.
Few days ago I watched this kubectl code base tour on Youtube
(https://www.youtube.com/watch?v=uz8TS3V9qqY). It talks about a design
pattern that almost every command follows. But I found out that
`kubectl proxy` command does not follow this pattern. So, I'm
refactoring this command to use similar design pattern as other kubectl
commands.

Kubernetes-commit: 0bd41a300f12b1dbaec19fc94b868f91640542df
2019-09-21 10:52:42 -07:00
Kubernetes Publisher 0e9f77c7d7 Merge pull request #82914 from Random-Liu/fix-kubectl-panic
Fix kubectl panic when handling invalid error.

Kubernetes-commit: 08ef34a2b0ca2b3ceefea3bcf9dc387dc204c42b
2019-09-21 00:18:14 +00:00
draveness 52ca74d33b feat: bump github.com/prometheus/common to v0.4.1
Kubernetes-commit: c42393c16d72e2d754372169901c19cff1e1c7ae
2019-09-20 16:42:57 +08:00
Lantao Liu 7c6594395c Fix kubectl panic when handling invalid error.
Kubernetes-commit: 12d944b860e4872085fa1155590c7fcef58e6bb8
2019-09-19 21:48:50 -07:00
Kubernetes Publisher ced7900f20 Merge pull request #81917 from hwdef/fix-typo-staging/src/k8s.io
Fix typo in kubectl docs

Kubernetes-commit: abbba0b5165411f9ceed14ad197dc0b284606c7a
2019-09-19 20:18:45 +00:00
Kubernetes Publisher 5bf8705091 Merge pull request #82726 from ZP-AlwaysWin/dev05
fix kubectl run --generator=xxx bug

Kubernetes-commit: 398820e28cee16787a7e015026a0169d150c3120
2019-09-19 04:18:32 +00:00
Kubernetes Publisher ff65a06824 Merge pull request #82644 from ZP-AlwaysWin/dev01
replace 200 with http.StatusOK

Kubernetes-commit: 29d05ae6a9651ed2c01333ecbab05ac71636e619
2019-09-19 04:18:30 +00:00
Kubernetes Publisher e488001164 Merge pull request #82096 from logicalhan/version-deletion
remove pkg/version and some of redundant copies of it

Kubernetes-commit: 67d928acdc351d3d4f9e20a92cee4452a26ed0c4
2019-09-18 04:24:33 +00:00
Kubernetes Publisher b64750ed95 Merge pull request #78197 from dsymonds/master
Fix description of diff flags

Kubernetes-commit: 44e35890f6d3a5ba98da25179f1f6b4e02dacd06
2019-09-17 20:23:07 +00:00
Jan Chaloupka 6fd1ff2fb0 Require exact match when calling Get method within fake clientset
`Get` method within the fake clientset returns an object that would not be normally returned when using the real clientset. Reproducer:

```go
package main

import (
	v1 "k8s.io/api/core/v1"
	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
	"k8s.io/client-go/kubernetes/fake"
)

func main () {
	cm := &v1.ConfigMap{
		ObjectMeta: metav1.ObjectMeta{Namespace: metav1.NamespaceSystem, Name: "cm"},
		}

	client := fake.NewSimpleClientset(cm)
	obj, err := client.CoreV1().ConfigMaps("").Get("", metav1.GetOptions{})
	if err != nil {
		panic(err)
	}
	fmt.Printf("obj: %#v\n", obj)
}
```

stored under `test.go` of `github.com/kubernetes/kubernetes` (master HEAD) root directory and ran:

```sh
$ go run test.go
obj: &v1.ConfigMap{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"cm", GenerateName:"", Namespace:"kube-system", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Finalizers:[]string(nil), ClusterName:"", ManagedFields:[]v1.ManagedFieldsEntry(nil)}, Data:map[string]string(nil), BinaryData:map[string][]uint8(nil)}
```

As you can see fake clientset with a "test" configmap is created. When getting the object through the clientset back, I intentionally set the object name to an empty string. I would expect to get an error saying config map "" was not found. However, I get "test" configmap instead.

Reason for that is inside implementation of `filterByNamespaceAndName` private function:
```go
func filterByNamespaceAndName(objs []runtime.Object, ns, name string) ([]runtime.Object, error) {
	var res []runtime.Object

	for _, obj := range objs {
		acc, err := meta.Accessor(obj)
		if err != nil {
			return nil, err
		}
		if ns != "" && acc.GetNamespace() != ns {
			continue
		}
		if name != "" && acc.GetName() != name {
			continue
		}
		res = append(res, obj)
	}

	return res, nil
}
```

When `name` is empty, `name != "" && acc.GetName() != name` condition is false and thus `obj` is consider as a fit.

[1] https://github.com/kubernetes/client-go/blob/master/testing/fixture.go#L481-L493

Kubernetes-commit: d32c76fc03381784516c47cb1bf62ef932189afa
2019-09-17 17:52:28 +02:00
ZP-AlwaysWin b3895b0e0e fix kubectl run --generator=xxx bug
Kubernetes-commit: 860845b58216fa7fa058bacd06b4be5caefa6251
2019-09-15 14:27:33 +08:00
Kubernetes Publisher 242d795625 Merge pull request #82535 from demobox/patch-1
'imagetag' -> 'image' in edit set command examples

Kubernetes-commit: 1f2e9cfe4eb8949836886e7273e6266756617537
2019-09-13 09:30:47 +00:00
Kubernetes Publisher 985e123003 Merge pull request #82477 from haoshuwei/add-missing-err-return
fix some missing errors return statements

Kubernetes-commit: 5b496d2a25de5bd65512d8c8034f1cbc49e05b4d
2019-09-13 09:30:45 +00:00
Kubernetes Publisher 973ea8de57 Merge pull request #82464 from cwdsuzhou/Sep/add_apigroup_to_datasource
Add apigroup to the data source of pvc description

Kubernetes-commit: bd62a85624d81c2c7e01d5a607ada7a4ce41beda
2019-09-13 09:30:43 +00:00
Kubernetes Publisher 2f2d0f1daa Merge pull request #82442 from sallyom/describe-node-indentation-fix
fix indentation with 'kubectl describe node'

Kubernetes-commit: 3e2d83098efcc18286d0c073d41349a36d3926ba
2019-09-13 09:30:42 +00:00
Kubernetes Publisher d470396f9a Merge pull request #82261 from soltysh/kubecl_security
Update security contacts for kubectl

Kubernetes-commit: fbaf5d2adf50b50b5ae8f3059a91b7e4ac44e9ff
2019-09-13 09:30:39 +00:00
Kubernetes Publisher 2b7ccac730 Merge pull request #80337 from draveness/feature/remove-deprecated-include-uninitialized-flag
feat: remove deprecated include uninitialized flag

Kubernetes-commit: bd6f58cfcbab921d0f9431ae6cc5ad2cc0eb6e2f
2019-09-13 09:30:38 +00:00
Sally O'Malley 6d309ed99e When running `kubectl drain` in dry-run, list warnings and pods that would be deleted.
Kubernetes-commit: 909300b8be909c48a68900c407de03be95555409
2019-09-12 14:31:09 -04:00
ZP-AlwaysWin a376c2df78 replace 200 with http.StatusOK
Kubernetes-commit: cfa77048f9b7fa96bad4eebb059cf60acc9dfd29
2019-09-12 22:35:19 +08:00
ZP-AlwaysWin da06ecc74b Fix bug The statefulset have duplicate revision after resource was updated
Kubernetes-commit: e081d1dca65e738a2541023968251e58b9abf656
2019-09-12 22:26:09 +08:00
Han Kang 010c893f0a remove pkg/version and some of redundant copies of it
Change-Id: Ia58367c1b1274bfb49c8a4784051463abaf795de

Kubernetes-commit: 866ea74326fba45241cbccd3ca4624b68ba7022f
2019-09-10 14:42:55 -07:00
Andrew Phillips 4246a74149 'imagetag' -> 'image' in edit set command examples
'imagetag' is not/no longer supported as a command

Kubernetes-commit: 5a753a834f350d62c2258adfd9983614c8072e88
2019-09-10 10:53:27 -04:00
haoshuwei 4dd9f90e6e fix some missing errors return statements
Signed-off-by: haoshuwei <haoshuwei24@gmail.com>

Kubernetes-commit: c4fe8f11b200d0a97e8ce447e5af592b5c4870d0
2019-09-09 13:54:14 +08:00
caiweidong 521a90f087 add apigroup to the data source when using kubectl describe pvc
Kubernetes-commit: 9157df47e8db6e10edcd398294e6a4c04b3572e9
2019-09-08 15:03:26 +08:00
Sally O'Malley 9555357d5c fix indentation with 'kubectl describe node'
Kubernetes-commit: 4ce16254f7b89324dcbb43de70d0d95cb9ce5865
2019-09-06 16:57:42 -04:00
Mikalai Radchuk a38258b351 Adds --prefix flag to the kubectl log command
Kubernetes-commit: 8cadd185d67e84dd186728669d6e72e9e415db70
2019-09-04 16:23:02 +01:00
Name Surname b21179860f Fix kubectl top sort-by cpu and sort-by memory options
Kubernetes-commit: 824af9e3072d9d68071fec291ac3f5f89362e4ab
2019-09-04 16:28:21 +02:00
Maciej Szulik 84c02e993d Update security contacts for kubectl
Kubernetes-commit: d78b1a22271bca507343af6ccb1f338140ed1e31
2019-09-03 10:15:43 +02:00
Sally O'Malley 56a4f6edaa kubectl: remove usage info from bad flag error msg
Kubernetes-commit: e36dc3adb4045373eefc002e4afe5298ec715ce9
2019-09-01 10:22:13 -04:00
Kubernetes Publisher 3b58a94456 Merge pull request #81929 from egernst/kubectl-overhead
Kubectl: take pod overhead into account for node info

Kubernetes-commit: 3d17fd5c4f6b1ed22499c4db192e1ed6a867d579
2019-08-31 16:30:37 +00:00
Kubernetes Publisher d22f9c0b4f Merge pull request #77354 from jennybuckley/crd-apply
Use CRD validation field in server-side apply

Kubernetes-commit: ab162cd28c332d0ecfb4f918d5f91e9e57acdb61
2019-08-31 08:15:15 +00:00
Kubernetes Publisher a8cbb3d97d Merge pull request #81795 from robscott/endpointslice-kubectl
Adding Kubectl Support for Endpoint Slices

Kubernetes-commit: 0be2f49268cab3154597794c29238f2c362e0d11
2019-08-31 00:23:18 +00:00
Kubernetes Publisher 81c1395df9 Merge pull request #82087 from soltysh/cp_back
Move kubectl cp back to k/k

Kubernetes-commit: 45522ebacab2c5e435411a82a1c6b942a8e47da5
2019-08-30 16:14:02 +00:00
Patrick Ohly 49145d8d0e e2e log: Ginkgo 1.10.1 fixes stack skip
Now Ginkgo properly skips the initial stack entry.

Kubernetes-commit: ecd7ae55bc3ceda761f4405764815f70d38e3b2c
2019-08-30 17:58:48 +02:00
Kubernetes Publisher a0c1347260 Merge pull request #77807 from matthyx/startupProbe
Add startupProbe to health checks

Kubernetes-commit: 3ebe6a6a5fca72759a0482907238221ea3be5c82
2019-08-30 08:10:25 +00:00
Kubernetes Publisher 2385566928 Merge pull request #81956 from apelisse/server-side-apply-beta
Server side apply beta

Kubernetes-commit: 991d71e9fe7da2035e06101f1b47cb8544592335
2019-08-30 04:15:28 +00:00
jennybuckley edbfe8f44f Update generated
Kubernetes-commit: badd5b9a26026138e4fc44a643ec1c6b65a7891b
2019-08-29 19:10:28 -07:00
Kubernetes Publisher bd0a1a2bd5 Merge pull request #78098 from soltysh/remove_logs
Remove kubectl log

Kubernetes-commit: 3cf2d32f871c73c43bd3e477583373735a368976
2019-08-30 00:10:47 +00:00
Kubernetes Publisher 7a7de59651 Merge pull request #82010 from verb/range-kubectl
Update kubectl polymorphic logs helper for ephemeral containers

Kubernetes-commit: bdea3c0181986f5939fd906c9bd19686300d1ea6
2019-08-29 20:10:18 +00:00
Kubernetes Publisher 17121693e2 Merge pull request #79386 from khenidak/phase2-dualstack
Phase 2 dualstack

Kubernetes-commit: 550fb1bfc3c773febbb0811262fd7a8f7847bb20
2019-08-29 04:10:08 +00:00
Kubernetes Publisher fe89aa2ca0 Merge pull request #81958 from apelisse/ssa-improve-conflict-error
Improve error message on server-side apply conflicts

Kubernetes-commit: f0c600d15aed230bfb22926ef5009ff69366e87f
2019-08-29 00:25:41 +00:00
Maciej Szulik b567e802b1 Move kubectl cp back to k/k
Kubernetes-commit: ab1c56ae87780a390bd31d50558e4e44bca551dc
2019-08-28 19:01:25 +02:00
Kubernetes Publisher 59b62c66b6 Merge pull request #81871 from prameshj/vendor-update
Update vendor k8s-cloud-provider and google API

Kubernetes-commit: 91bec13163b18238a8ed3d9b872cd27b1193077d
2019-08-28 12:16:08 +00:00
Olivier Lemasle e7018f8673 kubectl cluster-info dump: use file extension according to output format
Kubernetes-commit: d6fcc224f17f2fe4bb45e731ea3d50a26539fc54
2019-08-28 11:51:39 +02:00
Kubernetes Publisher f8201d2c27 Merge pull request #80847 from verb/debug-kubectl-describe
Print ephemeral containers in kubectl describe

Kubernetes-commit: 178d2eefeed4d165185e9545eb38060ad60a8c2c
2019-08-28 08:09:32 +00:00
Suresh Kumar Ponnusamy 55c8634c3c Support TLS Server Name overrides in kubeconfig file
Signed-off-by: Suresh Kumar Ponnusamy <suresh.ponnusamy@freshworks.com>

Kubernetes-commit: 37c81ed79ac6836bce4b96f888aa407dc18d747c
2019-08-28 10:51:14 +05:30
Kubernetes Publisher 7f664370fd Merge pull request #80644 from verb/debug-kubectl
Allow kubectl to attach to ephemeral containers

Kubernetes-commit: 586d200e35163d441cd4d6411a957a47f4c0b895
2019-08-28 00:09:18 +00:00
Patrick Ohly 2188ba2d83 e2e log: fix full stacktrace with Ginkgo 1.10.0
Ginkgo 1.10.0 includes the relevant fix for dumping the full stack
(https://github.com/onsi/ginkgo/pull/590), so when using that release
we can simplify the logging unit test.

By changing the skipping, we can avoid the rather volatile util.go
entries. However, that gomega is part of the stack trace still needs
to be fixed in Gingko.

Kubernetes-commit: 02ce619078b1a75e9fa258e101f81af899719e8e
2019-08-27 14:22:46 +02:00
Lee Verberne c5bce989ce Update kubectl polymorphic logs helper for ephemeral containers
This also updates the test to check there were actual actions that
weren't expected.

Kubernetes-commit: 66d077882854bc407f27a4ecd47deb157fe7a47d
2019-08-27 09:35:16 +00:00
Kubernetes Publisher 4a0675f1f2 Merge pull request #81342 from knight42/fix/kubectl-patch-scale
Refactor `kubectl scale` to patch scale subresource

Kubernetes-commit: f81ab5a9fca3212386fd1eb0fb40950f40f55a33
2019-08-26 20:09:31 +00:00