When it initially landed in kubernetes/kubernetes@c6e9ad066e (Initial
node drain implementation for #3885, 2015-08-30,
kubernetes/kubernetes#16698), the drain logic looked in a created-by
annotation for recognized kinds [1], so listing the set of recognized
kinds was a clear approach.
Sometime later, the source moved into ownerReferences, but the
hard-coded set of recognized controller kinds remained.
When kubernetes/kubernetes@2f1108451f (Remove hard-coded
pod-controller check, 2017-12-05, kubernetes/kubernetes#56864) removed
the hard-coded set of recognized controller kinds, it should have also
updated these messages to remove stale references to the previous
hard-coded values. This commit catches the message strings up with
that commit.
[1]:
|
||
---|---|---|
.github | ||
docs | ||
images | ||
pkg | ||
testdata | ||
CONTRIBUTING.md | ||
LICENSE | ||
OWNERS | ||
README.md | ||
SECURITY_CONTACTS | ||
code-of-conduct.md | ||
doc.go | ||
go.mod | ||
go.sum |
README.md
Kubectl
The k8s.io/kubectl
repo is used to track issues for the kubectl cli distributed
with k8s.io/kubernetes
. It also contains packages intended for use by client
programs. E.g. these packages are vendored into k8s.io/kubernetes
for use in
the kubectl
cli client. That client will eventually move here too.
Contribution Requirements
-
Full unit-test coverage.
-
Go tools compliant (
go get
,go test
, etc.). It needs to be vendorable somewhere else. -
No dependence on
k8s.io/kubernetes
. Dependence on other repositories is fine. -
Code must be usefully commented. Not only for developers on the project, but also for external users of these packages.
-
When reviewing PRs, you are encouraged to use Golang's code review comments page.
-
Packages in this repository should aspire to implement sensible, small interfaces and import a limited set of dependencies.
Community, discussion, contribution, and support
See this document for how to reach the maintainers of this project.
Code of conduct
Participation in the Kubernetes community is governed by the Kubernetes Code of Conduct.