7c4cfc5d12
Some of these changes are cosmetic (repeatedly calling klog.V instead of
reusing the result), others address real issues:
- Logging a message only above a certain verbosity threshold without
recording that verbosity level (if klog.V().Enabled() { klog.Info... }):
this matters when using a logging backend which records the verbosity
level.
- Passing a format string with parameters to a logging function that
doesn't do string formatting.
All of these locations where found by the enhanced logcheck tool from
https://github.com/kubernetes/klog/pull/297.
In some cases it reports false positives, but those can be suppressed with
source code comments.
Kubernetes-commit: edffc700a43e610f641907290a5152ca593bad79
|
||
|---|---|---|
| .. | ||
| editor | ||
| podcmd | ||
| sanity | ||
| env_file.go | ||
| env_file_test.go | ||
| factory.go | ||
| factory_client_access.go | ||
| helpers.go | ||
| helpers_test.go | ||
| kubectl_match_version.go | ||
| override_options.go | ||
| printing.go | ||