The behavior of the container defaulting in attach/exec is inconsistent and should be unified. As a user, when we default the vast majority of pods will have a small number of containers and so printing the container names inline (as kubectl logs did) is more appropriate. The debug message we printed about using describe was already longer than 99% of all pod container names, so we were wasting user time. Unify container selection for exec and attach to be consistent with old behavior. Properly handle the --quiet flag (should not print in that case) for both commands. Remove EnableCmdSuggestion and the machinery it needs. The message now prints: > Defaulted container "etcdctl" out of: etcdctl, etcd, etcd-metrics, etcd-ensure-env-vars (init), etcd-resources-copy (init) Kubernetes-commit: 43e8ebbbcd3f57d18d8151efb6242f88a763b06d |
||
|---|---|---|
| .. | ||
| exec.go | ||
| exec_test.go | ||