From 6c096e499943c9a36e317454397c1e88d6cd2d62 Mon Sep 17 00:00:00 2001 From: Aravindh Puthiyaparambil Date: Tue, 6 Aug 2024 15:46:15 -0700 Subject: [PATCH] kubelet: use env vars in node log query PS command - Use environment variables to pass string arguments in the node log query PS command - Split getLoggingCmd into getLoggingCmdEnv and getLoggingCmdArgs for better modularization Kubernetes-commit: c94919d68b96ac54171fd289f9a2da25a5fbcd5e --- config/v1beta1/types.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config/v1beta1/types.go b/config/v1beta1/types.go index 1f7bbc9..ea7d826 100644 --- a/config/v1beta1/types.go +++ b/config/v1beta1/types.go @@ -720,6 +720,8 @@ type KubeletConfiguration struct { EnableSystemLogHandler *bool `json:"enableSystemLogHandler,omitempty"` // enableSystemLogQuery enables the node log query feature on the /logs endpoint. // EnableSystemLogHandler has to be enabled in addition for this feature to work. + // Enabling this feature has security implications. The recommendation is to enable it on a need basis for debugging + // purposes and disabling otherwise. // Default: false // +featureGate=NodeLogQuery // +optional