From 89ecb8cfb63b156ec5df6150b443383e6af71535 Mon Sep 17 00:00:00 2001 From: Qiming Teng Date: Thu, 31 Dec 2020 11:46:33 +0800 Subject: [PATCH 1/2] Fix feature gate for hugepage The text says "disable" because the gate is in Beta, but the example says "enable". That is awkward. --- content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md b/content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md index 36b92ac18a..c3e43127a9 100644 --- a/content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md +++ b/content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md @@ -117,4 +117,4 @@ token. gate](/docs/reference/command-line-tools-reference/feature-gates/) on the {{< glossary_tooltip text="kubelet" term_id="kubelet" >}} and {{< glossary_tooltip text="kube-apiserver" -term_id="kube-apiserver" >}} (`--feature-gates=HugePageStorageMediumSize=true`). +term_id="kube-apiserver" >}} (`--feature-gates=HugePageStorageMediumSize=false`). From ad59de018dd1212c0bddfa3b8690747898dda2a9 Mon Sep 17 00:00:00 2001 From: Qiming Teng Date: Thu, 31 Dec 2020 11:47:58 +0800 Subject: [PATCH 2/2] Wrap lines properly --- .../manage-hugepages/scheduling-hugepages.md | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md b/content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md index c3e43127a9..8d4cd4afe6 100644 --- a/content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md +++ b/content/en/docs/tasks/manage-hugepages/scheduling-hugepages.md @@ -104,17 +104,19 @@ spec: - Huge page requests must equal the limits. This is the default if limits are specified, but requests are not. -- Huge pages are isolated at a container scope, so each container has own limit on their cgroup sandbox as requested in a container spec. +- Huge pages are isolated at a container scope, so each container has own + limit on their cgroup sandbox as requested in a container spec. - EmptyDir volumes backed by huge pages may not consume more huge page memory than the pod request. - Applications that consume huge pages via `shmget()` with `SHM_HUGETLB` must run with a supplemental group that matches `proc/sys/vm/hugetlb_shm_group`. - Huge page usage in a namespace is controllable via ResourceQuota similar -to other compute resources like `cpu` or `memory` using the `hugepages-` -token. + to other compute resources like `cpu` or `memory` using the `hugepages-` + token. - Support of multiple sizes huge pages is feature gated. It can be - disabled with the `HugePageStorageMediumSize` [feature -gate](/docs/reference/command-line-tools-reference/feature-gates/) on the {{< -glossary_tooltip text="kubelet" term_id="kubelet" >}} and {{< -glossary_tooltip text="kube-apiserver" -term_id="kube-apiserver" >}} (`--feature-gates=HugePageStorageMediumSize=false`). + disabled with the `HugePageStorageMediumSize` + [feature gate](/docs/reference/command-line-tools-reference/feature-gates/) + on the {{< glossary_tooltip text="kubelet" term_id="kubelet" >}} and + {{< glossary_tooltip text="kube-apiserver" term_id="kube-apiserver" >}} + (`--feature-gates=HugePageStorageMediumSize=false`). +