From 41a0deb35a5cae1b04e8e786c509ab93cdaead91 Mon Sep 17 00:00:00 2001 From: Kurt Hurtado Date: Tue, 9 Jan 2024 15:43:38 -0600 Subject: [PATCH 1/2] clarify nodes only update labels upon registration --- content/en/docs/concepts/architecture/nodes.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/content/en/docs/concepts/architecture/nodes.md b/content/en/docs/concepts/architecture/nodes.md index 6473d35a17..ad3dbf96d7 100644 --- a/content/en/docs/concepts/architecture/nodes.md +++ b/content/en/docs/concepts/architecture/nodes.md @@ -115,9 +115,9 @@ are enabled, kubelets are only authorized to create/modify their own Node resour {{< note >}} As mentioned in the [Node name uniqueness](#node-name-uniqueness) section, when Node configuration needs to be updated, it is a good practice to re-register -the node with the API server. For example, if the kubelet being restarted with -the new set of `--node-labels`, but the same Node name is used, the change will -not take an effect, as labels are being set on the Node registration. +the node with the API server. For example, if the kubelet is being restarted with +a new set of `--node-labels`, but the same Node name is used, the change will +not take effect, as labels are only set (or reset) upon Node registration with the API server. Pods already scheduled on the Node may misbehave or cause issues if the Node configuration will be changed on kubelet restart. For example, already running From a31db32c8647ab970afc320674a0832881728f36 Mon Sep 17 00:00:00 2001 From: Kurt Hurtado Date: Fri, 8 Mar 2024 15:49:57 -0600 Subject: [PATCH 2/2] reworded reset to modified --- content/en/docs/concepts/architecture/nodes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en/docs/concepts/architecture/nodes.md b/content/en/docs/concepts/architecture/nodes.md index ad3dbf96d7..5d3fba6eb2 100644 --- a/content/en/docs/concepts/architecture/nodes.md +++ b/content/en/docs/concepts/architecture/nodes.md @@ -117,7 +117,7 @@ As mentioned in the [Node name uniqueness](#node-name-uniqueness) section, when Node configuration needs to be updated, it is a good practice to re-register the node with the API server. For example, if the kubelet is being restarted with a new set of `--node-labels`, but the same Node name is used, the change will -not take effect, as labels are only set (or reset) upon Node registration with the API server. +not take effect, as labels are only set (or modified) upon Node registration with the API server. Pods already scheduled on the Node may misbehave or cause issues if the Node configuration will be changed on kubelet restart. For example, already running