From 96e4198127838c9d594667f53b9a7cff40b6a2f6 Mon Sep 17 00:00:00 2001 From: yongruilin Date: Thu, 10 Oct 2024 15:45:47 -0700 Subject: [PATCH] Fix: use correct metric allow list manifest format According to https://github.com/kubernetes/kubernetes/blob/c15581b277e9e42d830898357fdbd92dcf7981c6/staging/src/k8s.io/component-base/metrics/opts.go#L365 , the manifest content should be a map. --- .../docs/concepts/cluster-administration/system-metrics.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/content/en/docs/concepts/cluster-administration/system-metrics.md b/content/en/docs/concepts/cluster-administration/system-metrics.md index 747b36600c..47433e7b2d 100644 --- a/content/en/docs/concepts/cluster-administration/system-metrics.md +++ b/content/en/docs/concepts/cluster-administration/system-metrics.md @@ -183,7 +183,7 @@ disabled metrics (i.e. `--disabled-metrics=metric1,metric2`). ## Metric cardinality enforcement Metrics with unbounded dimensions could cause memory issues in the components they instrument. To -limit resource use, you can use the `--allow-label-value` command line option to dynamically +limit resource use, you can use the `--allow-metric-labels` command line option to dynamically configure an allow-list of label values for a metric. In alpha stage, the flag can only take in a series of mappings as metric label allow-list. @@ -207,9 +207,8 @@ can specify the path to that configuration file using the `--allow-metric-labels line argument to a component. Here's an example of the contents of that configuration file: ```yaml -allow-list: -- "metric1,label2": "v1,v2,v3" -- "metric2,label1": "v1,v2,v3" +"metric1,label2": "v1,v2,v3" +"metric2,label1": "v1,v2,v3" ``` Additionally, the `cardinality_enforcement_unexpected_categorizations_total` meta-metric records the