Apply suggestions from code review

Co-authored-by: Mark Rossetti <marosset@microsoft.com>
Co-authored-by: Qiming Teng <tengqm@outlook.com>
Co-authored-by: Aravindh Puthiyaparambil <aravindhp@users.noreply.github.com>
This commit is contained in:
James Sturtevant 2024-11-19 14:05:38 -08:00 committed by GitHub
parent e2cccab126
commit ce1491d47e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 20 additions and 15 deletions

View File

@ -12,4 +12,7 @@ stages:
defaultValue: false
fromVersion: "1.32"
---
Add CPU and Memory Affinity support to Windows nodes with [CPUManager](/docs/tasks/administer-cluster/cpu-management-policies#windows-support), [MemoryManager](/docs/tasks/administer-cluster/memory-manager.md#windows-support) and Topology manager.
Add CPU and Memory Affinity support to Windows nodes with [CPUManager](/docs/tasks/administer-cluster/cpu-management-policies/#windows-support),
[MemoryManager](/docs/tasks/administer-cluster/memory-manager/#windows-support)
and topology manager.

View File

@ -51,10 +51,10 @@ management policies to determine some placement preferences on the node.
## Windows Support
{{< feature-state for_k8s_version="v1.32" state="alpha" feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
{{< feature-state feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
The CPU Manager support can be enabled on Windows by using the `WindowsCPUAndMemoryAffinity` feature flag and requires a support in the container runtime.
Once feature is enabled follow the steps above to configure the [CPU Manager Policy](#configuration).
The CPU Manager support can be enabled on Windows by using the `WindowsCPUAndMemoryAffinity` feature gate and requires a support in the container runtime.
Once the feature gate is enabled, follow the steps below to configure the [CPU manager policy](#configuration).
### Configuration

View File

@ -46,7 +46,7 @@ Preceding v1.22, the `kubelet` must be started with the following flag:
in order to enable the Memory Manager feature.
## How does the Memory Manager Operates?
## How does the Memory Manager Operate?
The Memory Manager currently offers the guaranteed memory (and hugepages) allocation
for Pods in Guaranteed QoS class.
@ -93,9 +93,10 @@ illustrates how the management of groups occurs.
### Windows Support
{{< feature-state for_k8s_version="v1.32" state="alpha" feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
{{< feature-state feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
Windows support can be enabled via the `WindowsCPUAndMemoryAffinity` feature gate and requires a support in the container runtime. Only the [BestEffort Policy](#policy-best-effort) is supported on Windows.
Windows support can be enabled via the `WindowsCPUAndMemoryAffinity` feature gate and requires a support in the container runtime.
Only the [BestEffort Policy](#policy-best-effort) is supported on Windows.
## Memory Manager configuration
@ -130,17 +131,17 @@ In the case of the `BestEffort` or `Burstable` pod, the `Static` Memory Manager
the default topology hint as there is no request for the guaranteed memory,
and does not reserve the memory in the internal [NodeMap][2] object.
This policy is only Supported on Linux.
This policy is only supported on Linux.
#### BestEffort policy {#policy-best-effort}
{{< feature-state for_k8s_version="v1.32" state="alpha" feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
{{< feature-state feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
This policy is only Support on Windows.
This policy is only supported on Windows.
On Windows, NUMA node assignment works differently than Linux. There is no mechanism
to ensure that Memory access only comes from a specific NUMA node, instead the Windows
internals will select the most optimal NUMA node based on the CPU assignment and it is
On Windows, NUMA node assignment works differently from Linux. There is no mechanism
to ensure that memory access only comes from a specific NUMA node, instead the Windows
scheduler will select the most optimal NUMA node based on the CPU assignments and it is
possible that Windows might use other nodes if required or deemed optimal. For this
reason this policy is best effort.

View File

@ -60,9 +60,10 @@ resource allocation decisions.
## Windows Support
{{< feature-state for_k8s_version="v1.32" state="alpha" feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
{{< feature-state feature_gate_name="WindowsCPUAndMemoryAffinity" >}}
The Topology Manager support can be enabled on Windows by using the `WindowsCPUAndMemoryAffinity` feature flag and requires a support in the container runtime.
The Topology Manager support can be enabled on Windows by using the `WindowsCPUAndMemoryAffinity` feature gate and
it requires a support in the container runtime.
## Topology manager scopes and policies