From ddfa877602152db51aeabb626d2e2d1cc168d065 Mon Sep 17 00:00:00 2001 From: Fuxing Loh Date: Sat, 25 Apr 2020 09:26:26 +0800 Subject: [PATCH] Add missing default value to Progress Deadline Seconds Potentially confusing sentence, being an optional value; not stating the default value might create an assumption that deployment will retry forever. https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.18/#deploymentspec-v1-apps --- content/en/docs/concepts/workloads/controllers/deployment.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/en/docs/concepts/workloads/controllers/deployment.md b/content/en/docs/concepts/workloads/controllers/deployment.md index 2c9af465a6..1fd6c5c9d6 100644 --- a/content/en/docs/concepts/workloads/controllers/deployment.md +++ b/content/en/docs/concepts/workloads/controllers/deployment.md @@ -1117,7 +1117,7 @@ total number of Pods running at any time during the update is at most 130% of de to wait for your Deployment to progress before the system reports back that the Deployment has [failed progressing](#failed-deployment) - surfaced as a condition with `Type=Progressing`, `Status=False`. and `Reason=ProgressDeadlineExceeded` in the status of the resource. The Deployment controller will keep -retrying the Deployment. In the future, once automatic rollback will be implemented, the Deployment +retrying the Deployment. This defaults to 600. In the future, once automatic rollback will be implemented, the Deployment controller will roll back a Deployment as soon as it observes such a condition. If specified, this field needs to be greater than `.spec.minReadySeconds`.