BG
541e89228c
[StorageClasses] Add gp3 to available ebs volume types
2022-02-14 11:38:44 +01:00
Kubernetes Prow Robot
068d86d793
Merge pull request #31608 from atoato88/update-job-ttl-mechanism-to-stable
...
Update TTL mechanism in Job to stable feature state
2022-02-12 20:51:48 -08:00
Kubernetes Prow Robot
c3c3b1a7ac
Merge pull request #31283 from denkensk/graduate-nonpreemptingpriority-to-ga
...
Graduate NonPreemptingPriority to GA
2022-02-11 17:29:47 -08:00
chrismetz09
10e7039a69
update resource metrics pipeline section
2022-02-11 07:09:01 -08:00
Shivam Singhal
d722e64d1d
Fix link of XFS project quotas in manage-resources-containers
2022-02-11 15:47:38 +02:00
Kubernetes Prow Robot
0211d7f7c9
Merge pull request #31622 from meysam81/meysam/fix-prepositions
...
fix: modify prepositions 📝
2022-02-09 18:25:47 -08:00
Frank Villaro-Dixon
c0387a8b76
operator: add `Kopf` framework to list of libraries
...
`Kopf` is a python operator framework that is also well known and used.
2022-02-09 14:54:53 +01:00
Kubernetes Prow Robot
6b6c7a2df8
Merge pull request #31506 from alexfornuto/patch-1
...
Add Pomerium Ingress Controller to list.
2022-02-08 18:50:17 -08:00
nwanati
df993e1261
Update logging.md ( #31286 )
...
* Update logging.md
Updated some sentences for clarity.
* Update content/en/docs/concepts/cluster-administration/logging.md
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: Tim Bannister <tim@scalefactory.com>
2022-02-08 07:56:54 -08:00
Kubernetes Prow Robot
ec8ea88c33
Merge pull request #31545 from chrisnegus/dockershim-hook-handlers
...
Updated Debugging Hook handlers example to remove docker reference
2022-02-08 07:12:54 -08:00
Nate W
f9dda7bc96
Merge remote-tracking branch 'upstream/main' into dev-1.24
2022-02-07 11:03:19 -08:00
John Kwiatkoski
0d9d83a23d
Remove deprecated `--record` flag from example
...
Trying to use this flag `--record` in the example leads to the warning:
```
Flag --record has been deprecated, --record will be removed in the future
```
2022-02-05 19:41:02 -05:00
Qiming Teng
459a3f96ac
Fix links and markdown format for some pages
2022-02-05 15:19:21 +08:00
Meysam Azad
228c676cd1
fix: modify prepositions 📝
2022-02-04 16:48:20 +03:00
alexfornuto
df38c30bb3
Add Pomerium Ingress Controller to list.
2022-02-03 09:31:32 -06:00
Kubernetes Prow Robot
2d6d22ddec
Merge pull request #31440 from MikeSpreitzer/note-apf-autoupdate
...
Catch APF description up with recent developments
2022-02-03 03:05:45 -08:00
Akihito INOH
f1310cab68
Update TTL mechanism in Job to stable
...
This commit update feature stage for TTL mechanism in Job with stable.
TTL mechanism has been GA from k8s v1.23, so we can update "beta" to "stable".
2022-02-03 08:10:47 +09:00
Paul "TBBle" Hampson
db2b66e365
Apply wording improvements to load-balancer-class
...
Credit to Tim Bannister <tim@scalefactory.com> for the same improvements
in load-balancer-nodeport-allocation above.
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
2022-02-03 02:40:00 +11:00
Paul "TBBle" Hampson
2103a16c0f
Fix style nit-pick
...
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
2022-02-03 02:39:49 +11:00
Paul "TBBle" Hampson
be07879592
Remove needless mention of previous versions
...
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
2022-02-03 02:39:43 +11:00
Paul "TBBle" Hampson
b54cee1c44
Apply better wording to remain current in future versions
...
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
2022-02-03 02:39:24 +11:00
Paul "TBBle" Hampson
f0da3cf753
`ServiceLBNodePortControl` went to beta in v1.22
...
Looks like this was overlooked to be updated when the feature gate documentation was updated in #28770 .
Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
2022-02-03 00:49:06 +11:00
Kubernetes Prow Robot
c468037747
Merge pull request #31331 from yashodhanmohan/feat/docker-cleanup
...
Clean up docker references from Service documentations
2022-02-01 07:21:12 -08:00
Kubernetes Prow Robot
26d565c5c5
Merge pull request #31315 from utkarsh-singh1/edit-managed-resource-containers
...
Updated managed-resource-containers.md
2022-01-31 17:53:52 -08:00
Kubernetes Prow Robot
e909d003a5
Merge pull request #31359 from meysam81/meysam/grammatical-error
...
docs: modify grammatical error ✏️
2022-01-31 17:45:52 -08:00
Md Sahil
c4dc68c8ff
Update service-traffic-policy.md ( #31408 )
...
* Update service-traffic-policy.md
<h3>What this PR does ?</h3>
Improve documentation.
<h3>Which issue this PR fixes ?</h3>
fixes 31403(Issue).
* Update service-traffic-policy.md
* Update service-traffic-policy.md
* Update service-traffic-policy.md
2022-01-31 17:37:53 -08:00
Kubernetes Prow Robot
1f3152031f
Merge pull request #31556 from anubha-v-ardhan/30952
...
Dockershim removal from concepts/containers/container-environment
2022-01-31 16:55:52 -08:00
Nate W
2fa88c51b6
Merge remote-tracking branch 'upstream/main' into dev-1.24
2022-01-31 11:57:45 -08:00
Kubernetes Prow Robot
d996c9ed4e
Merge pull request #31566 from amej/patch-1
...
Updates url to point to the glossary
2022-01-30 15:08:23 -08:00
Kubernetes Prow Robot
6712fbee60
Merge pull request #31542 from yashodhanmohan/fix/capitalization
...
Update capitalization for mount options based on correct PV types
2022-01-30 14:34:24 -08:00
Ameya Sathe
b19b9da1b6
Replaces with relative uri
...
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
2022-01-30 22:14:41 +05:30
Ameya Sathe
8c7c94d578
Updates url to point to the glossary
...
Substitutes the existing url to archived documentation of "Kubernetes Resource" with URL pointing to glossary .
Fixes the https://github.com/kubernetes/website/issues/31396
2022-01-30 16:16:58 +05:30
Anubhav Vardhan
0dca4ef984
Dockershim removal from container-environment
2022-01-29 13:01:10 +05:30
Yashodhan Mohan Bhatnagar
cd7114d66e
Update capitalization for mount options based on correct PV types
2022-01-28 13:37:36 +05:30
Kubernetes Prow Robot
d3a4f2e23f
Merge pull request #31486 from liggitt/pss
...
Pod Security Standards doc updates
2022-01-27 16:16:45 -08:00
Christopher Negus
ccd2fd216e
Updated Debugging Hook handlers example to remove docker reference.
2022-01-27 21:30:03 +00:00
Kubernetes Prow Robot
f1b4131deb
Merge pull request #31538 from mbongard/patch-1
...
Fixed malformed sentence
2022-01-27 04:56:25 -08:00
Kubernetes Prow Robot
023db16622
Merge pull request #31518 from mtardy/main
...
Add warning for creating namespaces with the same name as public TLDs
2022-01-27 04:48:26 -08:00
Kubernetes Prow Robot
c93f0966c4
Merge pull request #31226 from atiratree/concepts.deployment
...
make deployment status behaviour more descriptive
2022-01-27 04:30:26 -08:00
Michel Bongard
8ea2fb38ed
Update logging.md
2022-01-27 12:37:35 +01:00
mtardy
61174c49ba
Add warning for creating namespaces with the same name as public TLDs
...
Uppercase Service API object following documentation style guide
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Add mitigation propositions
Add RFC reference for the trailing dot in an absolute DNS name
Co-authored-by: Shannon Kularathna <ax3shannonkularathna@gmail.com>
2022-01-27 10:58:41 +01:00
Alex Wang
665f51e60a
graduate nonpreemptingpriority to ga
2022-01-27 11:51:01 +08:00
SpecialYang
9911912709
Fix imprecise statements for virtual hosting example
2022-01-26 22:33:33 +08:00
Saswata Ghosh
df266cdaaa
Removed the dockershim section
2022-01-26 18:26:20 +05:30
Kubernetes Prow Robot
8b34063fba
Merge pull request #30961 from ystkfujii/v1.24_remove_section_on_dockershim
...
Set the dockershim state to deprecation.
2022-01-25 22:46:26 -08:00
William Denniss
20ee91f0da
Include link to Pod Security Admission in the PodSecurityPolicy deprecation notice ( #31475 )
...
* Include link to Pod Security Admission in the PodSecurityPolicy deprecation notice
Add a link to the Pod Security Admission feature, which replaces PodSecurityPolicy. Currently users who read this page may not realize what the replacement is. The linked blog post talks about the KEP that created Pod Security Admission, but with no direct link.
* Remove link prefix
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
Co-authored-by: Jihoon Seo <46767780+jihoon-seo@users.noreply.github.com>
2022-01-25 16:28:26 -08:00
Kubernetes Prow Robot
ee346e48d8
Merge pull request #31363 from yashodhanmohan/fix/pod-dns
...
Correcting DNS record for pods exposed by a Service
2022-01-25 12:21:41 -08:00
Kubernetes Prow Robot
7cb748a933
Merge pull request #31308 from meysam81/meysam/annotation-between-backticks
...
docs: place annotation between backticks ✏️
2022-01-25 08:50:31 -08:00
Wang
88fbaa1160
Update projected-volumes.md
2022-01-25 18:47:48 +09:00
Wang
e08d312a6d
Update projected-volumes.md
2022-01-25 17:46:30 +09:00
Kubernetes Prow Robot
1d552afaa6
Merge pull request #30737 from mfbieber/ingress-class-name-in-example
...
Added ingressClassName: nginx to Ingress example
2022-01-24 11:37:35 -08:00
Kubernetes Prow Robot
d81bc93d81
Merge pull request #31327 from adrianludwin/patch-3
...
Clarify that namespace names must be RFC 1123 DNS labels
2022-01-24 11:35:33 -08:00
Nate W
6fb319b29c
Merge remote-tracking branch 'upstream/main' into dev-1.24
2022-01-24 09:07:23 -08:00
Jordan Liggitt
4ca5ff6b3c
PodSecurity: remove optional non-root group check
2022-01-24 10:10:12 -05:00
Jordan Liggitt
8917b26250
PodSecurity: switch restricted volume check to positive check
2022-01-24 10:09:00 -05:00
Kubernetes Prow Robot
3aea799ca5
Merge pull request #31231 from sftim/20220106_add_contiv_vpp
...
Add Contiv-VPP network plugin
2022-01-23 18:31:57 -08:00
Yashodhan Mohan Bhatnagar
12653d2266
Update to bring back mention of container links compatibility
2022-01-24 01:56:44 +05:30
Yashodhan Mohan Bhatnagar
36336334c3
Update content/en/docs/concepts/services-networking/connect-applications-service.md
...
Co-authored-by: Tim Bannister <tim@scalefactory.com>
2022-01-24 01:23:29 +05:30
Kubernetes Prow Robot
14b5ac97c4
Merge pull request #31446 from championshuttler/ln
...
Update URLs for some network plugins
2022-01-22 05:41:52 -08:00
Mike Spreitzer
2bfc31833f
Catch APF description up with recent developments
...
Primarily the change, in release 1.22, of how configuration objects
are maintained.
Also describe the new priority level.
Also move the sections on defaults and health check configuration to
follow the description of configuration objects.
2022-01-21 13:06:51 -05:00
Kubernetes Prow Robot
da262be43e
Merge pull request #31282 from shannonxtreme/dockershim-clusteradmin
...
Action on Docker mentions in Concepts > Cluster Administration
2022-01-21 07:41:59 -08:00
Shannon Kularathna
4650e1df61
Refactor Assign Pods to Nodes
2022-01-21 15:27:20 +00:00
Shivam Singhal
d677a0eed5
Update URLs for some network plugins
2022-01-21 13:02:32 +02:00
Simas Butavičius
d6ca144def
Fix: typo in cloud-controller.md
...
The cloud-controller-manager is a Kubernetes control plane component" according to docs. That is, a singular manager. This PR fixes typo in docs where it was referenced to as "cloud controller managers".
2022-01-19 16:03:41 +02:00
Kubernetes Prow Robot
b599a32374
Merge pull request #30959 from bglimepoint/patch-1
...
Note that subPathExpr uses round brackets.
2022-01-17 15:32:49 -08:00
Kubernetes Prow Robot
c7079c4ee1
Merge pull request #31349 from humblec/csiMigration
...
mention the correct feature gate name for RBD CSI migration.
2022-01-17 12:46:49 -08:00
Nate W
015825f608
Merge remote-tracking branch 'upstream/main' into dev-1.24
2022-01-17 09:46:19 -08:00
Yashodhan Mohan Bhatnagar
3a6fa8fea2
Correcting DNS record for pods exposed by a Service
...
For pods, DNS record incorrectly specifies deployment name
instead of service name. This commit corrects that.
2022-01-17 01:39:01 +05:30
Meysam Azad
7a3732e0d0
docs: modify grammatical error ✏️
2022-01-16 19:49:51 +03:00
Meysam Azad
60551bc338
typo: remove redundant preposition ✏️
2022-01-15 13:26:50 +03:00
Humble Chirammal
9abefaba6b
mention the correct feature gate name for RBD CSI migration.
...
The feature gate string (CSIMigrationRBD) was not matching with the
implementation (csiMigrationRBD) and this commit make it in parity
Ref# https://github.com/kubernetes/kubernetes/pull/107571
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2022-01-15 09:24:54 +05:30
GuyTempleton
80e2f669a0
Docs - EN - Concepts - Correct Pod-Conditions Anchor Link
2022-01-14 10:30:44 +00:00
Yashodhan Mohan Bhatnagar
a18a34c482
Clean up docker references from Service documentations
...
1. Remove examples contrasting k8s networking with Docker networking
from concept document explaining connecting applications using services
2. Remove reference to dockerlinks in favor of English description
of the env vars autocreated for every Service.
2022-01-14 02:39:33 +05:30
Adrian Ludwin
9117178a97
Namespace names must be RFC 1123 DNS labels
...
The how-to docs to create a new namespace already specify this, but I think it's worth mentioning in the overview doc that a namespace name must be an RFC 1123 label, as I didn't initially think to look in the how-to doc for limitations.
2022-01-13 12:10:06 -05:00
d3vus
42e88a361c
Updated managed-resource-containers.md
2022-01-13 13:05:17 +05:30
Meysam Azad
1c4ea6d5af
docs: place annotation between backticks ✏️
2022-01-12 19:25:27 +03:00
Kubernetes Prow Robot
b42674e881
Merge pull request #31289 from ixodie/patch-5
...
Removing Romana
2022-01-12 05:30:37 -08:00
Kubernetes Prow Robot
976f23445e
Merge pull request #31281 from anubha-v-ardhan/glossary-toolstip-statefulset
...
Add glossary_tooltip for StatefulSet in Recommended labels
2022-01-12 03:54:37 -08:00
Kubernetes Prow Robot
98d8836c23
Merge pull request #31267 from mengjiao-liu/fix-PreemptionPolicy
...
Fix wrong capitalization for preemptionPolicy field
2022-01-11 11:13:15 -08:00
ixodie
c073285fb3
Removing Romana
...
Romana is defunct and has been removed from main networking docs already.
2022-01-11 10:53:58 -05:00
Kubernetes Prow Robot
d159608a62
Merge pull request #31284 from Babapool/add-tooltip
...
Add Glossary_tooltip for object
2022-01-11 01:15:16 -08:00
Vitthal Sai
b930314a64
Add glossary_tooltip for object
2022-01-11 14:24:09 +05:30
Shannon Kularathna
be490005ff
Remove Docker mentions
2022-01-11 07:07:22 +00:00
Anubhav Vardhan
5a5b4d8a70
Comment YAML to specify excerpt
2022-01-11 10:33:07 +05:30
Anubhav Vardhan
f6ae550af4
Add glossary_tooltip for StatefulSet
2022-01-11 10:26:58 +05:30
Kubernetes Prow Robot
0872e8ec51
Merge pull request #30818 from sftim/20211007_revise_device_plugins_page
...
Revise device plugins page
2022-01-10 14:42:26 -08:00
Filip Křepinský
8f8d2bb039
make deployment status behaviour more descriptive
2022-01-10 21:22:45 +01:00
Mengjiao Liu
a35da2ba7f
Fix wrong capitalization for preemptionPolicy field
2022-01-10 17:59:22 +08:00
Sascha Grunert
36a5a39a35
Update CRI description to be more verbose
...
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2022-01-10 10:38:15 +01:00
Kubernetes Prow Robot
5446a4f7ed
Merge pull request #31219 from pacoxu/patch-9
...
storage class parameters value should be string
2022-01-08 06:30:18 -08:00
Kubernetes Prow Robot
c4b4768ae0
Merge pull request #31145 from hhyasdf/introduce-hybridnet
...
Add Hybridnet CNI to networking.md
2022-01-08 06:26:19 -08:00
Michelle Fernandez Bieber
e21f0563f3
Added ingressClassName: nginx to Ingress example, mentioned to the necessity of it and referenced to the section describing that further
2022-01-07 22:15:42 +01:00
Tim Bannister
a3e8980eac
Add Contiv-VPP network plugin
2022-01-06 22:24:08 +00:00
Kubernetes Prow Robot
4763cd9329
Merge pull request #30759 from ixodie/patch-12
...
Kind cleanup - Remove Contiv
2022-01-06 14:22:00 -08:00
Nate W
f8847c0308
Merge remote-tracking branch 'upstream/main' into dev-1.24
2022-01-06 10:16:34 -08:00
Paco Xu
d51b32bab8
storage class parameters value should be string
2022-01-06 11:24:06 +08:00
Tim Bannister
2558306e58
Add third-party content disclaimer
2022-01-05 21:44:49 +00:00
Tim Bannister
d67ac4dc95
Fix mismatched whitespace
...
Convert a tab to spaces to match other lines in snippet.
2022-01-05 21:44:48 +00:00
Tim Bannister
fea1dc2801
Clean up front matter
2022-01-05 21:44:48 +00:00
Tim Bannister
7715646907
Tweak wording for Device Plugins concept
2022-01-05 21:44:44 +00:00
Neha Viswanathan
24ee2527d0
migrate the K8s networking model section ( #28617 )
2022-01-05 08:08:41 -08:00
Kubernetes Prow Robot
c39b834244
Merge pull request #30431 from Kartik494/improveDocsCRD
...
Added a note for CRD improvement in Docs
2022-01-04 12:14:08 -08:00
hhyasdf
1d56098e9a
Add Hybridnet CNI to networking.md
2022-01-04 10:34:57 +08:00
Kubernetes Prow Robot
4793ac10d6
Merge pull request #31181 from tengqm/fix-gc
...
Fix nits in the garbage collection page
2022-01-03 15:13:00 -08:00
Kubernetes Prow Robot
b7ac7eeedc
Merge pull request #31050 from suchen-sci/update-ingress-controller-easegress-link
...
[ingresscontroller] Update Easegress link for Kubernetes website
2022-01-03 14:27:00 -08:00
Qiming Teng
757915ae99
Fix nits in the garbage collection page
...
Some nits fixed in this PR:
- The typo of 'MaxContainers' and 'MaxPerPodContainer';
- The section name which should be 'Container garbage collection' rather
than 'Container image garbage collection'.
2022-01-03 21:14:31 +08:00
Meysam Azad
12ab3aecca
fix: modify typo ✏️
2021-12-27 19:51:29 +03:00
kartik494
c7b9b20083
Added a note for CRD improvement in Docs
2021-12-24 11:31:45 +05:30
glongzh
b56ba23397
Update content/en/docs/concepts/configuration/configmap.md
...
Co-authored-by: divya-mohan0209 <divya.mohan0209@gmail.com>
2021-12-23 16:05:25 +08:00
glongzh
19ab41d4b8
Update configmap docs with subpath limitation
...
This note should be added to avoid confusion just as [Secrets](/docs/concepts//configuration/secret#mounted-secrets-are-updated-automatically)
2021-12-23 10:23:23 +08:00
Kubernetes Prow Robot
2521d09aff
Merge pull request #29227 from sftim/20210804_tweak_resource_limiting_troubleshooting_advice
...
Tweak advice about managing resources for containers
2021-12-21 17:13:36 -08:00
chen
f767c7171b
update easegress link
2021-12-21 17:25:10 +08:00
Kubernetes Prow Robot
9b7902e20f
Merge pull request #31006 from tengqm/rm-sched-policy
...
Remove kube-scheduler-policy contents
2021-12-19 14:33:25 -08:00
Qiming Teng
f733bbb956
Remove kube-scheduler-policy contents
2021-12-18 09:43:50 +08:00
Kubernetes Prow Robot
574eca943f
Merge pull request #30906 from mattcary/pv-resize
...
Clarify editing PV for volume resize
2021-12-16 14:54:52 -08:00
Kubernetes Prow Robot
1b12bcc645
Merge pull request #30958 from MikeSpreitzer/fix-105494b
...
Update NetworkPolicy concept doc for egress
2021-12-16 12:52:52 -08:00
Mike Spreitzer
c25398b904
fix typeo in content/en/docs/concepts/services-networking/network-policies.md
...
Co-authored-by: Chris Negus <cnegus@redhat.com>
2021-12-16 13:45:39 -05:00
Mike Spreitzer
eab36f83c9
Update docs/concepts/services-networking/network-policies for egress
...
That doc did not get fully updated when egress filtering was
introduced.
2021-12-15 15:15:03 -05:00
ystkfujii
e138c8b39c
Remove section on dockershim
2021-12-15 22:16:18 +09:00
ystkfujii
19928a83fa
Change the dockershim state to deprecation
2021-12-15 21:51:06 +09:00
Kubernetes Prow Robot
51e89f16d4
Merge pull request #30913 from killerkc12/remove-docker-from-node-pressure
...
Remove docker from Node-pressure Eviction
2021-12-15 03:54:18 -08:00
killerkc12
5de2a04a2f
Remove docker from Node-pressure Eviction
2021-12-15 16:59:57 +05:30
ystkfujii
1fb9324fc3
remove the section on dockershim
2021-12-15 14:32:10 +09:00
bglimepoint
ab9fdcbe24
Note that subPathExpr uses round brackets.
...
As it's easy to misread this as curly brackets for users familiar with
shell interpolation.
2021-12-15 04:16:21 +00:00
Kai Hoffman
0c7491f125
Update to plural (grammar fix)
...
Minor change of ingress controller -> ingress controllers for grammatical agreement with the rest of the sentence.
2021-12-14 12:54:03 +00:00
Matt Cary
33aae9b7e5
Update content/en/docs/concepts/storage/persistent-volumes.md
...
Co-authored-by: Tim Bannister <tim@scalefactory.com>
2021-12-13 15:35:11 -08:00
Matthew Cary
57e72bce9a
Clarify editing PV for volume resize
2021-12-13 10:22:14 -08:00
Antonio Ojea
ec3ed1ee36
kubernetes networking model clarifications ( #28454 )
...
Amend some clarifications to the kubernetes networking model to
deal with some ambiguities, mainly related to the use of NAT and
the host-network pods special requirements.
xref:
https://groups.google.com/g/kubernetes-sig-network/c/m6lwTjKLV8o/m/jM59qEKOBAAJ
2021-12-11 10:31:58 -08:00
Kubernetes Prow Robot
4ac9aa413e
Merge pull request #29532 from aojea/patch-1
...
Update dual-stack node.status
2021-12-10 20:35:57 -08:00
Kubernetes Prow Robot
bec83989aa
Merge pull request #30830 from markusheinemann/main
...
Add glossary entry for cadvisor
2021-12-10 03:13:10 -08:00
Markus Heinemann
a86ca5b431
Add glossary entry for cadvisor
2021-12-09 22:28:24 +00:00
Kubernetes Prow Robot
5baf960187
Merge pull request #30758 from ixodie/patch-11
...
Kind cleanup - Remove Romana
2021-12-09 02:34:11 -08:00
Kubernetes Prow Robot
2740d85747
Merge pull request #30803 from tengqm/configapi-123
...
Configuration API for v1.23
2021-12-08 15:25:45 -08:00
Tim Bannister
367faca49f
Tweak advice about managing resources for containers
...
Co-authored-by: Shannon Kularathna <ax3shannonkularathna@gmail.com>
2021-12-08 21:40:16 +00:00
OlaAde
69f6250d6e
Typo Correction
...
Added missing `:` colons to the sample code.
2021-12-08 21:26:19 +03:00
Qiming Teng
b198199336
Configuration API for v1.23
2021-12-08 16:19:23 +08:00
Kubernetes Prow Robot
1e0a43a866
Merge pull request #30786 from tom1299/patch-1
...
Fix broken link to Ingress API
2021-12-07 16:05:22 -08:00
tom1299
fa84bdbe69
Update content/en/docs/concepts/services-networking/ingress.md
...
Co-authored-by: Tim Bannister <tim@scalefactory.com>
2021-12-07 15:59:22 +01:00
tom1299
d5539a6558
Fix broken link to Ingress API
2021-12-07 10:15:21 +01:00
Jesse Butler
584421fe11
Merge remote-tracking branch 'upstream/main' into dev-1.23
2021-12-06 08:55:54 -05:00
ixodie
5d7141f903
Kind cleanup - Remove Contiv
...
This domain/URL has no relevant content, is a squatter.
Video link on youtube is 5 years old.
Product seems to be abandonware.
2021-12-06 06:53:02 -05:00
ixodie
ac929239cf
Kind cleanup - Remove Romana
...
This doimain does not work and company appears to be defunct.
2021-12-06 06:48:52 -05:00
Kubernetes Prow Robot
200c6cadeb
Merge pull request #30501 from dialogbox/patch-1
...
Update manage-resources-containers.md
2021-12-05 20:16:32 -08:00
Kubernetes Prow Robot
524e61c17a
Merge pull request #30457 from umairadeeb/patch-1
...
Kubelet accepts graceful node shutdown parameters in camel case while they are written in the document in pascal case
2021-12-05 20:14:32 -08:00
Kubernetes Prow Robot
440409e8b1
Merge pull request #29663 from abhibhaw/issue-29524
...
feat: Documents effects on secrets when memory swap is enabled
2021-12-05 20:10:32 -08:00
Kubernetes Prow Robot
8efdd0c9c1
Merge pull request #29716 from Nordix/pod-topology-spread
...
Updates in pod-topology-spread-constraints.md
2021-12-05 18:00:32 -08:00
Kubernetes Prow Robot
1b95b8b60d
Merge pull request #29719 from sftim/20210915_document_node_problem_detector_add_on
...
Add node problem detector to add-ons
2021-12-05 17:54:35 -08:00
Kubernetes Prow Robot
1664e4e4c4
Merge pull request #29964 from MikeSpreitzer/fix-105494
...
Improve API Priority and Fairness for clients
2021-12-05 17:32:32 -08:00
Kubernetes Prow Robot
a6f6f7d9d9
Merge pull request #30213 from avinashupadhya99/fix-deployment-rollout-pause-resume-wordings
...
Improvement for k8s.io/docs/concepts/workloads/controllers/deployment/ pause rollout wordings
2021-12-05 16:58:32 -08:00
Kubernetes Prow Robot
8abfbc924e
Merge pull request #30210 from voor/pod-topology-spread-constraints-fix-formatting-example
...
Pod Topology Spread Constraints: Resolve formatting issue and add example for node affinity example.
2021-12-05 16:36:32 -08:00
Kubernetes Prow Robot
44ef715019
Merge pull request #30673 from gbarceloPIB/patch-1
...
Kubectl command waits until init containers terminated
2021-12-05 15:44:32 -08:00
Suvro
a0c6f3fd6f
Replaced annotation with ingressClassName ( #30171 )
...
* Replaced annotation with ingressClassName
Updated content of https://kubernetes.io/docs/concepts/services-networking/ingress-controllers/#using-multiple-ingress-controllers
with ingressClassName which replaces annotations
Signed-off-by: Suvro Ghosh <sughosh@redhat.com>
* Update content/en/docs/concepts/services-networking/ingress-controllers.md
Co-authored-by: Deepak Gupta <deepakgdkg1g8868@gmail.com>
Co-authored-by: Deepak Gupta <deepakgdkg1g8868@gmail.com>
2021-12-05 15:14:32 -08:00
Kubernetes Prow Robot
bbeb5184a7
Merge pull request #29739 from jtslear/jts/recommend-hpa-config
...
Add recommendation for Deployment when HPA is enabled
2021-12-05 14:56:32 -08:00
Tim Bannister
366ae6e48b
Fix IngressClass tabs
2021-12-05 22:27:50 +00:00
Kubernetes Prow Robot
ec41959cc1
Merge pull request #30134 from ixodie/patch-10
...
Removing GCE bridging/routing config tweaks
2021-12-05 12:06:32 -08:00
Kubernetes Prow Robot
04d4d3e86b
Merge pull request #30517 from sftim/20211117_reorder_storage_concepts
...
Reorder storage concepts
2021-12-05 11:56:32 -08:00
Kubernetes Prow Robot
33fec29009
Merge pull request #30707 from sftim/20211201_tweak_ingressclass_params
...
Present scope for IngressClass params using tabs
2021-12-05 06:18:32 -08:00
Tim Bannister
c1af8d4c1b
Present scope for IngressClass params using tabs
...
Use tabs for the two different options that an IngressClass can use to
refer to another object, in order to specific parameters that relate to
that IngressClass:
- namespaced scope
- cluster scope (the default / historical behavior)
2021-12-04 11:14:13 +00:00
Kubernetes Prow Robot
4f193feffe
Merge pull request #30710 from sftim/20211201_improve_probe_documentation
...
Improve documentation for container probes
2021-12-03 06:08:27 -08:00
Kubernetes Prow Robot
3baac6dde3
Merge pull request #30705 from jlbutler/merged-main-dev-1.23
...
Periodic integration branch sync for 1.23
2021-12-02 18:02:26 -08:00
Tim Bannister
8a0f330654
Improve documentation for container probes
...
- mention gRPC probes in concept page
- revise explanation of gRPC probes in task page
- general tidying
2021-12-03 00:26:22 +00:00
Kubernetes Prow Robot
3362d3ce6e
Merge pull request #30704 from sftim/20211201_tweak_flex_volume_deprecation
...
Tweak flexVolume deprecation
2021-12-02 16:10:27 -08:00
Tim Bannister
d09282b3f0
Tweak FlexVolume deprecation text
2021-12-02 23:46:47 +00:00
Kubernetes Prow Robot
793c08e6be
Merge pull request #30611 from bobbypage/pod-priority-docs
...
docs: Pod priority based graceful node shutdown
2021-12-01 12:39:18 -08:00
David Porter
94e62c43bf
docs: Pod priority based graceful node shutdown
...
Signed-off-by: David Porter <porterdavid@google.com>
2021-12-01 12:09:57 -08:00
Kubernetes Prow Robot
bbdb8c5fa7
Merge pull request #30597 from mattcary/kep-1847
...
KEP 1847 StatefulSet autodelete documentation
2021-12-01 11:55:18 -08:00
Matthew Cary
40e06a6fdb
KEP 1847 Statefulset auto-delete documentation
2021-12-01 11:44:21 -08:00
Jesse Butler
018f9d05a2
Merge remote-tracking branch 'upstream/main' into dev-1.23
2021-12-01 12:23:10 -05:00
Kubernetes Prow Robot
b1a73567ec
Merge pull request #30686 from chetak123/flexVolume_deprecated
...
Mark FlexVolume deprecated
2021-12-01 05:39:14 -08:00
Ayushman Mishra
0cbedcfeed
changes made
...
Signed-off-by: Ayushman Mishra <ayushvidushi01@gmail.com>
changes
Signed-off-by: Ayushman Mishra <ayushvidushi01@gmail.com>
2021-12-01 18:27:48 +05:30
Kubernetes Prow Robot
f20b27e539
Merge pull request #30094 from ixodie/patch-9
...
Remove Open vSwitch from “How to implement the Kubernetes networking model”
2021-12-01 04:23:16 -08:00
John T Skarbek
df3184bd52
Add recommendation for Deployment when HPA is enabled
...
* Advertise that we need to remove `spec.replicas` when a Horizontal Pod
Autoscaler is active to prevent unnecessary changes in Pod counts during
Deployment object changes
* Make note that a Deployment that has this value set behave awkwardly if a
Deployment is scaled manually outside of the Deployment object
Signed-off-by: John T Skarbek <jtslear@gmail.com>
2021-11-30 18:37:10 -05:00
Kubernetes Prow Robot
de9e3feb8f
Merge pull request #30534 from Jefftree/openapiv3
...
Docs for OpenAPI v3
2021-11-30 11:01:01 -08:00
Kubernetes Prow Robot
e858fe2b64
Merge pull request #30606 from saschagrunert/cri-architecture
...
Add CRI architecture to cluster concepts
2021-11-30 10:24:56 -08:00
Kubernetes Prow Robot
177448d3f8
Merge pull request #30552 from gnufied/kep-1790-doc
...
Add doc for Recovery from expansion failure
2021-11-30 10:18:56 -08:00
Jefftree
41547099c4
Add section for OpenAPI v3
2021-11-30 09:48:23 -08:00
Sascha Grunert
26aa51a940
Add CRI architecture to cluster concepts
...
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2021-11-30 09:35:51 +01:00
Ayushman Mishra
9bef88f008
Edited FlexVolume deprecated
...
Signed-off-by: Ayushman Mishra <ayushvidushi01@gmail.com>
2021-11-30 09:18:11 +05:30
Kubernetes Prow Robot
0f4eb182c5
Merge pull request #30430 from Shubham82/Correct-link-Authorization
...
Improvement: Corrected the link for Authorization.
2021-11-29 16:38:56 -08:00
Kubernetes Prow Robot
9b0b807049
Merge pull request #30674 from liggitt/podsecurity-beta
...
Update webhook anchor
2021-11-29 15:54:56 -08:00
Hemant Kumar
37532e231a
Add docs for RecoverVolumeExpansionFailure feature
2021-11-29 16:37:57 -05:00
Oksana Naumov
02f63b9661
CSI migration of Portworx is in alpha
2021-11-29 10:49:10 -08:00
Kubernetes Prow Robot
44576253cf
Merge pull request #30533 from humblec/rbd-mig-doc-1.23
...
Add RBD CSI migration section to the storage volumes guide
2021-11-29 09:13:23 -08:00
Kubernetes Prow Robot
3aa8d6b429
Merge pull request #30435 from ravisantoshgudimetla/psb
...
[docs]: Promote STS minReadySeconds to beta
2021-11-29 08:53:23 -08:00
Jordan Liggitt
e6a9fd269e
Update webhook anchor
2021-11-29 09:46:22 -05:00
ravisantoshgudimetla
9ea79fa719
[docs]: Update existing fields in STS spec
2021-11-29 09:06:51 -05:00
gbarceloPIB
6cb934ba19
Update pod-lifecycle.md
2021-11-29 13:59:13 +01:00
Kubernetes Prow Robot
5cad9834f7
Merge pull request #28626 from sandipb/patch-1
...
dns-pod-service.md: Fix unqualified host search ex
2021-11-27 10:38:40 -08:00
Tim Bannister
c0c3d040f8
Add node problem detector to add-ons
2021-11-27 18:37:48 +00:00
Humble Chirammal
280229b0ec
Add RBD CSI migration section to the storage volumes guide
...
Kubernetes adds the RBD CSI migration functionality via CSI
migration translation lib.
Ref# kubernetes/kubernetes#95361
This commit add the migration details to volumes.md and
feature-gates.md
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-11-26 23:42:10 +05:30
Jason Kim (Jun Chul Kim)
add3441154
Update manage-resources-containers.md
...
Warn people about mistaking "M" suffix for "m" when setting resource limits #30499
2021-11-24 23:11:27 +09:00
Shubham Kuchhal
349be77566
Improvement for Authorization in Extending Kubernetes docs.
...
Improvement: Corrected the link for Authorization.
Fix Typo
2021-11-23 16:49:02 +05:30
Kubernetes Prow Robot
29c2aedd69
Merge pull request #30537 from robscott/topology-hints-1.23
...
Updating Topology Aware Hints docs for 1.23
2021-11-22 18:22:17 -08:00
ravisantoshgudimetla
466561c47c
[docs]: Promote STS minReadySeconds to beta
2021-11-22 09:57:24 -05:00
wiggitywhitney
97495989fc
Clarify PDB line in disruptions concept page
2021-11-21 18:39:54 -06:00
Kubernetes Prow Robot
6e45595d3a
Merge pull request #29871 from verb/1.23-ec-beta
...
Promote EphemeralContainers to beta in website
2021-11-20 17:10:59 -08:00
Kubernetes Prow Robot
b6ae6e78f7
Merge pull request #29386 from bridgetkromhout/dev-1.23
...
Promote IPv4/IPv6 dual-stack support to Stable in 1.23
2021-11-20 11:04:59 -08:00
Kubernetes Prow Robot
8da444be20
Merge pull request #30505 from pohly/structured-logging-1.23
...
logging: structured logging, klog deprecation
2021-11-20 10:54:59 -08:00
Kubernetes Prow Robot
6be6d31823
Merge pull request #30333 from chetak123/mark_flexvolume_deprecated
...
Added Note for Deprecation of Flexvolume
2021-11-20 10:38:59 -08:00
Bridget Kromhout
a209e3d65e
Dual-stack to stable in 1.23
...
Co-Authored-By: Tim Bannister <tim@scalefactory.com>
2021-11-20 16:53:27 +00:00
Kubernetes Prow Robot
074e35836b
Merge pull request #30573 from SijmenHuizenga/patch-1
...
Fix broken ref in services-networking/service.md
2021-11-20 08:49:00 -08:00
Kubernetes Prow Robot
000a9de46f
Merge pull request #30559 from aravindhp/windows-projected-volume-follow-up
...
storage: Minor fixes to Windows projected volumes
2021-11-20 08:40:59 -08:00
Sijmen
20685c80c5
Fix broken ref in services-networking/service.md
2021-11-20 17:33:12 +01:00
Rob Scott
2474ff93aa
Updating Topology Aware Hints docs for 1.23
2021-11-19 16:17:10 -08:00
Aravindh Puthiyaparambil
11f5db4461
storage: Minor fixes to Windows projected volumes
...
- Add missing period
- Link to projected volume permission KEP instead of PR
- Add missing PowerShell command
2021-11-19 12:58:42 -08:00
Kubernetes Prow Robot
48a2a132b7
Merge pull request #29478 from ravisantoshgudimetla/patch-12
...
Recommend using TTL field in job
2021-11-19 04:16:51 -08:00
Kubernetes Prow Robot
2040c81a31
Merge pull request #30525 from weibeld/main
...
Change 'container' to 'Pod' in Jobs documentation
2021-11-19 02:10:52 -08:00
Daniel Weibel
d367806825
Fix wording in Jobs documentation
2021-11-19 00:58:17 +04:00
Neha Viswanathan
eaf2004e2a
replace dead links
2021-11-18 09:44:51 -08:00
Neha Viswanathan
d9d2c78964
replace dead links
2021-11-18 09:29:12 -08:00
Patrick Ohly
c3073161f7
logging: structured logging, klog deprecation
...
This is primarily the docs PR for
- alpha: https://github.com/kubernetes/enhancements/issues/2845
- beta: https://github.com/kubernetes/enhancements/issues/1602
But as it touches the file, it also updates the examples and explanations to
reflect some recent observations.
2021-11-18 08:17:36 +01:00
Jesse Butler
d330226a95
Merge remote-tracking branch 'upstream/main' into dev-1.23
2021-11-17 12:55:09 -05:00
Kubernetes Prow Robot
c688bcd8e6
Merge pull request #29751 from swatisehgal/clarify-podsresource-getallocatable
...
Pod Resource API: graduate getAllocatableResources to Beta
2021-11-17 07:23:54 -08:00
Kubernetes Prow Robot
0aa00b6902
Merge pull request #30509 from soltysh/cronjob_warning
...
Add warning about using unsupported CRON_TZ
2021-11-17 07:17:54 -08:00
Swati Sehgal
c7231c8d6d
Explicitly state that GetCpuIds returns exclusive cpus
...
Based on the discussion here: https://github.com/kubernetes/kubernetes/pull/97415#discussion_r722548437
we explictly state that the GetCpuIds returned for a ContainerResource in the ListPodResourcesResponse
represent only exclusively allocated CPUs.
In order to evaluate the CPUs corresponding to the shared pool, List endpoint should be used in conjunction
with GetAllocatableResources endpoint. We highlight the steps that the client needs to take evaluate this.
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
2021-11-17 15:16:57 +00:00
Swati Sehgal
8d6da01857
podresource-api: Graduate GetAllocatableResources to Beta
...
Also, explicitly clarify the behavior of GetAllocatableResources
The explanation that GetAllocatableResources can be used to obtain available resources
on the node can be misinterpretted as an API that is used to obtain free/unallocated
resources on a node.
This PR adds additional text to clarify that this API endpoint only returns
allocatable resources which are resources exposed to kubelet as defined here:
https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/#node-allocatable .
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
2021-11-17 15:16:57 +00:00
Kubernetes Prow Robot
9028af1ae3
Merge pull request #28226 from saschagrunert/image-config-json
...
Add docs about auth differences between Docker and Kubernetes
2021-11-17 03:49:54 -08:00
Tim Bannister
195ab34d01
Fix nits
...
Tidying that I spotted whilst reordering the storage concepts section.
2021-11-17 00:21:53 +00:00
Tim Bannister
9c0c75e0f2
Reorder storage concepts
...
Introduce concepts in an order that should suit people new to
Kubernetes, so that you don't encounter details like volume cloning
until you've seen more of the basic volume types (persistent,
ephemeral, projected).
2021-11-17 00:20:18 +00:00
Kubernetes Prow Robot
cee6c712bd
Merge pull request #30366 from aravindhp/windows-projected-volume
...
storage: document Windows projected volume limitations
2021-11-16 16:11:53 -08:00
Kubernetes Prow Robot
f235dc6cb6
Merge pull request #30225 from liggitt/podsecurity-runasuser
...
PodSecurity: runAsUser docs
2021-11-16 15:59:54 -08:00
Tim Allclair
db7dfbf166
Remove link to compromised github account
...
Follow up from incomplete fix in https://github.com/kubernetes/website/pull/30496
2021-11-16 14:20:10 -08:00
Aravindh Puthiyaparambil
4c296c6ad0
storage: document Windows projected volume limitations
...
xref: https://github.com/kubernetes/kubernetes/issues/102849
2021-11-16 09:38:05 -08:00
Maciej Szulik
b5e83e8944
Add warning about using unsupported CRON_TZ
2021-11-16 17:38:01 +01:00
Lee Verberne
771ee157a9
Promote EphemeralContainers to beta
2021-11-16 07:51:28 -05:00
Tim Allclair
1c8ec705a3
Remove link to compromised github account
...
This abandoned account was identified by a security researcher, and reported through the Kubernetes bug bounty program.
Don't we have a link checker that should identify cases like this? I'm guessing the github username was changed, so the link was redirecting (still valid), until the researcher recreated it. We should probably have the link checker flag redirects as well.
2021-11-15 16:28:37 -08:00
Kubernetes Prow Robot
7754cf242b
Merge pull request #30405 from ptux/patch-4
...
[en] update custom-resources
2021-11-15 16:21:52 -08:00
Kubernetes Prow Robot
3055d99813
Merge pull request #30440 from vaibhav2107/service-networking
...
Remove the link as refereneced content is missing
2021-11-15 12:40:49 -08:00
Vaibhav
ab99e7b104
Update the referenced link to kuberentes network model
2021-11-15 14:03:46 +05:30
Wang
0f643c43e3
Update operator.md
2021-11-14 13:10:01 +09:00
Kubernetes Prow Robot
1466530a49
Merge pull request #30361 from pohly/generic-ephemeral-volumes-ga
...
generic ephemeral volume GA
2021-11-13 14:04:46 -08:00
Avinash Upadhyaya
0913d9ed39
fix: deployment rollout pause and resume wordings
...
fix: revert link change for pausing deployments and some rewording
Co-authored-by: Tim Bannister <tim@scalefactory.com>
2021-11-13 10:01:32 +05:30
Kubernetes Prow Robot
670429c193
Merge pull request #30389 from hbagdi/ingress-class-namespaced-params-ga
...
graduate IngressClassNamespacedParams to GA
2021-11-12 17:40:47 -08:00
Kubernetes Prow Robot
20573065b3
Merge pull request #30460 from SubtextRyan/patch-1
...
Corrected grammatical error
2021-11-12 16:14:47 -08:00
Kubernetes Prow Robot
3c1d642746
Merge pull request #30393 from elmiko/update-ccm-node-controller
...
update cloud controller doc on node controller
2021-11-12 09:20:28 -08:00
SubtextRyan
46988781a3
Corrected grammatical error
...
Subject/verb disagreement: changed "...system execute the handler..." to "...system executes the handler..."
2021-11-12 12:05:00 -05:00
Kubernetes Prow Robot
1406c2d85a
Merge pull request #30170 from bobfuru/clarify-container-images-wording
...
Replace "Docker image" with "container image", other minor edits
2021-11-12 09:02:28 -08:00
sandipanpanda
7a513e6dee
Fix broken anchor link of #type-nodeport in service.md ( #30388 )
...
* Fix broken anchor link of #type-nodeport in service.md
* Update anchor link from #nodeport to #type-nodeport
Update anchor link from #nodeport to #type-nodeport in overview.md
* Update anchor link from #nodeport to #type-nodeport
Update anchor link from #nodeport to #type-nodeport in ingress.md
* Update anchor link from #nodeport to #type-nodeport
Update anchor link from #nodeport to #type-nodeport in troubleshooting-kubeadm.md
* Update anchor link from #nodeport to #type-nodeport
Update anchor link from #nodeport to #type-nodeport in connecting-frontend-backend.md
* Update anchor link from #nodeport to #type-nodeport
Update anchor link from #nodeport to #type-nodeport in source-ip.md
2021-11-12 08:02:28 -08:00
Michael McCune
0d864c18d9
update cloud controller doc on node controller
...
This change updates the information about the node controller in the
cloud controller managers. The node controller is not responsible for
creating new node objects, it updates them with information from the
provider infrastructure.
2021-11-12 08:25:40 -05:00
Kubernetes Prow Robot
e0ffcf9342
Merge pull request #30374 from clarinette9/docs-bfe-ingress
...
add BFE-ingress-controller to the document ingress-controllers.md.
2021-11-12 05:22:28 -08:00
Umair A. Shahid
53bf4f212a
Kubelet accepts graceful node shutdown parameters in camel case while they are written in the document in pascal case
2021-11-12 12:29:34 +01:00
Patrick Ohly
65bceb1876
generic ephemeral volumes: document graduation to GA
2021-11-12 09:46:11 +01:00
Harry Bagdi
4729b75ffb
graduate IngressClassNamespacedParams to GA
2021-11-11 08:51:52 -08:00
Kubernetes Prow Robot
c58838a690
Merge pull request #30423 from alculquicondor/tracking-beta
...
Graduate JobTrackingWithFinalizers to beta
2021-11-11 06:29:50 -08:00
Vaibhav
f58c7705bb
Remove the link as refereneced content is missing
2021-11-11 14:10:19 +05:30
Kubernetes Prow Robot
9dbee0dd47
Merge pull request #30351 from liggitt/podsecurity-beta
...
Podsecurity beta updates
2021-11-10 23:37:50 -08:00
Jordan Liggitt
4b7784728a
PodSecurity beta updates
2021-11-10 10:30:51 -05:00
Aldo Culquicondor
575b742e0a
Graduate JobTrackingWithFinalizers to beta
2021-11-10 09:35:30 -05:00
ahg-g
14a003cb3b
add docs for JobMutableNodeSchedulingDirectives ( #30390 )
2021-11-10 04:43:27 -08:00
Kubernetes Prow Robot
53f7612552
Merge pull request #30186 from sandersaares/request-is-not-a-guarantee
...
A CPU request does not result in a guarantee
2021-11-09 23:15:26 -08:00