letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove DNSSEC from simpleHttp and dvsni

This commit is contained in:
Richard Barnes 2015-06-23 23:33:48 -07:00
parent 5666d0316d
commit 04770218ac
1 changed files with 0 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
va/validation-authority.go
View File

@ -79,25 +79,6 @@ func (va ValidationAuthorityImpl) validateSimpleHTTP(identifier core.AcmeIdentif
} }
hostName := identifier.Value hostName := identifier.Value
// Check for DNSSEC failures for A/AAAA records
_, _, err := va.DNSResolver.LookupHost(hostName)
if err != nil {
if dnssecErr, ok := err.(core.DNSSECError); ok {
challenge.Error = &core.ProblemDetails{
Type: core.DNSSECProblem,
Detail: dnssecErr.Error(),
}
} else {
challenge.Error = &core.ProblemDetails{
Type: core.ServerInternalProblem,
Detail: "Unable to communicate with DNS server",
}
}
challenge.Status = core.StatusInvalid
va.log.Debug(fmt.Sprintf("SimpleHTTP [%s] DNS failure: %s", identifier, err))
return challenge, challenge.Error
}
var scheme string var scheme string
if input.TLS == nil || (input.TLS != nil && *input.TLS) { if input.TLS == nil || (input.TLS != nil && *input.TLS) {
scheme = "https" scheme = "https"
@ -227,25 +208,6 @@ func (va ValidationAuthorityImpl) validateDvsni(identifier core.AcmeIdentifier,
z := sha256.Sum256(RS) z := sha256.Sum256(RS)
zName := fmt.Sprintf("%064x.acme.invalid", z) zName := fmt.Sprintf("%064x.acme.invalid", z)
// Check for DNSSEC failures for A/AAAA records
_, _, err = va.DNSResolver.LookupHost(identifier.Value)
if err != nil {
if dnssecErr, ok := err.(core.DNSSECError); ok {
challenge.Error = &core.ProblemDetails{
Type: core.DNSSECProblem,
Detail: dnssecErr.Error(),
}
} else {
challenge.Error = &core.ProblemDetails{
Type: core.ServerInternalProblem,
Detail: "Unable to communicate with DNS server",
}
}
challenge.Status = core.StatusInvalid
va.log.Debug(fmt.Sprintf("DVSNI [%s] DNS failure: %s", identifier, err))
return challenge, challenge.Error
}
// Make a connection with SNI = nonceName // Make a connection with SNI = nonceName
hostPort := identifier.Value + ":443" hostPort := identifier.Value + ":443"
if va.TestMode { if va.TestMode {