letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

CA: Prepare IssueCertificate() tests for being called multiple times. (#2903) 

Take a step towards enabling the testing of precertificate issuance by
enabling the logic in these tests to be used for testing all forms
of Certificate and Precertificate issuance.
This commit is contained in:
Brian Smith 2017-07-26 13:24:46 -10:00 committed by Jacob Hoffman-Andrews
parent fcef38f78c
commit 0b9dbfba33
1 changed files with 26 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
ca/ca_test.go
View File

@ -250,6 +250,25 @@ func TestFailNoSerial(t *testing.T) {
}
func TestIssueCertificate(t *testing.T) {
testCases := []struct {
name string
setup func(t *testing.T) (*CertificateAuthorityImpl, *mockSA)
subTest func(t *testing.T, ca *CertificateAuthorityImpl, sa *mockSA)
}{
{"IssueCertificate", issueCertificateSubTestDefaultSetup, issueCertificateSubTestIssueCertificate},
{"AllowNoCN", issueCertificateSubTestDefaultSetup, issueCertificateSubTestAllowNoCN},
{"ProfileSelection", issueCertificateSubTestDefaultSetup, issueCertificateSubTestProfileSelection},
}
for _, testCase := range testCases {
ca, sa := testCase.setup(t)
t.Run(testCase.name, func(t *testing.T) {
testCase.subTest(t, ca, sa)
})
}
}
func issueCertificateSubTestDefaultSetup(t *testing.T) (*CertificateAuthorityImpl, *mockSA) {
testCtx := setup(t)
sa := &mockSA{}
ca, err := NewCertificateAuthorityImpl(
@ -264,6 +283,10 @@ func TestIssueCertificate(t *testing.T) {
test.AssertNotError(t, err, "Failed to create CA")
ca.forceCNFromSAN = false
return ca, sa
}
func issueCertificateSubTestIssueCertificate(t *testing.T, ca *CertificateAuthorityImpl, sa *mockSA) {
// Sign CSR
issuedCert, err := ca.IssueCertificate(ctx, &caPB.IssueCertificateRequest{Csr: CNandSANCSR, RegistrationID: &arbitraryRegID})
test.AssertNotError(t, err, "Failed to sign certificate")
@ -295,7 +318,7 @@ func TestIssueCertificate(t *testing.T) {
}
// Test issuing when multiple issuers are present.
func TestIssueCertificateMultipleIssuers(t *testing.T) {
func TestMultipleIssuers(t *testing.T) {
testCtx := setup(t)
// Load multiple issuers, and ensure the first one in the list is used.
newIssuerCert, err := core.LoadCert("../test/test-ca2.pem")
@ -517,21 +540,7 @@ func TestRejectValidityTooLong(t *testing.T) {
test.Assert(t, berrors.Is(err, berrors.InternalServer), "Incorrect error type returned")
}
func TestAllowNoCN(t *testing.T) {
testCtx := setup(t)
sa := &mockSA{}
ca, err := NewCertificateAuthorityImpl(
testCtx.caConfig,
sa,
testCtx.pa,
testCtx.fc,
testCtx.stats,
testCtx.issuers,
testCtx.keyPolicy,
testCtx.logger)
test.AssertNotError(t, err, "Couldn't create new CA")
ca.forceCNFromSAN = false
func issueCertificateSubTestAllowNoCN(t *testing.T, ca *CertificateAuthorityImpl, sa *mockSA) {
issueReq := caPB.IssueCertificateRequest{Csr: NoCNCSR, RegistrationID: &arbitraryRegID}
issuedCert, err := ca.IssueCertificate(ctx, &issueReq)
test.AssertNotError(t, err, "Failed to sign certificate")
@ -559,20 +568,7 @@ func TestAllowNoCN(t *testing.T) {
test.AssertDeepEquals(t, actual, expected)
}
func TestProfileSelection(t *testing.T) {
testCtx := setup(t)
testCtx.caConfig.MaxNames = 3
sa := &mockSA{}
ca, _ := NewCertificateAuthorityImpl(
testCtx.caConfig,
sa,
testCtx.pa,
testCtx.fc,
testCtx.stats,
testCtx.issuers,
testCtx.keyPolicy,
testCtx.logger)
func issueCertificateSubTestProfileSelection(t *testing.T, ca *CertificateAuthorityImpl, _ *mockSA) {
testCases := []struct {
CSR []byte
ExpectedKeyUsage x509.KeyUsage