letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reduce logging from inflight validation collisions (#7209) 

If a client attempts to validate a challenge twice in rapid succession,
we'll kick off two background validation routines. One of these will
complete first, updating the database with success or failure. The other
will fail when it attempts to update the database and finds that there
are no longer any authorizations with that ID in the "pending" state.
Reduce the level at which we log such events, since we don't
particularly care about them.

Fixes https://github.com/letsencrypt/boulder/issues/3995
This commit is contained in:
Aaron Gable 2023-12-15 09:58:34 -08:00 committed by GitHub
parent 6b54b61f21
commit 164e035915
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ra/ra.go
View File

@ -1747,10 +1747,7 @@ func (ra *RegistrationAuthorityImpl) recordValidation(ctx context.Context, authI
ValidationRecords: vr.Records,
ValidationError: vr.Problems,
})
if err != nil {
return err
}
return nil
return err
}
// PerformValidation initiates validation for a specific challenge associated
@ -1889,8 +1886,13 @@ func (ra *RegistrationAuthorityImpl) PerformValidation(
err = ra.recordValidation(vaCtx, authz.ID, authz.Expires, challenge)
if err != nil {
ra.log.AuditErrf("Could not record updated validation: regID=[%d] authzID=[%s] err=[%s]",
authz.RegistrationID, authz.ID, err)
if errors.Is(err, berrors.AlreadyRevoked) {
ra.log.Infof("Didn't record already-finalized validation: regID=[%d] authzID=[%s] err=[%s]",
authz.RegistrationID, authz.ID, err)
} else {
ra.log.AuditErrf("Failed to record validation: regID=[%d] authzID=[%s] err=[%s]",
authz.RegistrationID, authz.ID, err)
}
}
}(authz)
return bgrpc.AuthzToPB(authz)

2
sa/sa.go
View File

@ -784,7 +784,7 @@ func (ssa *SQLStorageAuthority) FinalizeAuthorization2(ctx context.Context, req
return nil, err
}
if rows == 0 {
return nil, berrors.NotFoundError("authorization with id %d not found", req.Id)
return nil, berrors.NotFoundError("no pending authorization with id %d", req.Id)
} else if rows > 1 {
return nil, berrors.InternalServerError("multiple rows updated for authorization id %d", req.Id)
}