From 17f1ee744fbb7bc3078e8b5eea763175bfbae21c Mon Sep 17 00:00:00 2001 From: Aaron Gable Date: Fri, 26 Jul 2024 09:36:06 -0700 Subject: [PATCH] Only run issue-for-sre-handoff when review requested (#7634) Running this workflow on both `ready_for_review` and `review_requested` was causing duplicate comments to show up when PRs were moved out of draft mode. This is because moving out of draft mode would both trigger a workflow run and automatically request review, which in turn would trigger a second workflow run, and the two runs were triggered in such quick succession that our commentMarker detection wouldn't work. --- .github/workflows/issue-for-sre-handoff.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/issue-for-sre-handoff.yml b/.github/workflows/issue-for-sre-handoff.yml index 19cdc8b09..47325aaae 100644 --- a/.github/workflows/issue-for-sre-handoff.yml +++ b/.github/workflows/issue-for-sre-handoff.yml @@ -2,7 +2,7 @@ name: Check PR for configuration and SQL changes on: pull_request: - types: [ready_for_review, review_requested] + types: [review_requested] paths: - 'test/config-next/*.json' - 'test/config-next/*.yaml'