letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

integration: Fail tests on unindexed queries. (#4581) 

Also incidentally remove the database flag from the mysql invocation
since it was unnecessary.

Fixes #4406
This commit is contained in:
Jacob Hoffman-Andrews 2019-11-27 10:19:36 -08:00 committed by Daniel McCarney
parent 70a9bf32d8
commit 211985eae7
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docker-compose.yml
View File

@ -78,7 +78,7 @@ services:
# because that seems to trigger based on the optimizer's choice to not
# use an index for certain queries, particularly when tables are still
# small.
command: mysqld --bind-address=0.0.0.0 --slow-query-log --log-output=TABLE --log-queries-not-using-indexes=OFF
command: mysqld --bind-address=0.0.0.0 --slow-query-log --log-output=TABLE --log-queries-not-using-indexes=ON
logging:
driver: none
netaccess:

21
test/integration-test.py
View File

@ -315,15 +315,30 @@ def check_slow_queries():
"""Checks that we haven't run any slow queries during the integration test.
This depends on flags set on mysqld in docker-compose.yml.
We skip the boulder_sa_test database because we manually run a bunch of
non-indexed queries in unittests. We skip actions by the setup and root
users because they're known to be non-indexed. Similarly we skip the
cert_checker, mailer, and janitor's work because they are known to be
slow (though we should eventually improve these).
The SELECT ... IN () on the authz2 table shows up in the slow query log
a lot. Presumably when there are a lot of entries in the IN() argument
and the table is small, it's not efficient to use the index. But we
should dig into this more.
"""
query = """
SELECT * FROM mysql.slow_log
WHERE user_host NOT LIKE "test_setup%"
AND sql_text != 'SELECT 1 FROM (SELECT SLEEP(5)) as subselect'
WHERE db != 'boulder_sa_test'
AND user_host NOT LIKE "test_setup%"
AND user_host NOT LIKE "root%"
AND user_host NOT LIKE "cert_checker%"
AND user_host NOT LIKE "mailer%"
AND user_host NOT LIKE "janitor%"
AND sql_text NOT LIKE 'SELECT status, expires FROM authz2 WHERE id IN %'
\G
"""
output = subprocess.check_output(
["mysql", "-h", "boulder-mysql", "-D", "boulder_sa_integration", "-e", query],
["mysql", "-h", "boulder-mysql", "-e", query],
stderr=subprocess.STDOUT)
if len(output) > 0:
print(output)