letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #109 from jsha/format-string 

Always use %016x when formatting shortSerial.
This commit is contained in:
jsha 2015-04-23 16:23:36 -07:00
parent 6c8f6a26a7 32e159d320
commit 3814c95594
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ca/certificate-authority_test.go
View File

@ -353,10 +353,10 @@ func TestIssueCertificate(t *testing.T) {
} }
// Verify that the cert got stored in the DB // Verify that the cert got stored in the DB
shortSerial := fmt.Sprintf("%x", cert.SerialNumber)[0:16] shortSerial := fmt.Sprintf("%016x", cert.SerialNumber)[0:16]
_, err = sa.GetCertificate(shortSerial) _, err = sa.GetCertificate(shortSerial)
test.AssertNotError(t, err, test.AssertNotError(t, err,
fmt.Sprintf("Certificate %x not found in database", shortSerial)) fmt.Sprintf("Certificate %016x not found in database", shortSerial))
} }
// Test that the CA rejects CSRs with no names // Test that the CA rejects CSRs with no names

2
ra/registration-authority_test.go
View File

@ -244,7 +244,7 @@ func TestNewCertificate(t *testing.T) {
test.AssertNotError(t, err, "Failed to issue certificate") test.AssertNotError(t, err, "Failed to issue certificate")
parsedCert, err := x509.ParseCertificate(cert.DER) parsedCert, err := x509.ParseCertificate(cert.DER)
test.AssertNotError(t, err, "Failed to parse certificate") test.AssertNotError(t, err, "Failed to parse certificate")
shortSerial := fmt.Sprintf("%x", parsedCert.SerialNumber)[0:16] shortSerial := fmt.Sprintf("%016x", parsedCert.SerialNumber)[0:16]
// Verify that cert shows up and is as expected // Verify that cert shows up and is as expected
dbCert, err := sa.GetCertificate(shortSerial) dbCert, err := sa.GetCertificate(shortSerial)

2
sa/storage-authority.go
View File

@ -374,7 +374,7 @@ func (ssa *SQLStorageAuthority) AddCertificate(certDER []byte) (digest string, e
if err != nil { if err != nil {
return return
} }
serial := fmt.Sprintf("%x", parsedCertificate.SerialNumber) serial := fmt.Sprintf("%016x", parsedCertificate.SerialNumber)
tx, err := ssa.db.Begin() tx, err := ssa.db.Begin()
if err != nil { if err != nil {