letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove /go/bin from PATH in Docker images (#2412) 

We don't write any built binaries there during the test process (Boulder
binaries go in boulder/bin), so including it in that path has no effect,
at least on Travis.

For local builds, because GOPATH gets mounted as a volume at /go/,
including /go/bin in PATH means that a docker run command locally can
wind up running a local copy of some key binary that is different than
the one that gets run in Travis. For instance, this happens when the
host's version of protoc-gen-go differs from the version in the image,
producing diffs when Travis runs the "generate" phase of test.sh.
This commit is contained in:
Jacob Hoffman-Andrews 2016-12-09 09:11:03 -08:00 committed by GitHub
parent d9b53cd103
commit 3cff6babb3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Dockerfile
View File

@ -5,7 +5,7 @@ FROM letsencrypt/boulder-tools:2016-11-02
# Boulder exposes its web application at port TCP 4000
EXPOSE 4000 4002 4003 8053 8055
ENV PATH /go/bin:/usr/local/go/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin/
ENV PATH /usr/local/go/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin/
ENV GOPATH /go
ENV GO15VENDOREXPERIMENT=1