Remove last of UseNewVARPC (#1914)

`UseNewVARPC` is no longer necessary and is safe to be removed. We default to using the newer VA RPC code.

cmd/boulder-ra/main.go

@@ -57,7 +57,7 @@ func main() {
 
 		rai := ra.NewRegistrationAuthorityImpl(clock.Default(), logger, stats,
 			c.RA.MaxContactsPerRegistration, c.KeyPolicy(),
-			c.RA.UseNewVARPC, c.RA.MaxNames, c.RA.DoNotForceCN)
+			c.RA.MaxNames, c.RA.DoNotForceCN)
 		policyErr := rai.SetRateLimitPoliciesFile(c.RA.RateLimitPoliciesFilename)
 		cmd.FailOnError(policyErr, "Couldn't load rate limit policies file")
 		rai.PA = pa

cmd/config.go

@@ -56,9 +56,6 @@ type Config struct {
 		// UseIsSafeDomain determines whether to call VA.IsSafeDomain
 		UseIsSafeDomain bool // TODO(jmhodges): remove after va IsSafeDomain deploy
 
-		// UseNewVARPC determines whether to call VA.PerformValidation
-		UseNewVARPC bool
-
 		// The number of times to try a DNS query (that has a temporary error)
 		// before giving up. May be short-circuited by deadlines. A zero value
 		// will be turned into 1.

ra/ra.go

@@ -62,7 +62,6 @@ type RegistrationAuthorityImpl struct {
 	totalIssuedCache             int
 	lastIssuedCount              *time.Time
 	maxContactsPerReg            int
-	useNewVARPC                  bool
 	maxNames                     int
 	forceCNFromSAN               bool
 
@@ -79,7 +78,6 @@ func NewRegistrationAuthorityImpl(
 	stats statsd.Statter,
 	maxContactsPerReg int,
 	keyPolicy goodkey.KeyPolicy,
-	newVARPC bool,
 	maxNames int,
 	forceCNFromSAN bool,
 ) *RegistrationAuthorityImpl {

ra/ra_test.go

@@ -239,7 +239,7 @@ func initAuthorities(t *testing.T) (*DummyValidationAuthority, *sa.SQLStorageAut
 	ra := NewRegistrationAuthorityImpl(fc,
 		log,
 		stats,
-		1, testKeyPolicy, false, 0, true)
+		1, testKeyPolicy, 0, true)
 	ra.SA = ssa
 	ra.VA = va
 	ra.CA = ca

wfe/wfe_test.go

@@ -621,7 +621,6 @@ func TestIssueCertificate(t *testing.T) {
 		stats,
 		0,
 		testKeyPolicy,
-		false,
 		0,
 		true)
 	ra.SA = mocks.NewStorageAuthority(fc)