From 4a84484912c7218fff47562498c83f7d503f1271 Mon Sep 17 00:00:00 2001 From: "J.C. Jones" Date: Wed, 22 Jul 2015 14:24:02 -0700 Subject: [PATCH] Remove the artificial OCSP Updater limit check Use whatever comes from the administrator. Adminstrator knows what she is doing. --- cmd/ocsp-updater/main.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/cmd/ocsp-updater/main.go b/cmd/ocsp-updater/main.go index 22a20a9e2..e42668e4e 100644 --- a/cmd/ocsp-updater/main.go +++ b/cmd/ocsp-updater/main.go @@ -9,7 +9,6 @@ import ( "crypto/x509" "database/sql" "fmt" - "math" "time" "github.com/letsencrypt/boulder/Godeps/_workspace/src/github.com/cactus/go-statsd-client/statsd" @@ -24,8 +23,6 @@ import ( "github.com/letsencrypt/boulder/sa" ) -const ocspResponseLimit int = 128 - // FatalError indicates the updater should stop execution type FatalError string @@ -191,7 +188,7 @@ func main() { app.App.Flags = append(app.App.Flags, cli.IntFlag{ Name: "limit", - Value: ocspResponseLimit, + Value: 100, EnvVar: "OCSP_LIMIT", Usage: "Count of responses to process per run", }) @@ -251,12 +248,10 @@ func main() { oldestLastUpdatedTime := time.Now().Add(-dur) auditlogger.Info(fmt.Sprintf("Searching for OCSP responses older than %s", oldestLastUpdatedTime)) - count := int(math.Min(float64(ocspResponseLimit), float64(c.OCSPUpdater.ResponseLimit))) - // When we choose to batch responses, it may be best to restrict count here, // change the transaction to survive the whole findStaleResponses, and to // loop this method call however many times is appropriate. - err = updater.findStaleResponses(oldestLastUpdatedTime, count) + err = updater.findStaleResponses(oldestLastUpdatedTime, c.OCSPUpdater.ResponseLimit) if err != nil { auditlogger.WarningErr(err) }