letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use responseWriter.Body.Bytes() (#4759) 

staticcheck cleanup: https://staticcheck.io/docs/checks#S1030
This commit is contained in:
Jacob Hoffman-Andrews 2020-04-08 17:21:50 -07:00 committed by GitHub
parent 0e9ac0c638
commit 4df94d5215
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
wfe/wfe_test.go
View File

@ -1272,7 +1272,7 @@ func TestNewECDSARegistration(t *testing.T) {
wfe.NewRegistration(ctx, newRequestEvent(), responseWriter, makePostRequest(result.FullSerialize())) wfe.NewRegistration(ctx, newRequestEvent(), responseWriter, makePostRequest(result.FullSerialize()))
var reg core.Registration var reg core.Registration
err = json.Unmarshal([]byte(responseWriter.Body.String()), &reg) err = json.Unmarshal(responseWriter.Body.Bytes(), &reg)
test.AssertNotError(t, err, "Couldn't unmarshal returned registration object") test.AssertNotError(t, err, "Couldn't unmarshal returned registration object")
test.Assert(t, len(*reg.Contact) >= 1, "No contact field in registration") test.Assert(t, len(*reg.Contact) >= 1, "No contact field in registration")
test.AssertEquals(t, (*reg.Contact)[0], "mailto:person@mail.com") test.AssertEquals(t, (*reg.Contact)[0], "mailto:person@mail.com")
@ -1331,7 +1331,7 @@ func TestEmptyRegistration(t *testing.T) {
// We should get back a populated Registration // We should get back a populated Registration
var reg core.Registration var reg core.Registration
err = json.Unmarshal([]byte(responseWriter.Body.String()), &reg) err = json.Unmarshal(responseWriter.Body.Bytes(), &reg)
test.AssertNotError(t, err, "Couldn't unmarshal returned registration object") test.AssertNotError(t, err, "Couldn't unmarshal returned registration object")
test.Assert(t, len(*reg.Contact) >= 1, "No contact field in registration") test.Assert(t, len(*reg.Contact) >= 1, "No contact field in registration")
test.AssertEquals(t, (*reg.Contact)[0], "mailto:person@mail.com") test.AssertEquals(t, (*reg.Contact)[0], "mailto:person@mail.com")
@ -1466,7 +1466,7 @@ func TestNewRegistration(t *testing.T) {
makePostRequest(result.FullSerialize())) makePostRequest(result.FullSerialize()))
var reg core.Registration var reg core.Registration
err = json.Unmarshal([]byte(responseWriter.Body.String()), &reg) err = json.Unmarshal(responseWriter.Body.Bytes(), &reg)
test.AssertNotError(t, err, "Couldn't unmarshal returned registration object") test.AssertNotError(t, err, "Couldn't unmarshal returned registration object")
test.Assert(t, len(*reg.Contact) >= 1, "No contact field in registration") test.Assert(t, len(*reg.Contact) >= 1, "No contact field in registration")
test.AssertEquals(t, (*reg.Contact)[0], "mailto:person@mail.com") test.AssertEquals(t, (*reg.Contact)[0], "mailto:person@mail.com")
@ -1856,7 +1856,7 @@ func TestAuthorization(t *testing.T) {
test.AssertUnmarshaledEquals(t, responseWriter.Body.String(), `{"identifier":{"type":"dns","value":"test.com"}}`) test.AssertUnmarshaledEquals(t, responseWriter.Body.String(), `{"identifier":{"type":"dns","value":"test.com"}}`)
var authz core.Authorization var authz core.Authorization
err := json.Unmarshal([]byte(responseWriter.Body.String()), &authz) err := json.Unmarshal(responseWriter.Body.Bytes(), &authz)
test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object") test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object")
// Expired authorizations should be inaccessible // Expired authorizations should be inaccessible
@ -1942,7 +1942,7 @@ func TestAuthorizationChallengeNamespace(t *testing.T) {
}) })
var authz core.Authorization var authz core.Authorization
err := json.Unmarshal([]byte(responseWriter.Body.String()), &authz) err := json.Unmarshal(responseWriter.Body.Bytes(), &authz)
test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object") test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object")
test.AssertEquals(t, len(authz.Challenges), 1) test.AssertEquals(t, len(authz.Challenges), 1)
// The Challenge Error Type should have its prefix unmodified // The Challenge Error Type should have its prefix unmodified
@ -1957,7 +1957,7 @@ func TestAuthorizationChallengeNamespace(t *testing.T) {
URL: mustParseURL(authzURL), URL: mustParseURL(authzURL),
}) })
err = json.Unmarshal([]byte(responseWriter.Body.String()), &authz) err = json.Unmarshal(responseWriter.Body.Bytes(), &authz)
test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object") test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object")
test.AssertEquals(t, len(authz.Challenges), 1) test.AssertEquals(t, len(authz.Challenges), 1)
// The Challenge Error Type should have had the probs.V1ErrorNS prefix added // The Challenge Error Type should have had the probs.V1ErrorNS prefix added

4
wfe2/wfe_test.go
View File

@ -1618,7 +1618,7 @@ func TestAuthorizationChallengeNamespace(t *testing.T) {
}) })
var authz core.Authorization var authz core.Authorization
err := json.Unmarshal([]byte(responseWriter.Body.String()), &authz) err := json.Unmarshal(responseWriter.Body.Bytes(), &authz)
test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object") test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object")
test.AssertEquals(t, len(authz.Challenges), 1) test.AssertEquals(t, len(authz.Challenges), 1)
// The Challenge Error Type should have its prefix unmodified // The Challenge Error Type should have its prefix unmodified
@ -1632,7 +1632,7 @@ func TestAuthorizationChallengeNamespace(t *testing.T) {
URL: mustParseURL("56"), URL: mustParseURL("56"),
}) })
err = json.Unmarshal([]byte(responseWriter.Body.String()), &authz) err = json.Unmarshal(responseWriter.Body.Bytes(), &authz)
test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object") test.AssertNotError(t, err, "Couldn't unmarshal returned authorization object")
test.AssertEquals(t, len(authz.Challenges), 1) test.AssertEquals(t, len(authz.Challenges), 1)
// The Challenge Error Type should have had the probs.V2ErrorNS prefix added // The Challenge Error Type should have had the probs.V2ErrorNS prefix added