letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crl-updater: log once per shard on success or failure (#6373) 

Ensure that crl-updater logs one line per shard, no matter whether
that shard succeeded or failed.
This commit is contained in:
Aaron Gable 2022-09-12 14:35:34 -07:00 committed by GitHub
parent 7f189f7a3b
commit 4eb9a9f06a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
crl/updater/updater.go
View File

@ -281,6 +281,11 @@ func (cu *crlUpdater) tickShard(ctx context.Context, atTime time.Time, issuerNam
ctx, cancel := context.WithCancel(ctx)
defer cancel()
crlId, err := crl.Id(issuerNameID, crl.Number(atTime), shardIdx)
if err != nil {
return err
}
start := cu.clk.Now()
defer func() {
// Each return statement in this function assigns its returned value to the
@ -288,6 +293,7 @@ func (cu *crlUpdater) tickShard(ctx context.Context, atTime time.Time, issuerNam
// variable, and so can reference and modify it.
result := "success"
if err != nil {
cu.log.AuditErrf("Generating CRL failed: id=[%s] err=[%s]", crlId, err)
result = "failed"
err = fmt.Errorf("%d: %w", shardIdx, err)
}
@ -400,10 +406,6 @@ func (cu *crlUpdater) tickShard(ctx context.Context, atTime time.Time, issuerNam
return fmt.Errorf("closing CRLStorer upload stream: %w", err)
}
crlId, err := crl.Id(issuerNameID, crl.Number(atTime), shardIdx)
if err != nil {
return err
}
cu.log.Infof("Generated CRL: id=[%s] size=[%d] hash=[%x]", crlId, crlLen, crlHash.Sum(nil))
return nil
}