letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

crl-updater: remove deprecated options (#8021) 

Note: the issues listed in the TODOs (#6438 and #7023) are already
closed.
This commit is contained in:
Jacob Hoffman-Andrews 2025-03-07 11:27:49 -08:00 committed by GitHub
parent 12e660874d
commit 98b6d3f8bf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
cmd/crl-updater/main.go
View File

@ -56,17 +56,6 @@ type Config struct {
// recovering from an outage to ensure continuity of coverage. // recovering from an outage to ensure continuity of coverage.
LookbackPeriod config.Duration `validate:"-"` LookbackPeriod config.Duration `validate:"-"`
// CertificateLifetime is the validity period (usually expressed in hours,
// like "2160h") of the longest-lived currently-unexpired certificate. For
// Let's Encrypt, this is usually ninety days. If the validity period of
// the issued certificates ever changes upwards, this value must be updated
// immediately; if the validity period of the issued certificates ever
// changes downwards, the value must not change until after all certificates with
// the old validity period have expired.
// Deprecated: This config value is no longer used.
// TODO(#6438): Remove this value.
CertificateLifetime config.Duration `validate:"-"`
// UpdatePeriod controls how frequently the crl-updater runs and publishes // UpdatePeriod controls how frequently the crl-updater runs and publishes
// new versions of every CRL shard. The Baseline Requirements, Section 4.9.7 // new versions of every CRL shard. The Baseline Requirements, Section 4.9.7
// state that this MUST NOT be more than 7 days. We believe that future // state that this MUST NOT be more than 7 days. We believe that future
@ -74,15 +63,6 @@ type Config struct {
// recommend an UpdatePeriod of 6 hours. // recommend an UpdatePeriod of 6 hours.
UpdatePeriod config.Duration UpdatePeriod config.Duration
// UpdateOffset controls the times at which crl-updater runs, to avoid
// scheduling the batch job at exactly midnight. The updater runs every
// UpdatePeriod, starting from the Unix Epoch plus UpdateOffset, and
// continuing forward into the future forever. This value must be strictly
// less than the UpdatePeriod.
// Deprecated: This config value is not relevant with continuous updating.
// TODO(#7023): Remove this value.
UpdateOffset config.Duration `validate:"-"`
// UpdateTimeout controls how long a single CRL shard is allowed to attempt // UpdateTimeout controls how long a single CRL shard is allowed to attempt
// to update before being timed out. The total CRL updating process may take // to update before being timed out. The total CRL updating process may take
// significantly longer, since a full update cycle may consist of updating // significantly longer, since a full update cycle may consist of updating

1
test/config/crl-updater.json
View File

@ -47,7 +47,6 @@
"shardWidth": "240h", "shardWidth": "240h",
"lookbackPeriod": "24h", "lookbackPeriod": "24h",
"updatePeriod": "6h", "updatePeriod": "6h",
"updateOffset": "9120s",
"maxParallelism": 10, "maxParallelism": 10,
"maxAttempts": 5, "maxAttempts": 5,
"features": {} "features": {}