From c66fd768405ee5c9bacf8b1cef6aca2d13bf78d2 Mon Sep 17 00:00:00 2001 From: Roland Bracewell Shoemaker Date: Tue, 21 Jan 2020 12:55:44 -0800 Subject: [PATCH] Register forgotten metrics (#4653) Follow-up from #4606, where I forgot to register some metrics, whoops. --- ca/ca.go | 1 + cmd/ocsp-updater/main.go | 1 + nonce/nonce.go | 3 +++ 3 files changed, 5 insertions(+) diff --git a/ca/ca.go b/ca/ca.go index 1a90a7fb0..5a0bebb24 100644 --- a/ca/ca.go +++ b/ca/ca.go @@ -296,6 +296,7 @@ func NewCertificateAuthorityImpl( Name: "signature_errors", Help: "A counter of signature errors labelled by error type", }, []string{"type"}) + stats.MustRegister(signErrorCounter) ca = &CertificateAuthorityImpl{ sa: sa, diff --git a/cmd/ocsp-updater/main.go b/cmd/ocsp-updater/main.go index d38f2cb6e..062266ea4 100644 --- a/cmd/ocsp-updater/main.go +++ b/cmd/ocsp-updater/main.go @@ -133,6 +133,7 @@ func newUpdater( Name: "ocsp_updater_ticks", Help: "A histogram of ocsp-updater tick latencies labelled by result", }, []string{"result", "long"}) + stats.MustRegister(tickHistogram) // Setup loops updater.loops = []*looper{ diff --git a/nonce/nonce.go b/nonce/nonce.go index ac1439412..440d59392 100644 --- a/nonce/nonce.go +++ b/nonce/nonce.go @@ -109,14 +109,17 @@ func NewNonceService(stats prometheus.Registerer, maxUsed int, prefix string) (* Name: "nonces_generated", Help: "A counter of nonces generated", }) + stats.MustRegister(noncesGenerated) nonceValidations := prometheus.NewCounterVec(prometheus.CounterOpts{ Name: "nonces_validations", Help: "A counter of nonce validations labelled by result", }, []string{"result", "error"}) + stats.MustRegister(nonceValidations) nonceHeapLatency := prometheus.NewHistogram(prometheus.HistogramOpts{ Name: "nonce_heap_latency", Help: "A histogram of latencies of heap pop operations", }) + stats.MustRegister(nonceHeapLatency) return &NonceService{ earliest: 0,