From c9b8eb5c6a00664cd2857f3fdfaf9ec781ef4d05 Mon Sep 17 00:00:00 2001 From: "J.C. Jones" Date: Thu, 10 Feb 2022 09:43:00 -0700 Subject: [PATCH] Make cert-checker's stderr less misleading (#5937) The stderr, when reviewing logs, saying that the sample size was 0 implies that cert-checker sampled no certificates. In reality, it is working fine; that zero indicates that the JSON array dumped to stdout has 0 entries, which is actually good. Let's just fix this stderr message (which isn't parsed by any tooling we have) so that the next poor SRE that sees it doesn't freak out and file tickets to start incident response. --- cmd/cert-checker/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/cert-checker/main.go b/cmd/cert-checker/main.go index cfc726323..fb4c66111 100644 --- a/cmd/cert-checker/main.go +++ b/cmd/cert-checker/main.go @@ -450,7 +450,7 @@ func main() { wg.Wait() fmt.Fprintf( os.Stderr, - "# Finished processing certificates, sample: %d, good: %d, bad: %d\n", + "# Finished processing certificates, report length: %d, good: %d, bad: %d\n", len(checker.issuedReport.Entries), checker.issuedReport.GoodCerts, checker.issuedReport.BadCerts,