From e81f7477a3169f77fd7247a6cdb8822fb29433aa Mon Sep 17 00:00:00 2001 From: Daniel McCarney Date: Thu, 9 Mar 2017 13:20:03 -0500 Subject: [PATCH] Fixes outdated IPv6 TODO on `getAddr`. (#2601) The VA's `getAddr` function prior to this commit had an outdated comment & a pointer to a TODO for Boulder Issue #593. That issue has been closed and bdns' `LookupHost` supports AAAA records now. This commit updates the comment to match the current behaviour and removes the TODO. --- va/va.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/va/va.go b/va/va.go index dd6b5ddc5..49e1475fd 100644 --- a/va/va.go +++ b/va/va.go @@ -97,11 +97,10 @@ type verificationRequestEvent struct { Error string `json:",omitempty"` } -// getAddr will query for all A records associated with hostname and return the -// preferred address, the first net.IP in the addrs slice, and all addresses resolved. -// This is the same choice made by the Go internal resolution library used by -// net/http, except we only send A queries and accept IPv4 addresses. -// TODO(#593): Add IPv6 support +// getAddr will query for all A/AAAA records associated with hostname and return +// the preferred address, the first net.IP in the addrs slice, and all addresses +// resolved. This is the same choice made by the Go internal resolution library +// used by net/http. func (va ValidationAuthorityImpl) getAddr(ctx context.Context, hostname string) (net.IP, []net.IP, *probs.ProblemDetails) { addrs, err := va.dnsResolver.LookupHost(ctx, hostname) if err != nil {