letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bdns: replace direct type assertions with errors.As (#5122) 

errors.As checks for a specific error in a wrapped error chain
(see https://golang.org/pkg/errors/#As) as opposed to asserting
that an error is of a specific type

Part of #5010
This commit is contained in:
Samantha 2020-10-13 17:31:42 -07:00 committed by GitHub
parent 7ca12212c4
commit feebb4017e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bdns/dns_test.go
View File

@ -368,7 +368,8 @@ func TestDNSLookupHost(t *testing.T) {
t.Logf("%s - IP: %s, Err: %s", hostname, ip, err)
test.AssertError(t, err, "Should be an error")
expectedErr := DNSError{dns.TypeA, hostname, nil, dns.RcodeRefused}
if err, ok := err.(*DNSError); !ok || *err != expectedErr {
var dnserr *DNSError
if !(errors.As(err, &dnserr) && *dnserr == expectedErr) {
t.Errorf("Looking up %s, got %#v, expected %#v", hostname, err, expectedErr)
}
}
@ -379,13 +380,14 @@ func TestDNSNXDOMAIN(t *testing.T) {
hostname := "nxdomain.letsencrypt.org"
_, err := obj.LookupHost(context.Background(), hostname)
expected := DNSError{dns.TypeA, hostname, nil, dns.RcodeNameError}
if err, ok := err.(*DNSError); !ok || *err != expected {
var dnserr *DNSError
if !(errors.As(err, &dnserr) && *dnserr == expected) {
t.Errorf("Looking up %s, got %#v, expected %#v", hostname, err, expected)
}
_, err = obj.LookupTXT(context.Background(), hostname)
expected.recordType = dns.TypeTXT
if err, ok := err.(*DNSError); !ok || *err != expected {
if !(errors.As(err, &dnserr) && *dnserr == expected) {
t.Errorf("Looking up %s, got %#v, expected %#v", hostname, err, expected)
}
}