Commit Graph

9 Commits

Author SHA1 Message Date
Aaron Gable bc899ac3ef
Update go-sql-driver/mysql from v1.5.0 to v1.7.1 (#8138)
Version v1.5.0 was released in January 2020, over five years ago. We
have attempted to update this package several times since then -- first
to v1.6.0, later to v1.7.1 -- but have reverted the change due to
nigh-inexplicable performance regressions each time. Since our last
attempt, we believe we have addressed the underlying issue by truncating
timestamps when we talk to the database (see
https://github.com/letsencrypt/boulder/pull/7556) so that our indices
don't try to track nanosecond precision.

We are now ready to reattempt updating this package to v1.7.1 again. If
that goes well, we will further update it to the newest version.

Fixes https://github.com/letsencrypt/boulder/issues/5437
Part of https://github.com/letsencrypt/boulder/issues/7872
2025-04-24 17:29:41 -07:00
Jacob Hoffman-Andrews e955494955
Revert "Update go-sql-driver/mysql to v1.7.1" (#7006)
This reverts commit 0051277c71,
which was introduced by https://github.com/letsencrypt/boulder/pull/6976
2023-07-20 12:28:20 -07:00
Aaron Gable 0051277c71
Update go-sql-driver/mysql to v1.7.1 (#6976)
This update pulls in changes that we contributed upstream, which should
smooth interactions between Boulder and ProxySQL.

Release notes:
https://github.com/go-sql-driver/mysql/releases/tag/v1.7.1
Changelog:
https://github.com/go-sql-driver/mysql/compare/v1.5.0...v1.7.1
Relevant change: https://github.com/go-sql-driver/mysql/pull/1402
2023-07-11 12:51:44 -07:00
Jacob Hoffman-Andrews d47445e207
Downgrade go-sql-driver/mysql to 1.5.0 (#6709)
This week's release produced another performance regression
2023-03-01 07:16:41 -08:00
Aaron Gable 85b146e82a
Reland "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0" (#6662)
This reverts letsencrypt/boulder#6660, and relands
letsencrypt/boulder#6625.
2023-02-21 14:52:23 -05:00
Jacob Hoffman-Andrews 0f2b47e072
Revert "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 (#6625)" (#6660)
This reverts commit fdfea0d469.

With a Go security release out this week we prefer to do a single
release on the new Go version rather than trying to deploy the new
go-sql-driver version.
2023-02-14 12:19:31 -08:00
dependabot[bot] fdfea0d469
build(deps): Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0 (#6625)
Update https://github.com/go-sql-driver/mysql from 1.5.0 to 1.7.0.

Also change db.IsDuplicate() and db.IsNoRows to more directly
use errors.Is(), and to be more resilient to error string message
changes such as the one that is included in this version update.

Changelog: https://github.com/go-sql-driver/mysql/compare/v1.5.0...v1.7.0
2023-02-13 13:35:21 -08:00
Jeff Hodges b88750ede0 remove prefixdb and replace with mysql driver params (#2871)
This uses the mysql driver library's capability to use `SET` to set the system
variables that prefixdb previously was.

Unfortunately, the library doesn't sort the params when making the string, so we
have to do a little munging to TestNewDbMap.

Ran it in a checkout of the repo since godeps now doesn't include the test files (which is great!).

```
MYSQL_TEST_ADDR=127.0.0.1:3306 go test .
ok  	github.com/go-sql-driver/mysql	46.099s
```
2017-07-17 16:40:56 -07:00
Jacob Hoffman-Andrews e6c17e1717 Switch to new vendor style (#1747)
* Switch to new vendor style.

* Fix metrics generate command.

* Fix miekg/dns types_generate.

* Use generated copies of files.

* Update miekg to latest.

Fixes a problem with `go generate`.

* Set GO15VENDOREXPERIMENT.

* Build in letsencrypt/boulder.

* fix travis more.

* Exclude vendor instead of godeps.

* Replace some ...

* Fix unformatted cmd

* Fix errcheck for vendorexp

* Add GO15VENDOREXPERIMENT to Makefile.

* Temp disable errcheck.

* Restore master fetch.

* Restore errcheck.

* Build with 1.6 also.

* Match statsd.*"

* Skip errcheck unles Go1.6.

* Add other ignorepkg.

* Fix errcheck.

* move errcheck

* Remove go1.6 requirement.

* Put godep-restore with errcheck.

* Remove go1.6 dep.

* Revert master fetch revert.

* Remove -r flag from godep save.

* Set GO15VENDOREXPERIMENT in Dockerfile and remove _worskpace.

* Fix Godep version.
2016-04-18 12:51:36 -07:00