Commit Graph

121 Commits

Author SHA1 Message Date
Roland Shoemaker 01c41c1bd0 Merge pull request #354 from letsencrypt/344-internal_server_errors
Resolves Issue #344: Only send InternalServerError when needed
2015-06-15 15:57:04 -07:00
Jacob Hoffman-Andrews 80d5e50e42 Enable revocation by account key.
In addition to cert private key. This required modifying the GetCertificate*
functions to return core.Certificate instead of certificate bytes.
2015-06-15 12:33:50 -07:00
J.C. Jones 1474b7f21f Resolves Issue #344: Only send InternalServerError when needed
Basically, just send InternalServerError when it indicates an internal state
was broken.
2015-06-13 00:21:44 -05:00
Roland Shoemaker 9af2742ae2 Merge pull request #353 from letsencrypt/cors
Send CORS headers
2015-06-12 16:05:50 -07:00
Jacob Hoffman-Andrews 8b0fcde9ce Merge pull request #352 from letsencrypt/allow
Send an Allow header whenever we send 405
2015-06-12 14:58:50 -07:00
Jacob Hoffman-Andrews af64f5a534 Add missing return. 2015-06-12 14:37:26 -07:00
Jacob Hoffman-Andrews 2b2f4110d4 Revoke path should not end in slash. 2015-06-12 13:26:43 -07:00
Richard Barnes 615366636a Send CORS headers 2015-06-11 22:26:16 -04:00
Richard Barnes d398bd962a Send an Allow header whenever we send 405 2015-06-11 22:12:01 -04:00
bifurcation 676ebf721f Merge pull request #325 from letsencrypt/anti-replay
Add an anti-replay nonce facility
2015-06-10 16:55:20 -04:00
Richard Barnes 8289a6d2fa Make tests pass 2015-06-09 17:43:16 -04:00
J.C. Jones a64d521023 Add more details to the /build endpoint in the WFE as well. 2015-06-09 12:25:33 -07:00
Richard Barnes d653f97cb8 Transition from random nonces to encrypted counters 2015-06-09 12:30:49 -04:00
Richard Barnes fca1567cb2 Fixes to integration tests 2015-06-08 15:31:56 -04:00
Richard Barnes a620fe4583 Initial anti-replay mechanism 2015-06-08 15:02:39 -04:00
Roland Shoemaker 573e35ed56 Disallow multiple registrations with same key (and fix all related tests) 2015-06-04 20:21:59 +01:00
James 'J.C.' Jones bbd5ff1821 Merge pull request #301 from rolandshoemaker/299-audit
Only audit log internal server errors in WFE
2015-06-03 13:15:20 -07:00
Roland Shoemaker 7de8bef948 Add comment 2015-06-03 18:15:12 +01:00
Roland Shoemaker ce84a4c31a Only audit log internal server errors in WFE 2015-06-03 18:11:19 +01:00
Jacob Hoffman-Andrews ccb401f993 Add comment clarifying agreement check. 2015-06-02 15:56:26 -07:00
Jacob Hoffman-Andrews 3974a0eaa6 Revert "Actually verify compliance to a specific subscriber agreement"
This reverts commit 33ed771180.

Conflicts:
	wfe/web-front-end.go
2015-06-02 15:56:23 -07:00
bifurcation 04479eca5c Merge pull request #291 from letsencrypt/fix-revocation
Revert change to revocation from #275
2015-06-02 17:52:35 -04:00
Jacob Hoffman-Andrews 7a60d431d6 Revert "Supporess the 'expires' field in public Authorizations"
This reverts commit d47b7c12ac.

Conflicts:
	core/objects.go
	wfe/web-front-end.go
2015-06-02 12:02:05 -07:00
Jacob Hoffman-Andrews 026cb424fc Revert "Replace RevokeCertficate with something more in line with the spec"
This reverts commit b1bad40fe6.

Conflicts:
	wfe/web-front-end.go
2015-06-02 10:45:54 -07:00
Jacob Hoffman-Andrews 6c66207834 Fix nil key bug in AMQP mode. 2015-06-01 12:24:23 -07:00
Richard Barnes 63ca50229d Fix a bug introduced in 81fa97f and make ./start.sh work 2015-06-01 12:46:19 -04:00
Richard Barnes 577478db7a One more nit from JCJ 2015-06-01 02:16:32 -04:00
Richard Barnes bfd9e4ac20 Fixing JCJ nits 2015-06-01 02:11:10 -04:00
Richard Barnes b1bad40fe6 Replace RevokeCertficate with something more in line with the spec 2015-06-01 02:11:10 -04:00
Richard Barnes ba84275611 Enable GET on Challenge resources 2015-06-01 02:08:47 -04:00
Richard Barnes d47b7c12ac Supporess the 'expires' field in public Authorizations 2015-06-01 02:08:47 -04:00
Richard Barnes 791118eee7 Clean up argument names in WFE methods 2015-06-01 02:08:47 -04:00
Richard Barnes f6cf178edc Simplify Terms() output 2015-06-01 02:08:47 -04:00
Richard Barnes 1492c8b0cf Remove Let's Encrypt from Index() 2015-06-01 02:08:47 -04:00
Richard Barnes 129b05f42a Always check the method first thing 2015-06-01 02:05:17 -04:00
Richard Barnes afc5fb8e93 Add Link header field to Authz GET 2015-06-01 02:05:17 -04:00
Richard Barnes 764c7165b0 Do registration check before attempting to parse response 2015-06-01 02:05:17 -04:00
Richard Barnes 6a518383ba Actually verify compliance to a specific subscriber agreement 2015-06-01 02:05:17 -04:00
Richard Barnes 81fa97fb21 Remove duplicative calls to MergeUpdate 2015-06-01 02:05:17 -04:00
Richard Barnes 9917ca17f6 Clean up TODOs 2015-06-01 02:05:17 -04:00
Richard Barnes c0bacc3fb6 Add more detailed error code reporting 2015-05-31 15:58:08 -04:00
J.C. Jones 8766edaa93 Issue #239 - Add a build ID method to WFE, and print Info on startup for all 2015-05-28 11:13:09 -07:00
J.C. Jones d1321f2d78 More RPC fixes for Issue #202
- NewPendingAuthorization now uses a core.Authorization object, so
  that foreign key constraints are followed
- core.Authorization now serializes RegistrationID to JSON, so it has to get
  blanked out in WFE before transmission to client.
- Remove ParsedCertificate from core.Certificate, as type x509.Certificate cannot
  be marshaled.
- Added AssertDeepEquals and AssertMarhsaledEquals to test-tools.go
- Caught several overloaded and misleadingly named errors in WFE
2015-05-28 11:05:55 -07:00
J.C. Jones c5415c77c0 Fix: Challenge URIs were incomplete when running in RPC mode. 2015-05-28 08:19:58 -07:00
J.C. Jones e4e52e7315 More work on Issue #202 for RPC functions
- Fix a bunch of typos in rpc-wrappers.go
- Unblank `id` in core.Registration JSON:
  - It's not spec, but it's not hurting anything, and we reveal it to clients anyway.
  - We need knowledge of the ID in RPC, so if we don't want to include this in the object, we need to make a transfer object to wrap it.
- Make the RPC logs much clearer as to who's talking to who
- Typo in WFE where we called a registration an authz
2015-05-27 23:37:12 -07:00
James 'J.C.' Jones 5d82c5f994 Merge pull request #224 from rolandshoemaker/182-return
Return 500 for multiple certs with same short serial
2015-05-26 15:53:02 -07:00
J.C. Jones bc3acca096 Resolved Issue #230
- Move setting the core.Registration.Key field from RA.NewRegistration to
  WFE.NewRegistration to avoid a chicken-and-egg problem.
- Note: I kept the RPC wrapper object even though it now only has one field.
  Seems like it's a good practice to use wrapper objects, even though we don't
  everywhere.
2015-05-26 14:44:15 -07:00
Roland Shoemaker 5541a8ab37 remove trailing , and return 500 for multi certs with the same short serial 2015-05-25 09:26:37 +01:00
Jacob Hoffman-Andrews c1f3791b27 Fix some issues brought up by integration test 2015-05-21 17:25:56 -07:00
Jacob Hoffman-Andrews 153234204d Add an integration test using test.js
Include updates to test.js to make its output more useful as a diagnostic.

It remains a future TODO to do integration testing with the real letsencrypt
client.

Also, work around a go vet bug.
2015-05-21 16:51:40 -07:00