Commit Graph

206 Commits

Author SHA1 Message Date
Jeff Hodges 92f1689310 make DNS ProblemDetails more clear
Fixes #1259
2015-12-28 13:09:33 -08:00
Jeff Hodges bce554a270 correct publicsuffix import in RA
And remove the incorrectly vendorized code from Godeps.
2015-12-17 12:59:15 -08:00
Jeff Hodges e36895c9c5 bring RTT metrics inside DNSResolver
This moves the RTT metrics calculation inside of the DNSResolver. This
cleans up code in the RA and VA and makes some adding retries to the
DNSResolver less ugly to do.

Note: this will put `Rate` and `RTT` after the name of DNS query
type (`A`, `MX`, etc.). I think that's fine and desirable. We aren't
using this data in alerts or many dashboards, yet, so a flag day is
okay.

Fixes #1124
2015-12-16 17:41:42 -08:00
Jeff Hodges 9ea4ac8b14 return ProblemDetails when validating emails in ra
Fixes #1153
2015-12-15 14:44:19 -08:00
Jeff Hodges b31165444f move dns code to dns pkg and rename to bdns
Moves the DNS code from core to dns and renames the dns package to bdns
to be clearer.

Fixes #1260 and will be good to have while we add retries and such.
2015-12-14 11:21:43 -08:00
Jeff Hodges 16f87146ea Merge branch 'master' into delete_old_challenges 2015-12-11 11:43:06 -08:00
Tony Finch ea9cf5cdd0 Validate mail domains in the DNS correctly
The RFC 5321 algorithm is to check the MX records first, and
if they are missing, check for address records. At the moment
we only check A records since there is no IPv6 support.

Fixes #1197
2015-12-11 10:39:07 +00:00
Jeff Hodges c9010744b4 delete old challenge code
Specifically, delete the simpleHttp and dvsni.

Hooray!

Fixes #894
2015-12-10 15:41:40 -08:00
Jacob Hoffman-Andrews d5bb20561f Fix nil dereference in AcmeURL unmarshal and in validateContacts. 2015-12-04 09:46:46 -08:00
Jacob Hoffman-Andrews 662ed0730f Fix return types of errors. 2015-11-19 15:43:39 -08:00
Jacob Hoffman-Andrews 0c9b2a71d2 Fix DNS RTT stat to .A 2015-11-11 17:27:20 -08:00
Jacob Hoffman-Andrews e24314a0fb Move problemDetailsFromDNSError into new package. 2015-11-11 12:56:30 -08:00
Jacob Hoffman-Andrews 3ccc79e49d Don't serve 500's on DNS timeout.
Fixes https://github.com/letsencrypt/boulder/issues/1047
2015-11-10 19:10:01 -08:00
Jeff Hodges 13cab5c257 add Google Safe Browsing API calls
This allows us to call the Google Safe Browsing calls through the VA.

If the RA config's boolean UseIsSafeDomain is true, the RA will make the RPC
call to the VA during its NewAuthorization.

If the VA config's GoogleSafeBrowsingConfig struct is not nil, the VA
will check the Google Safe Browsing API in
VA.IsSafeDomain. If the GoogleSafeBrowsingConfig struct is nil, it will
always return true.

In order to actually make requests, the VA's GoogleSafeBrowsingConfig
will need to have a directory on disk it can store the local GSB hashes
it will check first and a working Google API key for the GSB API.

Fixes #1058
2015-11-06 16:37:34 -08:00
Roland Shoemaker c073da7b1b Flatten method sig 2015-10-22 10:21:29 -07:00
Roland Shoemaker ba56e7c587 Make MatchesCSR downcase CommonName before checking equality 2015-10-21 15:02:15 -07:00
Richard Barnes 251d253aee Fix golint and change to 1 week 2015-10-20 11:09:38 -04:00
Richard Barnes bd1dee5bbc StatusGone -> StatusNotFound 2015-10-20 11:01:24 -04:00
Richard Barnes 35c4f267ec Merge branch 'master' into shorter-expiry-for-pending 2015-10-20 09:21:55 -04:00
Roland Shoemaker 6171420108 Golint fixes to builds work 2015-10-18 18:59:05 -07:00
Jacob Hoffman-Andrews 2f75214a88 Add limit on number of pending authorizations.
Adds a new method CountPendingAuthorizations to SA.
2015-10-14 13:50:43 -07:00
Richard Barnes 0da6d48b06 Return a plain error from RA 2015-10-13 15:54:21 -07:00
Richard Barnes bd1f8d1e42 Fix RA checking and add RA test 2015-10-13 15:50:49 -07:00
Richard Barnes 000be360c4 Set 36 hour default lifetime for pending authorizations 2015-10-13 15:37:30 -07:00
Roland Shoemaker 1d710f91cd Merge branch 'master' into ocsp-revoke
Conflicts:
	cmd/ocsp-updater/main.go
2015-10-09 15:50:14 -07:00
Richard Barnes d905dfed93 Have the RA honor expiry 2015-10-09 18:21:58 -04:00
Richard Barnes c3dacf5dae Make expired authz URLs inaccessible. 2015-10-09 17:45:34 -04:00
Richard Barnes 74c2293ae7 Merge branch 'master' to shorter-expiry-for-pending 2015-10-09 16:59:58 -04:00
Richard Barnes da150dd0f3 Have a shorter expiry time for pending authorizations 2015-10-09 16:57:55 -04:00
bifurcation f6b57a7729 Merge branch 'master' into limit-contacts 2015-10-09 16:41:53 -04:00
Richard Barnes 109f7cf75e Limit the number of contacts per registration 2015-10-09 16:35:19 -04:00
Jeff Hodges 68536ac22a Merge branch 'master' into lower_domains 2015-10-09 13:04:00 -07:00
Jacob Hoffman-Andrews c80206d424 Respond to review feedback. 2015-10-08 23:14:25 -07:00
Roland Shoemaker 10b6bb5548 Refactor certificate revocation and OCSP generation workflows
* Moves revocation from the CA to the OCSP-Updater, the RA will mark certificates as
  revoked then wait for the OCSP-Updater to create a new (final) revoked response
* Merges the ocspResponses table with the certificateStatus table and only use UPDATES
  to update the OCSP response (vs INSERT-only since this happens quite often and will
  lead to an extremely large table)
2015-10-08 18:55:11 -07:00
Jeff Hodges 0df44e5d90 clean up CSRs with capitalized letters
This change lowercases domains before they are stored in the database
and makes policy.WillingToIssue reject any domains with uppercase
letters.

Fixes #927.
2015-10-08 17:04:07 -07:00
Jacob Hoffman-Andrews 487d08ec2e Add rate limiting by registration IP. 2015-10-08 15:47:08 -07:00
Jacob Hoffman-Andrews acdb1fa91b Merge branch 'master' into issued-names-limit-2
Conflicts:
	mocks/mocks.go
	rpc/rpc-wrappers.go
	sa/storage-authority.go
2015-10-07 17:20:36 -07:00
Jacob Hoffman-Andrews 1899866d6b Add registration-based overrides. 2015-10-06 17:55:21 -07:00
Jacob Hoffman-Andrews 8af3bd953b Fix review comments. 2015-10-06 16:12:23 -07:00
Jacob Hoffman-Andrews e0cdd13bbb Merge branch 'master' into issued-names-limit-2 2015-10-06 16:10:29 -07:00
Richard Barnes f064c6d5c7 Merge branch 'master' to 'sig-reuse' 2015-10-05 23:16:16 -04:00
Jeff Hodges 5217af94b0 allow whitelisting by a specific reg id
Currently, the whitelisted registration ID is one that is impossible for the
database to return. Once the partner's registration is in place, we can
deploy a change to it.

Fixes #810
2015-10-05 14:11:38 -07:00
Jacob Hoffman-Andrews 903f39508e Vendorize publicsuffix. 2015-10-04 21:04:29 -07:00
Jacob Hoffman-Andrews 1d91d81158 Implement rate limiting by domain name. 2015-10-04 21:04:26 -07:00
Richard Barnes eb42a08258 Make RA check sanity and make tests pass 2015-10-03 10:41:23 -04:00
Richard Barnes 4c20bfe310 Merge master to sig-reuse 2015-10-01 18:58:35 -07:00
Roland Shoemaker 65f10a5f9f Review fixes 2015-09-30 15:34:24 -07:00
Richard Barnes 1a9fd9b455 Update to latest ACME spec 2015-09-28 10:10:06 -04:00
Richard Barnes 54c924b436 Merge branch 'master' into sig-reuse 2015-09-27 18:29:14 -04:00
Roland Shoemaker 96afd94e88 Review fixes
* Rewrite JSONDuration as ConfigDuration that can handle both JSON and YAML unmarshaling
* Factor out RPC certificate count request struct
* Return 429 to WFE on rate limit exceeded
* Fix wonky RateLimitPolicy comment
2015-09-25 14:39:53 -07:00