Commit Graph

800 Commits

Author SHA1 Message Date
Roland Shoemaker 1ae613bd87 Review fixes 2015-08-20 12:14:13 -07:00
Jeff Hodges f1738eb593 add copyright to sa/model.go 2015-08-20 10:27:44 -07:00
Roland Shoemaker 2cfe6a6884 Cleanup 2015-08-18 18:53:08 -07:00
Roland Shoemaker c5a38e61d1 Error fix 2015-08-18 16:49:54 -07:00
Roland Shoemaker 69edf779b5 Switch to real model vs. view 2015-08-18 16:38:06 -07:00
Roland Shoemaker 015e089b7d Review fixes pt. 2 2015-08-18 13:33:25 -07:00
Roland Shoemaker eaa1ef9f0d Intial review cleanups 2015-08-18 11:19:52 -07:00
Roland Shoemaker 3fe109d33c Merge master 2015-08-15 16:03:01 -07:00
Jeff Hodges 5e97aa23c6 use MariaDB in the unit tests
And delete the uses of sqlite3
2015-08-14 17:13:15 -07:00
Roland Shoemaker a01a15df07 Switch to challengeModel instead of core.Challenge, various scehma fiddling and trickery 2015-08-14 16:08:46 -07:00
Roland Shoemaker 5601581aec Merge branch 'master' into challenge-table 2015-08-14 13:53:20 -07:00
Roland Shoemaker 6cae3f27ce Merge pull request #620 from letsencrypt/always_set_parse_time
always set parseTime to true
2015-08-14 10:52:45 -07:00
Jeff Hodges ae5fa728ea always set parseTime to true
There's no reason to not just enforce it in the code completely and not
worry about it elsewhere. If we need to extract code out of NewDbMap,
we'd need recombineURLForDB in it, anyhow.
2015-08-13 22:45:33 -07:00
Roland Shoemaker 1d863fca32 Merge master 2015-08-13 20:52:18 -07:00
Roland Shoemaker 7455df2eee Cleanups and test fixes 2015-08-13 20:48:29 -07:00
Roland Shoemaker 5be6e588ee Initial work 2015-08-13 20:24:25 -07:00
Jeff Hodges b701cb60ce Merge pull request #605 from letsencrypt/rm-jsonbuffer
Remove JSONBuffer from TypeConverter.
2015-08-13 17:44:59 -07:00
Jacob Hoffman-Andrews 8c89e6db8c Remove JSONBuffer from TypeConverter. 2015-08-11 22:55:37 -07:00
Jacob Hoffman-Andrews 64987a3639 Merge pull request #599 from letsencrypt/mysql
use MariaDB in integration tests and start.py
2015-08-11 20:31:46 -07:00
Jeff Hodges 86390e312b require mysql+tcp:// as the scheme for db conns 2015-08-11 20:17:35 -07:00
Jacob Hoffman-Andrews 4d8367bc0e Remove logging of dbConnect string.
This can accidentally put passwords in logs.
2015-08-11 12:32:10 -07:00
Jeff Hodges 7f44d22604 use URL.Path until TravisCI gets 1.5
Either we'll figure out how to get it added or they will.
2015-08-08 02:08:47 -07:00
Jeff Hodges 42a626f9fc fix comment about db URLs and trim dbConnect 2015-08-07 23:30:01 -07:00
Jeff Hodges b08e6e0bad use MariaDB in integration tests and start.py
This changes moves from using SQLite in the integration tests and in the
test/boulder-config.json.

It does not port the unit tests over, unfortunately. That's a much more
invasive change.

This also updates the Dockerfile to include the MariaDB and RabbitMQ
requirements of start.py as well as adjusts the CMD to expose the
boulder server to the host machine. The Dockerfile also needed to have
its Go version bumped and the test.sh had to grow some explict
"function"s.

Updates #132
2015-08-07 23:22:52 -07:00
Jeff Hodges 390464ddf4 correct unique indexing of Registrations
Fixes #579 (which blocks #132).

This changes the SA to use a unique index on the sha256 of a
Registration's JWK's public key data instead of on the full serialized
JSON of the JWK. This corrects multiple problems:

 1. MySQL/Mariadb no longer complain about key's being larger than the
 largest allowed key size in an index
 2. We no longer have to worry about large keys not being seen as unique
 3. We no longer have to worry about the JWK's JSON being serialized with its inner keys in different orders and causing incorrectly empty queries or non-unique writes.

This change also hides the details of how Registrations are stored in
the database from the other services outside of SA. This will give us
greater flexibility if we need to move them to another database, or
change their schema, etc.

Also, adds some tests for NoSuchRegistration in the SA.
2015-08-06 14:19:19 -07:00
Roland Shoemaker 461725bc48 Merge pull request #588 from letsencrypt/exp_mailer_db
use GetRegistration RPC outside of SA
2015-08-06 14:07:31 -07:00
Jeff Hodges 1c08a27748 use GetRegistration RPC outside of SA
We move the admin-revoker and expiration-mailer to using the
SA.GetRegistration RPC method instead of digging into the database
itself.

This allows the hiding of the registration model layer inside of SA, so
we can do fancy things with sha256 for the unique index inside of
it. This will happen in a later commit. See #579.

By exposing fewer details about how Registration is stored, we gain more
flexibility to fix up how its stored.

In the expiration-mailer, the performance hit for the early filtering of
mailto is likely neglibible and possibly even a benefit given the cost
of joins to the memory of MySQL.

If need be, we can built a bulk RPC layer for SA that provides the data
we need in findExpiringCertificates. It'll be easier than trying to
scale and change the storage layer underneath for each consumer.
2015-08-06 02:10:54 -07:00
Jeff Hodges 0f03494d56 use pointer to AcmeURL everywhere
This has the benefit of not requiring us to copy very fat url.URL
objects when we pass them to funcs or call their methods.
2015-08-05 18:23:38 -07:00
Jeff Hodges c32790a28c remove unused bucket field from SQLStorageAuthority 2015-07-31 14:05:32 -07:00
Richard Barnes 540de44c81 Fix test failure introduced in merge 2015-07-30 13:56:11 -04:00
Richard Barnes 652702bd7f Merge master 2015-07-30 13:47:10 -04:00
bifurcation 60e82f6df3 Merge pull request #544 from letsencrypt/mysql-uri
Make sure MySQL DB URI contains 'parseTime=true'
2015-07-29 16:53:32 -04:00
Roland Shoemaker 272fbbd480 Merge pull request #541 from r0ro/remove-authz-newcert
Remove the need for a client to send authorizations url when requesting new certificate
2015-07-29 13:10:46 -07:00
Roland Shoemaker df179a1dde Review fixes 2015-07-29 12:17:04 -07:00
Richard Barnes 9e87cef807 Further test fixes 2015-07-29 12:20:00 -04:00
Roland Shoemaker 3a5f96c9e1 Remove debug statement 2015-07-28 10:33:26 -07:00
Romain Fliedel 36cba96fb2 update tests after jwk encoding fix. 2015-07-28 16:25:30 +02:00
Romain Fliedel c5d1189ae8 Add tests for GetLatestValidAuthorization. 2015-07-28 11:45:08 +02:00
Romain Fliedel 236a90afda fix sql request to get only valid authorizations. 2015-07-28 11:45:08 +02:00
Roland Shoemaker ae06aeee30 Move parseTime check to NewDbMap so binaries that don't use a SSA still get the checking 2015-07-27 20:03:20 -07:00
Roland Shoemaker 33a79c3910 Pull out previous parseTime check 2015-07-27 17:57:14 -07:00
Roland Shoemaker 33b59530c6 typo 2015-07-27 17:46:00 -07:00
Roland Shoemaker faed5cc241 Merge branch 'master' into mysql-uri 2015-07-27 17:40:15 -07:00
Roland Shoemaker 9b715a6e9e If using MySQL check for parseTime=true in DSN, if not there add it 2015-07-27 17:39:31 -07:00
Jacob Hoffman-Andrews 4e1051bfdc Fix OCSP updating.
Fixes https://github.com/letsencrypt/boulder/issues/539.

Passes a pointer to tx.Update() in the SA, resolving the gorp error we were
previously receiving in UpdateOCSP.

Fixes CA code to properly receive the error from UpdateOCSP, so future errors
will be logged correctly.
2015-07-27 16:40:04 -07:00
Romain Fliedel 4bbd0fdccd Remove the need for a client to submit authorization urls when requesting a certificate. 2015-07-27 20:26:56 +02:00
Jacob Hoffman-Andrews 9423467142 Switch to our own fork of go-jose.
This is the result of `godep save -r ./...` and
`git rm -r -f Godeps/_workspace/src/github.com/square`

Our fork is currently at the head of go-jose when Richard made the local nonce
changes, with the nonce changes added on top. In other words, the newly created
files are exactly equal to the deleted files.

In a separate commit I will bring our own go-jose fork up to the remote head,
then update our deps.

Also note: Square's go-jose repo contains a `cipher` package. Since we don't
make any changes to that package, we leave it imported as-is.
2015-07-24 14:39:00 -07:00
Jacob Hoffman-Andrews 620a012c62 Rewrite go-jose dependencies to our fork. 2015-07-24 14:16:01 -07:00
Tom Clegg 2d0be62966 Use mock syslog in test suites (except core and log). Drop SwitchLog(). 2015-07-21 17:06:39 -04:00
Jeff Hodges 79d9b52ad0 rename dbName to dbConnect
The configuration is actually a connection string, not a database name,
and it was a bit confusing.
2015-07-10 16:17:27 -07:00
Richard Barnes 9bd9ed08da Change from adding the parameter to enforcing it 2015-06-23 23:18:45 -07:00
Richard Barnes e7a48127e6 Append ?parseTime=true when needed 2015-06-23 23:01:18 -07:00
Roland Shoemaker 403af37a39 Hide Authorization.Expires field when uninitialized 2015-06-17 18:34:30 -07:00
J.C. Jones 41f5788c77 Correct most `go lint` warnings. (274 -> 5) 2015-06-16 22:18:28 -05:00
Jacob Hoffman-Andrews 80d5e50e42 Enable revocation by account key.
In addition to cert private key. This required modifying the GetCertificate*
functions to return core.Certificate instead of certificate bytes.
2015-06-15 12:33:50 -07:00
Roland Shoemaker 2d2efa5e85 Merge pull request #356 from letsencrypt/remove-slash
Revoke path should not end in slash
2015-06-12 13:55:10 -07:00
Jacob Hoffman-Andrews 2b2f4110d4 Revoke path should not end in slash. 2015-06-12 13:26:43 -07:00
Roland Shoemaker f4ee29d1d3 Change all references from SimpleHTTPS -> SimpleHTTP 2015-06-12 11:22:04 -07:00
Jacob Hoffman-Andrews 32531c7f24 Merge pull request #350 from letsencrypt/252-remove_null_key_hack
Issue #252: Remove the hack from Type Converter
2015-06-11 16:22:51 -07:00
J.C. Jones ef0e7fd3f6 New tests
- Write a database.go test
 - Start writing a type-converter.go test
2015-06-11 17:29:38 -05:00
J.C. Jones b0cb08e49a Issue #252: Remove the hack from Type Converter 2015-06-11 13:24:10 -05:00
J.C. Jones 34bad37ab0 Remove dead code `DumpTables`.
If you really want to do this, use
the tools provided with your chosen Database backend.
2015-06-11 13:24:10 -05:00
J.C. Jones 2ad15a4a85 Issue #309: Produce OCSP Responses immediately upon issuance, if at all possible.
This approach performs a best-effort generation of the first OCSP response during
certificate issuance. In the event that OCSP generation fails, it logs a warning at
the Boulder-CA console, but returns successfully since the Certificate was itself
issued.
2015-06-11 11:31:04 -05:00
J.C. Jones a8b0e01c5a Finish initial version of OCSP Responder
- Correct the Database implementation to match current schema & GORP
- Add some debug logging
- Correct CA Key identification
- Move SQL Debugging into the Database object and file, so that things that don't use the Storage Authority can toggle it
2015-06-05 15:03:38 -07:00
Roland Shoemaker 573e35ed56 Disallow multiple registrations with same key (and fix all related tests) 2015-06-04 20:21:59 +01:00
Jacob Hoffman-Andrews 026cb424fc Revert "Replace RevokeCertficate with something more in line with the spec"
This reverts commit b1bad40fe6.

Conflicts:
	wfe/web-front-end.go
2015-06-02 10:45:54 -07:00
Richard Barnes b1bad40fe6 Replace RevokeCertficate with something more in line with the spec 2015-06-01 02:11:10 -04:00
Richard Barnes e8edbf5f21 Making capitalization consistent with Go standards 2015-06-01 02:08:47 -04:00
Richard Barnes 9917ca17f6 Clean up TODOs 2015-06-01 02:05:17 -04:00
James 'J.C.' Jones 3e593d73c9 Merge pull request #262 from letsencrypt/ra-tests
Miscellaneous Fixes
2015-05-30 22:08:49 -07:00
Richard Barnes f7541f1bc2 Issue #252 2015-05-30 17:41:15 -04:00
Richard Barnes 1723a9641f Some minor fixes to address build issues 2015-05-30 14:16:27 -04:00
Richard Barnes 7a09c78788 Issue #254 2015-05-30 13:21:36 -04:00
J.C. Jones 4518f0bf17 Migrate CADB to using GORP. 2015-05-28 23:11:03 -07:00
J.C. Jones e14f59c559 Rework from PR #251: 2015-05-28 23:03:48 -07:00
J.C. Jones d1321f2d78 More RPC fixes for Issue #202
- NewPendingAuthorization now uses a core.Authorization object, so
  that foreign key constraints are followed
- core.Authorization now serializes RegistrationID to JSON, so it has to get
  blanked out in WFE before transmission to client.
- Remove ParsedCertificate from core.Certificate, as type x509.Certificate cannot
  be marshaled.
- Added AssertDeepEquals and AssertMarhsaledEquals to test-tools.go
- Caught several overloaded and misleadingly named errors in WFE
2015-05-28 11:05:55 -07:00
J.C. Jones e4e52e7315 More work on Issue #202 for RPC functions
- Fix a bunch of typos in rpc-wrappers.go
- Unblank `id` in core.Registration JSON:
  - It's not spec, but it's not hurting anything, and we reveal it to clients anyway.
  - We need knowledge of the ID in RPC, so if we don't want to include this in the object, we need to make a transfer object to wrap it.
- Make the RPC logs much clearer as to who's talking to who
- Typo in WFE where we called a registration an authz
2015-05-27 23:37:12 -07:00
J.C. Jones af0f8446eb Issue #202, Periodic OCSP Signer Tool
- Move dbMap construction and type converter into individual files in the sa package.
- Add DB configuration for the OCSP tool to the boulder config:
  - left to the user if they want to use different boulder-config.json files
    for different purposes.
- Added updater to Makefile
- Fix trailing ',' in the Boulder config, add more panic logging
- Ignore .pem files produced by the integration test
- Change RPC to use per-instance named reply-to queues.
- Finish OCSP Updater logic
- Rework RPC for OCSP to use a transfer object (due to serialization problems of x509.Certificate)
2015-05-27 22:01:29 -07:00
Jacob Hoffman-Andrews e87f5245a5 OCSP Updater administrator cmdline tool
- First steps towards ocsp updater.
- Move the type converter into its own file in "sa" rather than core, to keep
  Gorp from leaking out of the SA package.
2015-05-27 22:01:29 -07:00
Jacob Hoffman-Andrews 714432e9d7 Max JWK size of 1024. 2015-05-27 16:08:04 -07:00
J.C. Jones 343920cfe3 Fix integration test while running with MySQL
- Add SQL configuration options
- Increase the width of the authz and pending_authz tables' challenges field
- Make it configurable whether CREATE TABLE commands should run
2015-05-27 13:39:18 -07:00
J.C. Jones f15da06af7 Issue #238 - MySql column width too narrow
- Added SQL debug logging (SA option: "SQLDebug")
- Added timestamps to the log prints to stdout
- Ignore *.pem in test/js
- Modified start.sh to support environment overrides for BOULDER_CONFIG, like the AMQP mode
- Changed boulder-test-config to open the server on the loopback device, so as to not cause firewall prompts on each integration test run for those of us being restrictive
- Renamed "key" column to "jwk" in DB, to avoid keyword conflict
- Set MaxLength on "jwk" column to 512
2015-05-27 12:12:41 -07:00
Roland Shoemaker d184862427 gofmt and move deniedCSR table creation back to SA 2015-05-25 01:17:28 +01:00
Roland Shoemaker 1d65bed82e remove commented code 2015-05-25 01:06:59 +01:00
Roland Shoemaker a4790fdd22 finish serial-revoke and reg-revoke, switch to transactional semantics 2015-05-25 00:49:52 +01:00
Roland Shoemaker 0ab71bed62 initial revoker work 2015-05-23 12:46:56 +01:00
Roland Shoemaker 97ff1c8423 merge upstream/master 2015-05-18 19:07:04 -07:00
Roland Shoemaker 1c7d0d5411 gofmt touched files 2015-05-18 19:03:25 -07:00
J.C. Jones 42302541bd Run `go fmt` for PR #186 2015-05-18 18:44:38 -07:00
Roland Shoemaker af01cb0cf9 Cleanup RA.NewAuthorization and add SA tests for GetRegistration and GetRegistrationByKey with invalid arguments 2015-05-18 18:02:06 -07:00
Roland Shoemaker e1ba291019 Store registration ID with certificate 2015-05-16 13:47:51 -07:00
Roland Shoemaker faa1d5ac45 review cleanups 2015-05-16 13:25:36 -07:00
Roland Shoemaker e233fdaa61 switch authz and pending_authz to store registration ID instead of key (and update all the random stuff they touched) 2015-05-14 14:14:36 -07:00
James 'J.C.' Jones 6be5c4910e Merge pull request #185 from rolandshoemaker/deny-store
Store and check previously denied CSRs
2015-05-14 09:03:06 -07:00
Roland Shoemaker b3d85ed9b5 fix breakage introduced by b0rked rebase 2015-05-13 19:30:37 -07:00
Roland Shoemaker 8aa2a0607e return full registration object and proper JSON marshal 2015-05-13 19:16:55 -07:00
Roland Shoemaker b9745cf894 check key is assosiated with existing registration in verifyPOST 2015-05-13 19:16:20 -07:00
Jacob Hoffman-Andrews aa8c20f84a Fixes in response to review feedback. 2015-05-13 17:36:39 -07:00
Jacob Hoffman-Andrews f51f0605da Add reference to issue. 2015-05-13 17:36:38 -07:00
Jacob Hoffman-Andrews 3eed9e3f7c Move to Square's go-jose library. 2015-05-13 17:36:38 -07:00
Roland Shoemaker 5d5eea7071 switch to only store dns names 2015-05-13 12:08:50 -07:00
Roland Shoemaker 07182500eb add missing rpc methods 2015-05-12 00:08:48 -07:00
Roland Shoemaker a2b3461d6f make CSR content unique in SQL table 2015-05-11 23:07:41 -07:00
Roland Shoemaker d95c552ab4 add denied csr table and AddDeniedCSR + AlreadyDeniedCSR methods for checking, added AddDeniedCSR to ra.NewCertificate 2015-05-11 23:02:39 -07:00
Roland Shoemaker 79b8958f70 fix conflict 2015-05-07 02:07:32 -07:00
Roland Shoemaker df1ff86acd revert to original transactional semantics 2015-05-07 01:55:38 -07:00
Roland Shoemaker 3041423361 dont export the pending/authz utility models 2015-05-06 22:22:31 -07:00
Roland Shoemaker 6a065d5cfc reversing part of the transaction cull 2015-05-06 21:48:55 -07:00
Roland Shoemaker 1cc1df2726 use core objects as models (except for pending/final authz) 2015-05-06 21:45:37 -07:00
Roland Shoemaker ae62792d52 actually use them 2015-05-06 16:47:27 -07:00
Roland Shoemaker 8290206ef8 consistent test style 2015-05-04 15:17:20 -07:00
Roland Shoemaker ca21cce198 some registration + authorization tests 2015-05-03 15:19:06 -07:00
Roland Shoemaker e25c60eaf8 PK typo 2015-05-03 14:08:02 -07:00
Roland Shoemaker 06536fae13 v2 compatible lock column setting 2015-05-03 13:51:11 -07:00
Roland Shoemaker 1597af6d2b fix vet problems 2015-05-03 13:35:15 -07:00
Roland Shoemaker 99f385c56e only add lock cols to tables that need them... 2015-05-03 02:59:45 -07:00
Roland Shoemaker 7a1a7ec32a add opti-lock (for v1) col, fix certificatesStatus typo, better FinalizeAuthorization 2015-05-03 02:29:58 -07:00
Roland Shoemaker 421434f2cb clean up boulderTypeConverter 2015-05-03 01:57:30 -07:00
Roland Shoemaker 0a4affaeba switch rest of functions to gorp, extended TypeConverter 2015-05-02 23:58:19 -07:00
Roland Shoemaker 1cee83c262 add db tags to structs we are embeding, update models, add custom type converter, simplify DumpTables (+ fix it), move GetCert... methods to gorp 2015-05-02 21:28:39 -07:00
Roland Shoemaker 4b27ae253e finish dumpTables and make it public (DumpTables) 2015-05-02 17:08:47 -07:00
Roland Shoemaker 8a6748182e add gorp dep 2015-05-02 16:00:35 -07:00
Jacob Hoffman-Andrews ac78f333f8 Merge branch 'master' into ocsp-table
Conflicts:
	ca/certificate-authority.go
	ca/certificate-authority_test.go
	cmd/boulder-ca/main.go
	cmd/boulder/main.go
	sa/storage-authority.go
	sa/storage-authority_test.go
2015-05-02 11:10:05 -07:00
J.C. Jones a77152e828 Rework Authority "New" methods to obtain AuditLogger from Singleton
- Also ran `go fmt` against these files I was touching anyway:
    sa/storage-authority.go
    va/validation-authority.go
    wfe/web-front-end.go
2015-05-01 21:50:07 -07:00
J.C. Jones e828c61818 Add singleton semantics to Audit Logger, per Issue #135
- Update tests to use the singleton logger
- Update commands to set the audit logger singleton
- Formatting updates to the tests (go fmt)
2015-05-01 21:48:24 -07:00
Jacob Hoffman-Andrews 7733793bb6 Fix test mode boulder instances.
Update initialization stanza.
Revert to inmemory sqlite storage for now.
Remove NOT NULL constraint from some fields.
2015-05-01 19:28:10 -07:00
Jacob Hoffman-Andrews 7352757086 Add test 2015-05-01 16:01:50 -07:00
Jacob Hoffman-Andrews 73603c95cf Add reason code and fix index. 2015-04-30 11:31:36 -07:00
Jacob Hoffman-Andrews 8e30ff81fb Partly done implementation of revoke. 2015-04-29 18:36:26 -07:00
Jacob Hoffman-Andrews 1d2c6a5d7c Split out GetCertificate / GetCertificateByShortSerial.
Also stub out some initial revocation code.
2015-04-29 11:48:08 -07:00
Jacob Hoffman-Andrews 3aa3355b27 TEXT -> VARCHAR(255) 2015-04-29 10:20:56 -07:00
Jacob Hoffman-Andrews f66651bc86 Add revokedDate to certificate status table. 2015-04-28 18:51:15 -07:00
Jacob Hoffman-Andrews ca6e349906 Fix tests. 2015-04-23 20:06:17 -07:00
Jacob Hoffman-Andrews 7145207104 Add initial certificate status in SA.
Also improve test tools.
2015-04-23 19:52:34 -07:00
Jacob Hoffman-Andrews 4d592ee261 Add cert metadata to table schema.
Also restructure table init to DRY it.
2015-04-23 17:57:18 -07:00
Jacob Hoffman-Andrews 32e159d320 Always use %016x when formatting shortSerial. 2015-04-23 16:09:46 -07:00
Roland Shoemaker b63c9f3dcf fixed typo
Not sure how that got changed...
2015-04-23 13:51:09 -07:00
Roland Shoemaker 828ea5641f cleanup 2015-04-22 20:27:42 -07:00
Roland Shoemaker 2c370de691 back to always-init method 2015-04-22 20:15:57 -07:00
Roland Shoemaker 7cf1872d74 typo 2015-04-21 18:44:34 -07:00
Roland Shoemaker 6944f233d4 sqlite doesn't support information_schema table 2015-04-21 17:53:53 -07:00
Roland Shoemaker e43bd98c78 move InitTables to NewSQLStorageAuthority and add checks so tables are only created if they don't exist 2015-04-21 17:46:05 -07:00
Jacob Hoffman-Andrews 7d8ef9a019 Fix tests and tidy up for review. 2015-04-18 23:44:42 -04:00
Jacob Hoffman-Andrews 431ad092eb Query certs by sequential part of serial number.
Also refactor WFE for better initialization and change StorageAuthority to
support this type of query.
2015-04-18 00:48:19 -04:00
Jacob Hoffman-Andrews 84df10fd6e Add empty tests where missing.
This will bring our coverage numbers down to a more meaningful number, and will
mean that we can start aiming to increase them monotonically.
2015-04-07 11:27:33 -07:00
J.C. Jones 33ac212b70 Add logging infrastructure to all authorities and commands 2015-03-24 19:06:11 -07:00
J.C. Jones 4e0aa900c9 Rebase 'lint-errcheck-fixes' of git://github.com/mvdan/boulder to letsencrypt/master
Conflicts:
	cmd/boulder-start/main.go
	core/interfaces.go
	core/objects.go
	core/util.go
	ra/registration-authority.go
	ra/registration-authority_test.go
	rpc/rpc-wrappers.go
	va/validation-authority.go
	wfe/web-front-end.go
2015-03-20 18:01:03 -07:00
Richard Barnes 96bd7e215a Further plumbing of registrations 2015-03-15 15:33:05 -04:00
Daniel Martí 880821801e hash.Hash.Write() never returns an error 2015-03-12 12:18:37 +01:00
Richard Barnes dcdf9954ae Pulling out sa module 2015-03-10 15:21:50 -07:00