Commit Graph

25 Commits

Author SHA1 Message Date
J.C. Jones cecd097f68 Improve unit testing to resolve Issue #217
- Support multiple HTTPserver instances in `validation-authority_test.go`
- Improve coverage of ValidateDvsni and ValidateHttps
- Cover UpdateValidations
2015-05-21 13:59:30 -07:00
J.C. Jones 1c9837ddf8 Audit all Challenges (success/failure) in VA for Issue #204
- Don't ignore entropy underruns in challenges.go
- Correct identity crisis in Policy Authority; hopefully it will remember.
- Add a method `AuditObject` in audit-logger and convert RA/VA to use it
- Fix json typo in registration-authority that caused empty audit logs
- Fix vet issue in WFE where RegID was being printed as a 32-bit int instead of 64-bit
- Unfix the issue in WFE where RegID isn't right, per PR #215
2015-05-21 13:58:40 -07:00
J.C. Jones 42302541bd Run `go fmt` for PR #186 2015-05-18 18:44:38 -07:00
Jacob Hoffman-Andrews 8acae627eb Fix sanity checking for challenges.
Also add more debug logging.
2015-05-08 15:32:11 -07:00
jsha 14fde00182 Merge pull request #162 from rolandshoemaker/enrobe
Reduce use of naked returns
2015-05-08 08:59:52 -07:00
Roland Shoemaker ee47c84838 enrobe longer functions + various return semantics cleanups 2015-05-07 18:15:41 -07:00
Roland Shoemaker 07310b5fa1 hook sanity check into VA and RA 2015-05-06 15:19:21 -07:00
Roland Shoemaker 3fddff8dcf further tests for VA, consistent sendError for verifyPOST in WFE 2015-05-05 15:31:53 -07:00
J.C. Jones a77152e828 Rework Authority "New" methods to obtain AuditLogger from Singleton
- Also ran `go fmt` against these files I was touching anyway:
    sa/storage-authority.go
    va/validation-authority.go
    wfe/web-front-end.go
2015-05-01 21:50:07 -07:00
Jacob Hoffman-Andrews d4aa8c6c78 Close connection after DVSNI. 2015-04-27 15:50:18 -07:00
Jacob Hoffman-Andrews 66cb0fcefe Fix format strings for serials and DVSNI. 2015-04-27 14:47:06 -07:00
Jacob Hoffman-Andrews 9124b34b31 Improve Validation Authority
SimpleHTTPS works in both local test mode and live mode.
Don't keep alive SimpleHTTPS connections after verifying challenge.
2015-04-27 13:18:38 -07:00
Jacob Hoffman-Andrews e210f2c623 Fix live validation for SimpleHTTPS. 2015-04-24 19:20:58 -07:00
Jacob Hoffman-Andrews 1065b14c9c Add more logging to boulder. 2015-04-24 18:39:50 -07:00
Jacob Hoffman-Andrews b9c7efb9f8 Constant-time compare zName.
Fixes https://github.com/letsencrypt/boulder/issues/52.

Note that this is probably not a vulnerability, since the value of zName is not
a secret from the subscriber. But better to eliminate this code smell.
2015-04-13 17:47:58 -04:00
Roland Shoemaker 5d155e209b forgot to remove encoding/hex 2015-04-08 22:40:05 -07:00
Roland Shoemaker f7e3df3f67 fix Z computation 2015-04-08 22:30:12 -07:00
Peter Eckersley ccbbeccb00 gofmt 2015-03-25 14:52:50 -07:00
Peter Eckersley 5eac0cda09 Add a "TestMode" config option
This makes the same change as PR #59, but allows test mode to be turned
back on with a config option.
2015-03-25 12:58:57 -07:00
J.C. Jones 33ac212b70 Add logging infrastructure to all authorities and commands 2015-03-24 19:06:11 -07:00
J.C. Jones 4e0aa900c9 Rebase 'lint-errcheck-fixes' of git://github.com/mvdan/boulder to letsencrypt/master
Conflicts:
	cmd/boulder-start/main.go
	core/interfaces.go
	core/objects.go
	core/util.go
	ra/registration-authority.go
	ra/registration-authority_test.go
	rpc/rpc-wrappers.go
	va/validation-authority.go
	wfe/web-front-end.go
2015-03-20 18:01:03 -07:00
Richard Barnes d938deb3fd Separate resources for challenges [initial] 2015-03-14 19:07:16 -04:00
Daniel Martí d66e581736 Replace Https by HTTPS as per golint 2015-03-12 12:21:40 +01:00
Daniel Martí 880821801e hash.Hash.Write() never returns an error 2015-03-12 12:18:37 +01:00
Richard Barnes 37919058e5 Pulling out va module 2015-03-10 14:26:20 -07:00