Commit Graph

100 Commits

Author SHA1 Message Date
Jeff Hodges 8975601d5e correct bodyStr->body 2015-07-23 17:41:15 -07:00
Roland Shoemaker 31f0674f03 Replace net.LookupMX with core.LookupMX using defined resolver 2015-07-21 22:36:29 -07:00
Brad Warren c092d41348 Merge remote-tracking branch 'upstream/master' into errors 2015-06-19 13:25:38 -07:00
Brad Warren 9312fb7eae Allowed for more detailed error messages: 2015-06-19 12:51:09 -07:00
Roland Shoemaker 47187d6224 Log hex serial number 2015-06-19 12:49:57 -07:00
Roland Shoemaker 403af37a39 Hide Authorization.Expires field when uninitialized 2015-06-17 18:34:30 -07:00
J.C. Jones 41f5788c77 Correct most `go lint` warnings. (274 -> 5) 2015-06-16 22:18:28 -05:00
J.C. Jones dbe88d5d80 Issue #344: RA: Pull out a `validateContacts` method
- Created a `validateContacts` method to avoid duplicated code
- Added tests for `validateContacts` and `validateEmail`
- Fix error formatting in `validateEmail`:
  Discovered while testing `validateEmail` that, if no MX records are found,
  `err` is returned, not an empty array. As such, the error message
   was misleading, so I consoldated the conditions into one.
2015-06-15 16:46:50 -05:00
J.C. Jones 2d79af0c69 Issue 344 Rework: Revert Internal Errors in RA, add validation to UpdateReg 2015-06-13 00:21:44 -05:00
J.C. Jones 1474b7f21f Resolves Issue #344: Only send InternalServerError when needed
Basically, just send InternalServerError when it indicates an internal state
was broken.
2015-06-13 00:21:44 -05:00
Roland Shoemaker 0265b6f5d0 Merge upstream/master and fix conflicts 2015-06-10 12:43:11 -07:00
Roland Shoemaker 370b6f9bf9 Return error from core.GoodKey 2015-06-06 17:12:16 -07:00
James 'J.C.' Jones 3acb03fdc9 Merge pull request #319 from letsencrypt/validate-contact
Validate contact details in the RA upon `new-reg`.
2015-06-06 07:57:16 -07:00
Roland Shoemaker 643bc4279c Move email validation to seperate function 2015-06-06 06:37:29 -07:00
Roland Shoemaker 28db5aab45 Merge master 2015-06-06 02:47:55 +01:00
Roland Shoemaker 23b0cfa29f Extend email parsing 2015-06-06 02:46:51 +01:00
Roland Shoemaker 4ecd6d58b6 Merge master 2015-06-06 02:11:46 +01:00
Roland Shoemaker bb5c042cef Fix tests and various other cleanup 2015-06-06 02:06:35 +01:00
Roland Shoemaker 0bfc50b7e5 Add check for max key size 2015-06-05 19:02:10 +01:00
Roland Shoemaker 84f187da96 Check MX records exist for provided emails 2015-06-05 15:27:07 +01:00
Roland Shoemaker 573e35ed56 Disallow multiple registrations with same key (and fix all related tests) 2015-06-04 20:21:59 +01:00
Roland Shoemaker 51890a9626 Move cert-csr check to boulder/core and review fixes 2015-06-02 17:56:28 +01:00
Roland Shoemaker 6114189865 Add CommonName (if present) to DNSNames 2015-06-01 17:02:37 +01:00
Roland Shoemaker 33df806d25 wfe test fixes + DNSNames and CommonName cleanup 2015-06-01 15:01:24 +01:00
Roland Shoemaker e5bf16711c Add generated cert checks 2015-06-01 14:00:49 +01:00
Richard Barnes 28e737bee0 Fixing build error induced in rebase 2015-06-01 02:17:55 -04:00
Richard Barnes 0d932c0a2d Merge branch 'rlb-review' of https://github.com/letsencrypt/boulder into rlb-review 2015-06-01 02:13:25 -04:00
Richard Barnes bfd9e4ac20 Fixing JCJ nits 2015-06-01 02:11:10 -04:00
Richard Barnes eaa3a8b65d Use a more proper algorithm for testing validation completeness 2015-06-01 02:08:46 -04:00
Richard Barnes ca74b08040 Aesthetic fixes to ra.go 2015-06-01 02:08:46 -04:00
Richard Barnes e30d3594f8 Put registration checks together 2015-06-01 02:07:40 -04:00
Richard Barnes 9917ca17f6 Clean up TODOs 2015-06-01 02:05:17 -04:00
Richard Barnes f1b2730c1b Fixing JCJ nits 2015-06-01 02:03:09 -04:00
J.C. Jones 535798883b Reclothe the naked commits. 2015-05-31 22:10:58 -07:00
Richard Barnes 8ea6de26b9 Use a more proper algorithm for testing validation completeness 2015-05-31 23:17:05 -04:00
Richard Barnes 6b20a0a489 Aesthetic fixes to ra.go 2015-05-31 23:04:35 -04:00
Richard Barnes 774b3fc7c1 Put registration checks together 2015-05-31 23:02:57 -04:00
Richard Barnes e3d9b2cc76 Clean up TODOs 2015-05-31 22:28:00 -04:00
Richard Barnes c0bacc3fb6 Add more detailed error code reporting 2015-05-31 15:58:08 -04:00
Richard Barnes 2419559f5c Add validity interval checking 2015-05-31 14:23:09 -04:00
Richard Barnes e2fa826c40 Issue #211 (partial) 2015-05-30 18:01:38 -04:00
Richard Barnes 138c946bd6 Issue #43 and Issue #205 2015-05-30 11:11:33 -04:00
Jacob Hoffman-Andrews b3b64fd10e Fix tests for goodkey branch. 2015-05-29 13:09:34 -07:00
Jacob Hoffman-Andrews 6a6a8aa72d Merge branch 'master' into goodkey
Conflicts:
	ca/certificate-authority.go
	ra/registration-authority.go
	ra/registration-authority_test.go
2015-05-29 12:26:24 -07:00
James 'J.C.' Jones 69967524cb Merge pull request #256 from letsencrypt/misc-fixes
Misc fixes
2015-05-29 07:15:13 -07:00
Roland Shoemaker 8846fd2c90 Merge upstream/master 2015-05-29 09:36:46 +01:00
Roland Shoemaker 601136059c audit fixes 2015-05-29 09:35:56 +01:00
Jacob Hoffman-Andrews ee57874d03 Misc fixes
Actually return error from NewCertificate in RA.
Export BOULDER_CONFIG in start.sh so it gets used.
Print error properly in test.js.
2015-05-29 00:09:55 -07:00
J.C. Jones d1321f2d78 More RPC fixes for Issue #202
- NewPendingAuthorization now uses a core.Authorization object, so
  that foreign key constraints are followed
- core.Authorization now serializes RegistrationID to JSON, so it has to get
  blanked out in WFE before transmission to client.
- Remove ParsedCertificate from core.Certificate, as type x509.Certificate cannot
  be marshaled.
- Added AssertDeepEquals and AssertMarhsaledEquals to test-tools.go
- Caught several overloaded and misleadingly named errors in WFE
2015-05-28 11:05:55 -07:00
Roland Shoemaker 81c7466e97 add rpc-wrapper and interface code 2015-05-28 09:58:16 +01:00