Commit Graph

69 Commits

Author SHA1 Message Date
Jacob Hoffman-Andrews 9423467142 Switch to our own fork of go-jose.
This is the result of `godep save -r ./...` and
`git rm -r -f Godeps/_workspace/src/github.com/square`

Our fork is currently at the head of go-jose when Richard made the local nonce
changes, with the nonce changes added on top. In other words, the newly created
files are exactly equal to the deleted files.

In a separate commit I will bring our own go-jose fork up to the remote head,
then update our deps.

Also note: Square's go-jose repo contains a `cipher` package. Since we don't
make any changes to that package, we leave it imported as-is.
2015-07-24 14:39:00 -07:00
Jacob Hoffman-Andrews 620a012c62 Rewrite go-jose dependencies to our fork. 2015-07-24 14:16:01 -07:00
J.C. Jones 41f5788c77 Correct most `go lint` warnings. (274 -> 5) 2015-06-16 22:18:28 -05:00
Jacob Hoffman-Andrews 80d5e50e42 Enable revocation by account key.
In addition to cert private key. This required modifying the GetCertificate*
functions to return core.Certificate instead of certificate bytes.
2015-06-15 12:33:50 -07:00
Roland Shoemaker c0b14c31c4 Dedup updateOCSPRequest struct 2015-06-11 11:02:40 -07:00
Roland Shoemaker 26d5ca1cf4 Merge branch 'master' of github.com:letsencrypt/boulder into rpc-struct-cleanup 2015-06-11 11:00:11 -07:00
Roland Shoemaker 798e56c012 Pull all shared request/response structs in RPC layer out to single definitions 2015-06-11 10:59:58 -07:00
J.C. Jones 2ad15a4a85 Issue #309: Produce OCSP Responses immediately upon issuance, if at all possible.
This approach performs a best-effort generation of the first OCSP response during
certificate issuance. In the event that OCSP generation fails, it logs a warning at
the Boulder-CA console, but returns successfully since the Certificate was itself
issued.
2015-06-11 11:31:04 -05:00
Roland Shoemaker e3eb074dd3 Review fixes 2015-06-10 14:16:06 -07:00
Roland Shoemaker 0265b6f5d0 Merge upstream/master and fix conflicts 2015-06-10 12:43:11 -07:00
Roland Shoemaker fe76c5e379 Review fixes and error shadowing cleanup 2015-06-09 17:07:49 -07:00
Roland Shoemaker 163cdde340 Remove duplicate audit logging in RPC layer 2015-06-09 14:47:46 -07:00
Roland Shoemaker 62ea00cd6e Merge branch 'master' of github.com:letsencrypt/boulder into rpc-errors 2015-06-09 10:25:44 -07:00
Roland Shoemaker eb8bdb323e Return errors across RPC calls 2015-06-08 22:16:47 -07:00
J.C. Jones 0c101f264b Add error checking to GenerateOCSP RPC
- While testing PKCS11 support, caused an error in signing that provoked an empty OCSP response to be saved to the DB
- In fact, the response saved was 726573706F6E7365 which, in ASCII, is "response"
- Fix typo in GenerateOCSP at the same time
2015-06-08 18:55:51 -07:00
J.C. Jones c21c6d0bdf Issue #249 - Refactor an interface for the RPC Client and RPC Server
- Added the skeleton of the first RPC wrapper test
- Does not close Issue #249; still need to implement a channel-RPC mechanism
2015-06-04 11:43:48 -07:00
Jacob Hoffman-Andrews ec82eaa26f Merge pull request #302 from letsencrypt/fix-startpy
Build and run cfssl on correct port.
2015-06-03 14:15:13 -07:00
Jacob Hoffman-Andrews c6f840f1fd Fix RPC error conditions for cert issuance.
Previously an issuance failure would bubble up empty cert responses from
CA->RA->WFE, which would generate confusing "asn1 truncated sequence" errors.
Now we get an error indicating the RPC failed.
2015-06-03 12:10:43 -07:00
Roland Shoemaker ada6ddd45e Only audit log err from GetCertificateByShortSerial RPC call if not sql.ErrNoRows 2015-06-03 20:01:46 +01:00
Jacob Hoffman-Andrews 026cb424fc Revert "Replace RevokeCertficate with something more in line with the spec"
This reverts commit b1bad40fe6.

Conflicts:
	wfe/web-front-end.go
2015-06-02 10:45:54 -07:00
Richard Barnes b1bad40fe6 Replace RevokeCertficate with something more in line with the spec 2015-06-01 02:11:10 -04:00
Richard Barnes e8edbf5f21 Making capitalization consistent with Go standards 2015-06-01 02:08:47 -04:00
Richard Barnes 2419559f5c Add validity interval checking 2015-05-31 14:23:09 -04:00
Richard Barnes 67b97c6b89 Issue #101 2015-05-30 11:28:08 -04:00
Roland Shoemaker 8846fd2c90 Merge upstream/master 2015-05-29 09:36:46 +01:00
Roland Shoemaker 601136059c audit fixes 2015-05-29 09:35:56 +01:00
J.C. Jones e14f59c559 Rework from PR #251: 2015-05-28 23:03:48 -07:00
J.C. Jones d1321f2d78 More RPC fixes for Issue #202
- NewPendingAuthorization now uses a core.Authorization object, so
  that foreign key constraints are followed
- core.Authorization now serializes RegistrationID to JSON, so it has to get
  blanked out in WFE before transmission to client.
- Remove ParsedCertificate from core.Certificate, as type x509.Certificate cannot
  be marshaled.
- Added AssertDeepEquals and AssertMarhsaledEquals to test-tools.go
- Caught several overloaded and misleadingly named errors in WFE
2015-05-28 11:05:55 -07:00
Roland Shoemaker 178acdc3f2 rpc argument typo 2015-05-28 10:25:11 +01:00
Roland Shoemaker 81c7466e97 add rpc-wrapper and interface code 2015-05-28 09:58:16 +01:00
J.C. Jones 58d7f46c02 Continued on RPC problems for Issue #202
- Implement MethodUpdateRegistration
- Add error logging to a lot of places it was missing
- Consolidate RevokeCertificate; we're doing it elsewhere anyway
- Fix erronous returns on RPC failures in several places
2015-05-28 00:00:11 -07:00
J.C. Jones e4e52e7315 More work on Issue #202 for RPC functions
- Fix a bunch of typos in rpc-wrappers.go
- Unblank `id` in core.Registration JSON:
  - It's not spec, but it's not hurting anything, and we reveal it to clients anyway.
  - We need knowledge of the ID in RPC, so if we don't want to include this in the object, we need to make a transfer object to wrap it.
- Make the RPC logs much clearer as to who's talking to who
- Typo in WFE where we called a registration an authz
2015-05-27 23:37:12 -07:00
J.C. Jones af0f8446eb Issue #202, Periodic OCSP Signer Tool
- Move dbMap construction and type converter into individual files in the sa package.
- Add DB configuration for the OCSP tool to the boulder config:
  - left to the user if they want to use different boulder-config.json files
    for different purposes.
- Added updater to Makefile
- Fix trailing ',' in the Boulder config, add more panic logging
- Ignore .pem files produced by the integration test
- Change RPC to use per-instance named reply-to queues.
- Finish OCSP Updater logic
- Rework RPC for OCSP to use a transfer object (due to serialization problems of x509.Certificate)
2015-05-27 22:01:29 -07:00
Jacob Hoffman-Andrews 6c6199023d Merge pull request #231 from letsencrypt/230-unknown-key-type
Resolved Issue #230
2015-05-26 15:05:34 -07:00
J.C. Jones bc3acca096 Resolved Issue #230
- Move setting the core.Registration.Key field from RA.NewRegistration to
  WFE.NewRegistration to avoid a chicken-and-egg problem.
- Note: I kept the RPC wrapper object even though it now only has one field.
  Seems like it's a good practice to use wrapper objects, even though we don't
  everywhere.
2015-05-26 14:44:15 -07:00
Jacob Hoffman-Andrews 19fd285859 Merge pull request #223 from rolandshoemaker/revoker
admin-revoker tool
2015-05-26 14:37:33 -07:00
Roland Shoemaker e1eeebce52 Only run validations against updated challenges (instead of everything) 2015-05-26 17:08:49 +01:00
Roland Shoemaker d184862427 gofmt and move deniedCSR table creation back to SA 2015-05-25 01:17:28 +01:00
Roland Shoemaker 0ab71bed62 initial revoker work 2015-05-23 12:46:56 +01:00
J.C. Jones 42302541bd Run `go fmt` for PR #186 2015-05-18 18:44:38 -07:00
J.C. Jones d2be0dcb95 Review updates 2015-05-18 18:24:37 -07:00
Richard Barnes c3b312118e Add audit logging
- Auditing for general errors in executables
- Auditing for improper messages received by WFE
- Automatic audit wlogging of software errors
- Audit logging for mis-routed messages
- Audit logging for certificate requests
- Auditing for improper messages received by WFE
- Add audit events table
- Expect more details in TestRegistration in web-front-end_test.go
- Remove "extra" debug details from web-front-end.go per Issue #174
- Improve test coverage of web-front-end.go
- WFE audit updates for revocation support rebase
- Add audit messages to RPC for Improper Messages and Error Conditions
- Also note misrouted messages
2015-05-18 18:23:08 -07:00
Roland Shoemaker e1ba291019 Store registration ID with certificate 2015-05-16 13:47:51 -07:00
Roland Shoemaker faa1d5ac45 review cleanups 2015-05-16 13:25:36 -07:00
Roland Shoemaker e233fdaa61 switch authz and pending_authz to store registration ID instead of key (and update all the random stuff they touched) 2015-05-14 14:14:36 -07:00
James 'J.C.' Jones 6be5c4910e Merge pull request #185 from rolandshoemaker/deny-store
Store and check previously denied CSRs
2015-05-14 09:03:06 -07:00
Roland Shoemaker b9745cf894 check key is assosiated with existing registration in verifyPOST 2015-05-13 19:16:20 -07:00
Jacob Hoffman-Andrews 98af69575b Clothe a return. 2015-05-13 17:36:38 -07:00
Jacob Hoffman-Andrews 3eed9e3f7c Move to Square's go-jose library. 2015-05-13 17:36:38 -07:00
Roland Shoemaker 5d5eea7071 switch to only store dns names 2015-05-13 12:08:50 -07:00