letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
boulder/db
History
James Renken e4668b4ca7
Deprecate DisableLegacyLimitWrites & UseKvLimitsForNewOrder flags; remove code using certificatesPerName & newOrdersRL tables (#7858) 
Remove code using `certificatesPerName` & `newOrdersRL` tables.

Deprecate `DisableLegacyLimitWrites` & `UseKvLimitsForNewOrder` flags.

Remove legacy `ratelimit` package.

Delete these RA test cases:

- `TestAuthzFailedRateLimitingNewOrder` (rl:
`FailedAuthorizationsPerDomainPerAccount`)
- `TestCheckCertificatesPerNameLimit` (rl: `CertificatesPerDomain`)
- `TestCheckExactCertificateLimit` (rl: `CertificatesPerFQDNSet`)
- `TestExactPublicSuffixCertLimit` (rl: `CertificatesPerDomain`)

Rate limits in NewOrder are now enforced by the WFE, starting here:
5a9b4c4b18/wfe2/wfe.go (L781)

We collect a batch of transactions to check limits, check them all at
once, go through and find which one(s) failed, and serve the failure
with the Retry-After that's furthest in the future. All this code
doesn't really need to be tested again; what needs to be tested is that
we're returning the correct failure. That code is
`NewOrderLimitTransactions`, and the `ratelimits` package's tests cover
this.

The public suffix handling behavior is tested by
`TestFQDNsToETLDsPlusOne`:
5a9b4c4b18/ratelimits/utilities_test.go (L9)

Some other RA rate limit tests were deleted earlier, in #7869.

Part of #7671.
 		2025-01-10 12:50:57 -08:00
..
gorm.go Replace explicit int loops with range-over-int (#7434) 2024-04-22 10:34:51 -07:00
gorm_test.go Improve MultiInserter (#6572) 2023-01-30 09:45:45 -08:00
interfaces.go Simplify streaming rows from the database (#7372) 2024-03-19 08:39:00 -07:00
map.go sa: refactor how metrics and logging are set up (#7031) 2023-08-08 09:51:23 -07:00
map_test.go Deprecate DisableLegacyLimitWrites & UseKvLimitsForNewOrder flags; remove code using certificatesPerName & newOrdersRL tables (#7858) 2025-01-10 12:50:57 -08:00
multi.go It's borpin' time! (#6982) 2023-07-17 14:38:29 -07:00
multi_test.go Improve MultiInserter (#6572) 2023-01-30 09:45:45 -08:00
qmarks.go Replace explicit int loops with range-over-int (#7434) 2024-04-22 10:34:51 -07:00
qmarks_test.go Re-enable errcheck linter (#6819) 2023-04-14 15:41:12 -04:00
rollback.go SA: use wrapped database maps/transactions. (#4585) 2019-12-04 13:03:09 -05:00
rollback_test.go It's borpin' time! (#6982) 2023-07-17 14:38:29 -07:00
transaction.go It's borpin' time! (#6982) 2023-07-17 14:38:29 -07:00