boulder/va
Jeff Hodges 7e157a5c1a va: format url as url in errors
When a URL couldn't be connected to in validateSimpleHTTP, the
fmt.Sprintf's using the URL would format it as something like:

    {https  <nil> kuba.us.to:443 .well-known/acme-challenge/-bgTYeerZbjhysBOgwIx_-7uVDnVnsaxagWvCk6lzNc   }

Instead of:

    https://kuba.us.to:443/.well-known/acme-challenge/-bgTYeerZbjhysBOgwIx_-7uVDnVnsaxagWvCk6lzNc

This would show up in errors like:

    Failed authorization procedure. kuba.us.to (simpleHttp): connection :: The server could not connect to the client for DV :: Could not connect to {https  <nil> kuba.us.to:443 .well-known/acme-challenge/-bgTYeerZbjhysBOgwIx_-7uVDnVnsaxagWvCk6lzNc   }

By passing in a plain URL struct to
Sprintf(), it wasn't using the *url.URL.String() method, but the
built-in struct formatting.

The fix is simple: make the url variable a `*url.URL` instead of a
`url.URL`.
2015-09-02 12:57:26 -07:00
..
validation-authority.go va: format url as url in errors 2015-09-02 12:57:26 -07:00
validation-authority_test.go Merge pull request #697 from letsencrypt/revoke-split 2015-09-01 14:08:33 -07:00