If you are the first person to add a feature to a Boulder command its very easy to forget to update the command's config structure to accommodate a `map[string]bool` entry and to pass it to `features.Set` in `main()`. See https://github.com/letsencrypt/boulder/issues/2533 for one example. I've fallen into this trap myself a few times so I'm going to try and save myself some future grief by fixing it across the board once and for all! This PR adds a `Features` config entry and a corresponding `features.Set` to: * ocsp-updater (resolves #2533) * admin-revoker * boulder-publisher * contact-exporter * expiration-mailer * expired-authz-purger * notify-mailer * ocsp-responder * orphan-finder These components were skipped because they already had features supported: * boulder-ca * boulder-ra * boulder-sa * boulder-va * boulder-wfe * cert-checker I deliberately skipped adding Feature support to: * single-ocsp (Its only configuration comes from the pkcs11key library and doesn't support features) * rabbitmq-setup (No configuration/features and we'll likely soon be rming this since the gRPC migration) * notafter-backfill (This is a one-off that will be deleted soon) |
||
|---|---|---|
| .. | ||
| testdata | ||
| main.go | ||
| main_test.go | ||