letsencrypt
/
boulder
mirror of https://github.com/letsencrypt/boulder.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
boulder/test
History
Daniel 758ebc3835
SA: Fix NewOrder ready status regression. 
In #3614 we adjusted the `SA.NewOrder` function to conditionally call
`ssa.statusForOrder` on the new order when `features.OrderReadyStatus`
was enabled. Unfortunately this call to `ssa.statusForOrder` happened
*before* the `req.BeganProcessing` field was initialized with a pointer
to a `false` bool. The `ssa.statusForOrder` function (correctly) assumes
that `req.BeganProcessing == nil` is illegal and doesn't correspond to
a known status. This results in NewOrder requests returning a 500 error
of the form:
> Internal error - Error creating new order - Order XXX is in an invalid
> state. No state known for this order's authorizations

Our integration tests missed this because we didn't have a test case
that issued for a set of names with one account, and then issued again
for the same set of names with the same account.

This commit fixes the original bug by moving the `BeganProcessing`
initialization before the call to `statusForOrder`. This commit also
adds an integration test to catch this sort of bug again in the
future.

Prior to the SA fix this test failed with the 500 server internal error
observed by the Certbot team. With the SA fix in place the test passes
again.
 		2018-04-12 13:23:54 -04:00
..
authz-filler Limit number of authzs purged at once. (#3177) 2017-10-23 11:20:07 -07:00
boulder-tools Tools: Support multiple Go versions in CI/Dev. (#3622) 2018-04-05 14:08:54 -07:00
config Fix whitespace 2018-03-15 10:34:15 -07:00
config-next Revert "Revert "V2: implement "ready" status for Order objects (#3614)" (#3643)" 2018-04-12 13:20:47 -04:00
ct-test-srv Add check for correct time in SCTs. (#3570) 2018-03-19 14:40:33 -04:00
dns-test-srv Allow configuration of multiple DNS resolvers (#3612) 2018-04-05 11:51:22 -04:00
grafana Update Boulderdash (#3232) 2017-11-13 13:22:45 -05:00
grpc-creds Fix issuerCert in test configs. (#3310) 2018-01-09 07:56:39 -05:00
gsb-test-srv Add time-dependent integration testing (#3060) 2017-09-13 12:34:14 -07:00
load-generator Size V2 newOrder requests randomly. (#3523) 2018-03-05 14:10:05 -08:00
mail-test-srv Update chisel2 and boulder-tools (#3495) 2018-02-28 15:21:40 -08:00
ocsp Add a host override flag for checkocsp. (#3035) 2017-09-01 11:56:48 -07:00
prometheus Add Prometheus collection for WFE to default config. (#2675) 2017-04-13 10:07:28 -07:00
secrets Run load-generator against V1 and V2 API in CI. (#3509) 2018-03-05 15:34:15 -05:00
vars Fix max_statement_time and long_query_time (#2311) 2016-11-08 09:07:36 -05:00
wfe-tls Fix issuerCert in test configs. (#3310) 2018-01-09 07:56:39 -05:00
PKI.md Expand PKI.md to include override instructions (#3321) 2018-02-01 17:15:22 -08:00
cfssl-config.json Move cert-csr check to boulder/core and review fixes 2015-06-02 17:56:28 +01:00
challenges-whitelist.json Implement regID whitelist for allowed challenge types. (#3352) 2018-01-10 13:44:53 -05:00
chisel.py Default to DNS challenge in chisel and chisel2. (#3621) 2018-04-05 15:37:10 -04:00
chisel2.py Default to DNS challenge in chisel and chisel2. (#3621) 2018-04-05 15:37:10 -04:00
create_db.sh Increase the MySQL container `max_connections`. (#3543) 2018-03-10 16:05:52 -05:00
ct-key.pem Use a EC key to sign CT signatures, plus properly load it 2015-12-15 13:50:43 -08:00
db-common.sh * Delete Policy DB.This is no longer needed now that we have a JSON policy file.* Fix tests.* Revert Dockerfile.* Fix create_db* Simplify user addition.* Fix tests.* Fix tests* Review fixes.https://github.com/letsencrypt/boulder/pull/1773 2016-04-29 12:12:24 -07:00
db.go * Delete Policy DB.This is no longer needed now that we have a JSON policy file.* Fix tests.* Revert Dockerfile.* Fix create_db* Simplify user addition.* Fix tests.* Fix tests* Review fixes.https://github.com/letsencrypt/boulder/pull/1773 2016-04-29 12:12:24 -07:00
drop_users.sql Add cmd/expired-authz-purger (#1828) 2016-06-03 16:00:19 -04:00
entrypoint.sh Remove references to buser in Dockerfile. (#3152) 2017-10-06 09:36:44 -04:00
example-expiration-template Review fixes 2015-07-27 12:46:09 -07:00
example-weak-keys.json Basic RSA known weak key checking (#2765) 2017-05-25 09:33:58 -07:00
hostname-policy.json Add explicit forbidden names validation to cert-checker (#2373) 2016-12-02 11:55:24 -08:00
integration-test.py RA: Don't lose CA error types when prefixing err msg. (#3633) 2018-04-10 11:28:03 -07:00
issuer-ocsp-responder.json Improve single-ocsp command (#2181) 2016-09-15 15:28:54 -07:00
make-softhsm.sh Switch to using go 1.9 (#3047) 2017-09-06 16:30:13 -04:00
migrate-up.sh Add a test that there are no outdated migrations. 2015-09-18 14:53:40 -07:00
mock-vendor.go Force godep to vendor github.com/golang/mock/mockgen/model (#2792) 2017-05-31 16:09:44 -07:00
rate-limit-policies-b.yml Increase default order rate limit (#3519) 2018-03-02 15:15:29 -05:00
rate-limit-policies.yml RA: Don't lose CA error types when prefixing err msg. (#3633) 2018-04-10 11:28:03 -07:00
requirements.txt Fix issuerCert in test configs. (#3310) 2018-01-09 07:56:39 -05:00
sa_db_users.sql ACMEv2: Add pending order reuse (#3290) 2018-01-02 13:27:16 -08:00
setup.sh Reduce spurious errors in integration test (#3436) 2018-02-12 18:17:50 -08:00
startservers.py Remove multi-va errors in integration tests. (#3448) 2018-02-15 09:56:04 -05:00
test-ca.der Unflake OCSP integration test 2015-10-21 14:38:15 -07:00
test-ca.key Make it easier to start a test config. 2015-04-09 18:26:40 -07:00
test-ca.key-pkcs11.json Improve single-ocsp command (#2181) 2016-09-15 15:28:54 -07:00
test-ca.key.der Add DER form of test-ca key in-tree. (#2041) 2016-07-12 09:06:59 -07:00
test-ca.pem Unflake OCSP integration test 2015-10-21 14:38:15 -07:00
test-ca2.pem Add multi-issuer support to the CA. 2016-03-21 20:56:58 -07:00
test-key-5.der Fix wfe2 key rollover (#3373) 2018-01-18 14:31:48 -08:00
test-no-outdated-migrations.sh Fix mktemp to be MacOS compatible 2015-09-23 13:16:16 -07:00
test-root.key Unflake OCSP integration test 2015-10-21 14:38:15 -07:00
test-root.key-pkcs11.json Improve single-ocsp command (#2181) 2016-09-15 15:28:54 -07:00
test-root.key.der Improve single-ocsp command (#2181) 2016-09-15 15:28:54 -07:00
test-root.pem Unflake OCSP integration test 2015-10-21 14:38:15 -07:00
test-tools.go Add CAAIdentities and Website to /directory "meta". (#3588) 2018-03-22 16:12:43 -04:00
travis-before-install.sh use go_import_path setting in Travis CI (#2923) 2017-07-31 10:47:55 -07:00
v2_integration.py SA: Fix NewOrder ready status regression. 2018-04-12 13:23:54 -04:00