Remove the last of the gRPC wrapper files. In order to do so: - Remove the `core.StorageGetter` interface. Replace it with a new interface (whose methods include the `...grpc.CallOption` arg) inside the `sa/proto/` package. - Remove the `core.StorageAdder` interface. There's no real use-case for having a write-only interface. - Remove the `core.StorageAuthority` interface, as it is now redundant with the autogenerated `sapb.StorageAuthorityClient` interface. - Replace the `certificateStorage` interface (which appears in two different places) with a single unified interface also in `sa/proto/`. - Update all test mocks to include the `_ ...grpc.CallOption` arg in their method signatures so they match the gRPC client interface. - Delete many methods from mocks which are no longer necessary (mostly because they're mocking old authz1 methods that no longer exist). - Move the two `test/inmem/` wrappers into their own sub-packages to avoid an import cycle. - Simplify the `satest` package to satisfy one of its TODOs and to avoid an import cycle. - Add many methods to the `test/inmem/sa/` wrapper, to accommodate all of the methods which are called in unittests. Fixes #5600 |
||
|---|---|---|
| .. | ||
| proto | ||
| challenges.go | ||
| challenges_test.go | ||
| core_test.go | ||
| interfaces.go | ||
| objects.go | ||
| objects_test.go | ||
| util.go | ||
| util_test.go | ||