Although https://github.com/letsencrypt/boulder/pull/8231 fixed csr.CNFromCSR to ignore Common Names that are valid IPs, that didn't fully solve our issue: identifier.FromCSR still extracts the CN and assumes that it is a dnsName, leading to a mismatch between the CSR's identifiers and the Order's identifiers. Instead, let's outright reject all CSRs which carry an IP in their Subject Common Name. Although this doesn't have the elegance of rejecting such CNs on a profile-by-profile basis, it matches our ongoing effort to do away with CNs entirely. |
||
|---|---|---|
| .. | ||
| csr.go | ||
| csr_test.go | ||