boulder/core
Aaron Gable 1b7eb3d978
RA: Simplify FinalizeOrder flow (#6588)
Simplify the control flow of the FinalizeOrder handler to make it easier
to read and reason about:
- Move all validation to before we set the order to Processing, and put
it all in a single helper funcion.
- Move almost all logEvent/trace handling directly into FinalizeOrder so
it cannot be missed.
- Flatten issueCertificate and issueCertificateInner into a single
helper function, now that they're no longer being called from both
ACMEv1 and v2 entry points.
- Other minor cleanups, such as making SolvedBy not return a pointer and
making matchesCSR private.

This paves the way for making both issueCertificateInner and failOrder
asynchronous, which we plan to do in the near future.

Part of #6575
2023-01-25 17:59:54 -08:00
..
proto SA: Add GetRevokedCerts method (#6170) 2022-06-27 13:33:40 -07:00
challenges.go RA: Simplify FinalizeOrder flow (#6588) 2023-01-25 17:59:54 -08:00
challenges_test.go Make authz2 the default storage format (#4476) 2019-10-21 15:29:15 -04:00
core_test.go dependencies: Replace square/go-jose.v2 with go-jose/go-jose.v2 (#6598) 2023-01-24 12:08:30 -05:00
interfaces.go RA: Simplify FinalizeOrder flow (#6588) 2023-01-25 17:59:54 -08:00
objects.go RA: Simplify FinalizeOrder flow (#6588) 2023-01-25 17:59:54 -08:00
objects_test.go RA: Simplify FinalizeOrder flow (#6588) 2023-01-25 17:59:54 -08:00
util.go dependencies: Replace square/go-jose.v2 with go-jose/go-jose.v2 (#6598) 2023-01-24 12:08:30 -05:00
util_test.go dependencies: Replace square/go-jose.v2 with go-jose/go-jose.v2 (#6598) 2023-01-24 12:08:30 -05:00