- Remove error signatures from log methods. This means fewer places where errcheck will show ignored errors. - Pull in latest cfssl to be compatible with errorless log messages. - Reduce the number of message priorities we support to just those we actually use. - AuditNotice -> AuditInfo - Remove InfoObject (only one use, switched to Info) - Remove EmergencyExit and related functions in favor of panic - Remove SyslogWriter / AuditLogger separate types in favor of a single interface, Logger, that has all the logging methods on it. - Merge mock log into logger. This allows us to unexport the internals but still override them in the mock. - Shorten names to be compatible with Go style: New, Set, Get, Logger, NewMock, etc. - Use a shorter log format for stdout logs. - Remove "... Starting" log messages. We have better information in the "Versions" message logged at startup. Motivation: The AuditLogger / SyslogWriter distinction was confusing and exposed internals only necessary for tests. Some components accepted one type and some accepted the other. This made it hard to consistently use mock loggers in tests. Also, the unnecessarily fat interface for AuditLogger made it hard to meaningfully mock out. |
||
|---|---|---|
| .. | ||
| database | ||
| requirements | ||
| rabbitmq_acl_configure.sh | ||