linkerd
/
linkerd2-proxy
mirror of https://github.com/linkerd/linkerd2-proxy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Mark tcp_connect_err tests as macos-specific (#63) 

The `tcp_connect_err` tests do not pass on Linux.

I initially observed that the errno produced is ECONNREFUSED on Linux,
not EXFULL, but even changing this does not help the test to pass
reliably, as the socket teardown semantics appear to be slightly
different.

In order to prevent spurious test failures during development, this
change marks these two tests as macos-specific.
This commit is contained in:
Oliver Gould 2018-08-14 12:32:41 -07:00 committed by GitHub
parent 7131d3ccae
commit 0d890dab6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/telemetry.rs
View File

@ -815,6 +815,7 @@ mod transport {
}
#[test]
#[cfg(macos)]
#[cfg_attr(not(feature = "flaky_tests"), ignore)]
fn inbound_tcp_connect_err() {
let _ = env_logger::try_init();
@ -839,12 +840,13 @@ mod transport {
// code.
assert_contains!(metrics.get("/metrics"),
"tcp_close_total{direction=\"inbound\",peer=\"dst\",tls=\"no_identity\",no_tls_reason=\"not_http\",classification=\"failure\",errno=\"EXFULL\"} 1");
// Connection to the client should have closed cleanly.
// Connection from the client should have closed cleanly.
assert_contains!(metrics.get("/metrics"),
"tcp_close_total{direction=\"inbound\",peer=\"src\",tls=\"disabled\",classification=\"success\"} 1");
}
#[test]
#[cfg(macos)]
#[cfg_attr(not(feature = "flaky_tests"), ignore)]
fn outbound_tcp_connect_err() {
let _ = env_logger::try_init();
@ -869,7 +871,7 @@ mod transport {
// code.
assert_contains!(metrics.get("/metrics"),
"tcp_close_total{direction=\"outbound\",peer=\"dst\",tls=\"no_identity\",no_tls_reason=\"not_http\",classification=\"failure\",errno=\"EXFULL\"} 1");
// Connection to the client should have closed cleanly.
// Connection from the client should have closed cleanly.
assert_contains!(metrics.get("/metrics"),
"tcp_close_total{direction=\"outbound\",peer=\"src\",tls=\"internal_traffic\",classification=\"success\"} 1");
}