mirror of https://github.com/linkerd/linkerd2.git
Authenticate requests when setting up `just` in CI (#10109)
In order to list available releases, `extractions/setup-just` has to make API requests to the GitHub API. The official docs say that in some circumstances, it is possible for the request to be rate-limited. Since we might end up making many GitHub requests in CI (e.g when updating dependencies) we have started bumping into this issue more and more. Rate-limited requests fail the workflow's step. We have to manually retry each step; this can end up wasting time for reviewers and it makes dependency updates a bit harder to deal with. Rate limitations can be avoided by running the action with our actions secret. This change adds the 'GITHUB_TOKEN' environment variable to all three places where we run `setup-just`. Example of error message when we are rate limited: "Error: API rate limit exceeded for <RUNNER-IP> (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)" Signed-off-by: Matei David <matei@buoyant.io>
This commit is contained in:
parent
207d7ec20a
commit
04126a8473
|
|
@ -174,6 +174,8 @@ jobs:
|
|||
- v1.25
|
||||
steps:
|
||||
- uses: extractions/setup-just@95b912dc5d3ed106a72907f2f9b91e76d60bdb76
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
- uses: olix0r/cargo-action-fmt/setup@9269f3aa1ff01775d95efc97037e2cbdb41d9684
|
||||
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
|
||||
- uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a
|
||||
|
|
@ -353,6 +355,8 @@ jobs:
|
|||
- v1.25
|
||||
steps:
|
||||
- uses: extractions/setup-just@95b912dc5d3ed106a72907f2f9b91e76d60bdb76
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
- uses: actions/setup-go@6edd4406fa81c3da01a34fa6f6343087c207a568
|
||||
with:
|
||||
go-version: '1.18'
|
||||
|
|
|
|||
|
|
@ -214,6 +214,8 @@ jobs:
|
|||
echo "CMD=$CMD" >> "$GITHUB_ENV"
|
||||
"$CMD" version --client
|
||||
- uses: extractions/setup-just@95b912dc5d3ed106a72907f2f9b91e76d60bdb76
|
||||
env:
|
||||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
- uses: azure/setup-kubectl@e1be5e75ed9741a7c467f4832ecb259a83174311
|
||||
- name: Setup k3d
|
||||
run: |
|
||||
|
|
|
|||
Loading…
Reference in New Issue