From 065dd3ec9d4b84c90383b31be16ccadd34a8ab0d Mon Sep 17 00:00:00 2001 From: Andrew Seigner Date: Fri, 26 Jul 2019 13:09:41 -0700 Subject: [PATCH] Add "can create cronjobs" to linkerd check (#3133) PR #3056 introduced a cluster heartbeat cronjob to the Linkerd installation. This implies the user installing Linkerd requires the privileges to create CronJobs. Update `linkerd check` to validate the user has privileges necessary to create CronJobs. Fixes #3057 Signed-off-by: Andrew Seigner --- pkg/healthcheck/healthcheck.go | 7 +++++++ test/testdata/check.pre.golden | 1 + 2 files changed, 8 insertions(+) diff --git a/pkg/healthcheck/healthcheck.go b/pkg/healthcheck/healthcheck.go index c7675d5ee..33bb790f7 100644 --- a/pkg/healthcheck/healthcheck.go +++ b/pkg/healthcheck/healthcheck.go @@ -387,6 +387,13 @@ func (hc *HealthChecker) allCategories() []category { return hc.checkCanCreate(hc.ControlPlaneNamespace, "extensions", "v1beta1", "deployments") }, }, + { + description: "can create CronJobs", + hintAnchor: "pre-k8s", + check: func(context.Context) error { + return hc.checkCanCreate(hc.ControlPlaneNamespace, "batch", "v1beta1", "cronjobs") + }, + }, { description: "can create ConfigMaps", hintAnchor: "pre-k8s", diff --git a/test/testdata/check.pre.golden b/test/testdata/check.pre.golden index f5f6be484..a8bec1730 100644 --- a/test/testdata/check.pre.golden +++ b/test/testdata/check.pre.golden @@ -19,6 +19,7 @@ pre-kubernetes-setup √ can create ServiceAccounts √ can create Services √ can create Deployments +√ can create CronJobs √ can create ConfigMaps √ no clock skew detected