Fail CI on unlinted js code (#2178)

I noticed that #2131 was able to merge even though it contained a missing ;
which should have failed lint checks. I think the problem is that if fix is
enabled, running bin/web build fixes the issue and then the lint checks pass on
the fixed but uncommitted code.

We should avoid autofixing in environments that aren't development to avoid
merging unfixed code to master.
This commit is contained in:
Risha Mars 2019-01-30 15:58:48 -08:00 committed by GitHub
parent fe234cade1
commit 067a70e0d2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions

View File

@ -35,6 +35,6 @@ TapLink.propTypes = {
TapLink.defaultProps = {
disabled: false
}
};
export default TapLink;

View File

@ -38,7 +38,7 @@ module.exports = {
{
loader: 'eslint-loader',
options: {
fix: true,
fix: process.env.NODE_ENV === 'development',
emitWarning: process.env.NODE_ENV === 'development'
}
}