From 45aa10dcc238610371e9a26173f161c0078931b4 Mon Sep 17 00:00:00 2001 From: "Carol A. Scott" Date: Thu, 28 Mar 2019 16:09:09 -0700 Subject: [PATCH] Modifying Contribution Guidelines for PRs (#2587) This PR modifies the Linkerd2 Contribution Guidelines. It adds a request that PRs include instructions on how to test changes, and to include a screenshot if there is a UI change. --- CONTRIBUTING.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7f620ab56..d0c76d4c2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,6 +34,9 @@ Do you have an improvement? 2. We will try to respond to your issue promptly. 3. Fork this repo, develop and test your code changes. See the project's [README](README.md) for further information about working in this repository. 4. Submit a pull request against this repo's `master` branch. + - Include instructions on how to test your changes. + - If you are making a change to the user interface (UI), include a + screenshot of the UI before and after your changes. 5. Your branch may be merged once all configured checks pass, including: - The branch has passed tests in CI. - A review from appropriate maintainers (see [MAINTAINERS.md](MAINTAINERS.md) and [GOVERNANCE.md](GOVERNANCE.md))