linkerd
/
linkerd2
mirror of https://github.com/linkerd/linkerd2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't skip pushing images if tag is already there (#5128) 

gcr.io has an issue that it's not possible to update multi-arch images
(see eclipse/che#16983 and open-policy-agent/gatekeeper#665).

We're now relying on ghcr.io instead, which I verified doesn't have this
bug, so we can stop skipping these pushes.
This commit is contained in:
Alejandro Pedraza 2020-10-23 13:13:42 -05:00 committed by GitHub
parent 5c9d34846e
commit 5de85d9320
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
bin/_docker.sh
View File

@ -65,15 +65,6 @@ docker_build() {
output_params="--load" output_params="--load"
if [ -n "$DOCKER_MULTIARCH" ]; then if [ -n "$DOCKER_MULTIARCH" ]; then
# Pushing multi-arch images to gcr.io with the same tag that already exists is not possible
# The issue is on gcr as pushing the same tag in docker hub works fine
# Related issues: https://github.com/eclipse/che/issues/16983, https://github.com/open-policy-agent/gatekeeper/issues/665
if (docker buildx imagetools inspect "$repo:$tag"); then
echo "Build skipped. Image already exists"
exit 0
fi
output_params="--platform $SUPPORTED_ARCHS" output_params="--platform $SUPPORTED_ARCHS"
if [ -n "$DOCKER_PUSH" ]; then if [ -n "$DOCKER_PUSH" ]; then
output_params+=" --push" output_params+=" --push"