linkerd
/
linkerd2
mirror of https://github.com/linkerd/linkerd2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

grafana: Show TCP closes by errno (#1839) 

linkerd/linkerd2-proxy#116 removes the `classification` label for the
`tcp_close_total` metric because TCP sockets that close with an error
do not actually indicate any sort of failure -- many graceful shutdown
situations can still cause a socket error.

This change uses the `errno` label to enumerate tcp_close_total metrics.
This commit is contained in:
Oliver Gould 2018-11-02 10:20:11 -07:00 committed by GitHub
parent a6c5f9820e
commit 747fd328e9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
grafana/dashboards/deployment.json
View File

@ -706,10 +706,10 @@
"steppedLine": false,
"targets": [
{
"expr": "tcp_close_total{namespace=\"$namespace\", deployment=\"$deployment\", direction=\"inbound\",classification=\"failure\"}",
"expr": "tcp_close_total{namespace=\"$namespace\", deployment=\"$deployment\", direction=\"inbound\",errno!=\"\"}",
"format": "time_series",
"intervalFactor": 1,
"legendFormat": "{{peer}} {{classification}}",
"legendFormat": "{{peer}} {{errno}}",
"refId": "A"
}
],
@ -1571,10 +1571,10 @@
"steppedLine": false,
"targets": [
{
"expr": "tcp_close_total{namespace=\"$namespace\", deployment=\"$deployment\", direction=\"outbound\",classification=\"failure\"}",
"expr": "tcp_close_total{namespace=\"$namespace\", deployment=\"$deployment\", direction=\"outbound\",errno!=\"\"}",
"format": "time_series",
"intervalFactor": 1,
"legendFormat": "{{peer}} {{classification}}",
"legendFormat": "{{peer}} {{errno}}",
"refId": "A"
}
],

3
grafana/dashboards/health.json
View File

@ -694,9 +694,10 @@
"steppedLine": false,
"targets": [
{
"expr": "tcp_close_total{deployment=\"$deployment\", namespace=\"$namespace\", direction=\"inbound\",classification=\"failure\"}",
"expr": "tcp_close_total{deployment=\"$deployment\", namespace=\"$namespace\", direction=\"inbound\",errno!=\"\"}",
"format": "time_series",
"intervalFactor": 1,
"legendFormat": "{{peer}} {{errno}}",
"refId": "A"
}
],